New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATS item is too specific #279

Closed
jyutzler opened this Issue Feb 1, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@jyutzler
Contributor

jyutzler commented Feb 1, 2017

/base/core/container/data/table_data_types

The test method requests SELECT table_name FROM gpkg_contents WHERE data_type = ‘features’ but this requirement applies to all GeoPackage data types, not just features. Recommend removing the WHERE clause from the SQL statement in this abstract test.

jyutzler added a commit to jyutzler/geopackage that referenced this issue Feb 1, 2017

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Feb 14, 2017

After discussion with the SWG, we determined that it would be best to keep the WHERE clause but to add the other core types to it. This will keep extensions from accidentally tripping on this requirement.

@jyutzler jyutzler added this to the 1.2-comment period milestone Feb 14, 2017

jyutzler added a commit that referenced this issue Feb 27, 2017

Merge pull request #280 from jyutzler/i279
removing incorrect WHERE clause #279

@jyutzler jyutzler closed this Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment