New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLOB Format tests are wrong #285

Closed
jyutzler opened this Issue Feb 9, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@jyutzler
Contributor

jyutzler commented Feb 9, 2017

http://geopackage.org/spec/#_data_23

Test method 3.c.iv.

  • ST_IsEmpty is not part of the specification. This clause should be removed.
  • "gc.flags.envelope != 0 and envelope values are not NaN" is illogical. Maybe the original author got the logic backwards? But anyway, the envelope flag determines the presence/absence of envelope values and indicates the size. There is no obvious way to test whether the bytes in the envelope position constitute a valid envelope. This clause pertains to the SHALL statement at the very end of 2.1.3.1.1.

I recommend dropping all of 3.c.iv. from the test.

http://geopackage.org/spec/#_data_24

/opt/features/geometry_encoding/data/core_types_existing_sparse_data

  • Test method 5.b.ii. is not testable; recommend removing
  • Test methods 5.b.iii-vi seem to be overreach - there is no explicit requirement that geometries must stay within the specified envelope; recommend removing
  • Test method 5.b.vii is reasonable. Maybe this one can be moved to the previous test and this test can be otherwise removed.

/opt/features/geometry_encoding/data/core_types_all_types_test_data

This test is not appropriate for a data encoding standard. It is more of a test of a client capability. Recommend removing.

@jyutzler jyutzler changed the title from BLOB Format test is wrong to BLOB Format tests are wrong Feb 9, 2017

@jyutzler jyutzler added this to the 1.2-comment period milestone Feb 14, 2017

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Feb 15, 2017

Note there is some overlap with #288 here. The corrective action there applies here as well.

  • Remove dependencies on SpatiaLite
  • Update wording for test for extents
  • Note that 5.b.ii requires a spatial library
  • Remove 5.b.iii-vi
  • Move 5.b.vii to previous test
  • Remove tests that pertain to a client app

jyutzler added a commit to jyutzler/geopackage that referenced this issue Feb 15, 2017

@jyutzler jyutzler referenced this issue Feb 15, 2017

Merged

fixing #285 #291

jyutzler added a commit that referenced this issue Feb 27, 2017

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Feb 27, 2017

Approved by the SWG today.

@jyutzler jyutzler closed this Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment