Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLOB Format tests are wrong #285

jyutzler opened this issue Feb 9, 2017 · 2 comments

BLOB Format tests are wrong #285

jyutzler opened this issue Feb 9, 2017 · 2 comments


Copy link

jyutzler commented Feb 9, 2017

Test method 3.c.iv.

  • ST_IsEmpty is not part of the specification. This clause should be removed.
  • "gc.flags.envelope != 0 and envelope values are not NaN" is illogical. Maybe the original author got the logic backwards? But anyway, the envelope flag determines the presence/absence of envelope values and indicates the size. There is no obvious way to test whether the bytes in the envelope position constitute a valid envelope. This clause pertains to the SHALL statement at the very end of

I recommend dropping all of 3.c.iv. from the test.


  • Test method 5.b.ii. is not testable; recommend removing
  • Test methods 5.b.iii-vi seem to be overreach - there is no explicit requirement that geometries must stay within the specified envelope; recommend removing
  • Test method 5.b.vii is reasonable. Maybe this one can be moved to the previous test and this test can be otherwise removed.


This test is not appropriate for a data encoding standard. It is more of a test of a client capability. Recommend removing.

@jyutzler jyutzler changed the title BLOB Format test is wrong BLOB Format tests are wrong Feb 9, 2017
@jyutzler jyutzler added this to the 1.2-comment period milestone Feb 14, 2017
Copy link
Contributor Author

jyutzler commented Feb 15, 2017

Note there is some overlap with #288 here. The corrective action there applies here as well.

  • Remove dependencies on SpatiaLite
  • Update wording for test for extents
  • Note that 5.b.ii requires a spatial library
  • Remove 5.b.iii-vi
  • Move 5.b.vii to previous test
  • Remove tests that pertain to a client app

jyutzler added a commit to jyutzler/geopackage that referenced this issue Feb 15, 2017
@jyutzler jyutzler mentioned this issue Feb 15, 2017
jyutzler added a commit that referenced this issue Feb 27, 2017
Copy link
Contributor Author

Approved by the SWG today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

No branches or pull requests

1 participant