New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements 32/33 might not be testable #288

Closed
jyutzler opened this Issue Feb 10, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@jyutzler
Contributor

jyutzler commented Feb 10, 2017

Requirement 32 says that the geometry types in a geometry column must correspond to the geometry type specified. However, the ATS says to test using ST_GeometryType and GPKG_IsAssignable, functions that are not actually available in the base spec.

Requirement 33 suffers from a similar problem, requiring ST_SRID.

Should we discard the requirements, the tests, or both? Can you think of a straightforward way to test this?

@jyutzler jyutzler changed the title from Requirement 32 might not be testable to Requirements 32/33 might not be testable Feb 10, 2017

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Feb 13, 2017

At the SWG today we determined that explicit dependencies on SpatiaLite should be avoided in any part of the spec that pertains to the core.

Corrective actions:

  • Add a note at the top of Annex A indicating that some tests (marked with a *) require a spatial engine such as SpatialLite
  • Remove references to ST_* and update the abstract tests to indicate the nature of the tests that have to be written

@jyutzler jyutzler added this to the 1.2-comment period milestone Feb 14, 2017

jyutzler added a commit to jyutzler/geopackage that referenced this issue Feb 15, 2017

@jyutzler jyutzler referenced this issue Feb 15, 2017

Merged

fixing #288 #293

jyutzler added a commit that referenced this issue Feb 27, 2017

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Feb 27, 2017

PR 293 confirmed by SWG today.

@jyutzler jyutzler closed this Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment