New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify "non null" constraint for views #395

Closed
jyutzler opened this Issue Nov 8, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@jyutzler
Contributor

jyutzler commented Nov 8, 2017

Our DDL and sample feature table or view definition indicate that feature tables shall have the NOT NULL constraint on the primary key column. However, because of the way SQLite does things, there is no way to check this for views - NOT NULL always comes back false for them.

In response, we should update the ATS/ETS to not require this constraint for views and to provide some explanatory text explaining the situation. This will probably also apply to other content types (tiles, etc.).

@jyutzler jyutzler added this to the post 1.2 milestone Nov 8, 2017

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Nov 12, 2017

We regularly use the term "updatable view". (For example, Requirement 29.) Is that really a thing in SQLite? My understanding is no, and this suggests a sweep of the term and a set of corresponding changes. This could be a bit of a chore.

@rcasscslt

This comment has been minimized.

Contributor

rcasscslt commented Nov 12, 2017

jyutzler added a commit that referenced this issue Dec 18, 2017

Merge pull request #396 from jyutzler/i395
clarifications on views #395
@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Dec 18, 2017

Approved by SWG today.

@jyutzler jyutzler closed this Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment