Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry Encoding Clarification for Non-Linear Geometry Types #402

Closed
bosborn opened this issue Dec 20, 2017 · 3 comments
Closed

Geometry Encoding Clarification for Non-Linear Geometry Types #402

bosborn opened this issue Dec 20, 2017 · 3 comments

Comments

@bosborn
Copy link
Contributor

@bosborn bosborn commented Dec 20, 2017

Do the non-linear geometry type extension codes result in a GeoPackageBinary type bit of 0 (StandardGeoPackageBinary) or 1 (ExtendedGeoPackageBinary)?

It is validated to always be 0 in ets-gpkg12. Was this bit only meant to be 1 for the deprecated user defined geometry types? It's a little confusing that the non-linear geometry types require an extension but are encoded with an extended bit of 0 (StandardGeoPackageBinary) instead of 1 (ExtendedGeoPackageBinary).

@jyutzler
Copy link
Contributor

@jyutzler jyutzler commented Dec 22, 2017

Yeah it is a little confusing. I think that anything on this list gets a 0 and anything for the deprecated extension gets a 1. I'm going to leave this open until I can get someone else to confirm.

@pepijnve
Copy link
Contributor

@pepijnve pepijnve commented Dec 26, 2017

I'm not sure what the intention was for this either anymore. The idea of the extension bit was that it provided an indication that the geometry body was not encoded in standard WKB. Instead it started with a vendor tag followed by vendor specific content.
The non-linear geometry types are still encoded in standard WKB, so not setting the extended flag seems like the correct thing to do.

@jyutzler
Copy link
Contributor

@jyutzler jyutzler commented Jan 26, 2018

closed by #404

@jyutzler jyutzler closed this Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.