New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE3 Trigger needs to be reviewed #414

Closed
KRyden opened this Issue Mar 12, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@KRyden

KRyden commented Mar 12, 2018

The update3 trigger needs to have the “of ” portion (in yellow below) struck. As written the update3 trigger will only fire when the geometry is actually updated because of the “of ” clause – the key action this trigger is designed to handle is when the ID is changed – it can also deal with a geometry change at the same time – but as written will not fire if only the ID is changed.

This has not surfaced in the field because most SQLite applications never change the internal id value of an existing row. This would be hard to debug in the field…

update3 trigger logic problem

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Mar 13, 2018

@rouault What do you think?

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Mar 13, 2018

If we confirm this is an issue, this would be a good reason to issue a GeoPackage corrigendum. The ETS would be updated so that 1.2.0 and older work on either version of the trigger and 1.2.1 and later require the updated version.

@rouault

This comment has been minimized.

Contributor

rouault commented Mar 13, 2018

@jyutzler I fully agree with Keith's finding. I could reproduce an issue with the initial trigger SQL, and it was fixed with Keith's changes. Just fixed it accordingly in OGR.

rouault added a commit to OSGeo/gdal that referenced this issue Mar 13, 2018

rouault added a commit to OSGeo/gdal that referenced this issue Mar 13, 2018

kwrobot pushed a commit to aashish24/gdal-svn that referenced this issue Mar 13, 2018

jyutzler added a commit to jyutzler/geopackage that referenced this issue Mar 15, 2018

@jyutzler jyutzler added this to the post 1.2 milestone Mar 15, 2018

jyutzler added a commit that referenced this issue Apr 9, 2018

Merge pull request #415 from jyutzler/i414
#414 removing erroneous part of trigger

@jyutzler jyutzler closed this Apr 12, 2018

@jyutzler jyutzler referenced this issue Jun 22, 2018

Open

Report warnings #72

0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment