Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Req 2 for version 1.3.0 ? #519

Closed
rouault opened this issue May 5, 2020 · 1 comment · Fixed by #522
Closed

Update Req 2 for version 1.3.0 ? #519

rouault opened this issue May 5, 2020 · 1 comment · Fixed by #522
Milestone

Comments

@rouault
Copy link
Contributor

rouault commented May 5, 2020

Req 2 mentions "For GeoPackage Version 1.2.1 this value is 0x000027D9 (the hexadecimal value for 10201)".

  • Should this be updated to "For GeoPackage Version 1.3.0 this value is 0x0000283C (the hexadecimal value for 10300)" ?
  • Test Case ID /base/core/container/data/file_format/application_id mentions "Fail if the integer representation of the user_version string is less than 10200". Should this be changed to 10300 ? And possible add a prior step "if the integer representation of the user_version string is less than 10300, all back to the tests for GeoPackage 1.2" ?
@jyutzler
Copy link
Contributor

jyutzler commented May 5, 2020

Yeah, good point. There are a bunch of perfunctory things that have not been done yet.

  • "For GeoPackage Version 1.3.0 this value is 0x0000283C (the hexadecimal value for 10300)"
  • Test Case ID /base/core/container/data/file_format/application_id mentions "Fail if the integer representation of the user_version string is less than 10200". Should this be changed to 10300 ? No this is correct as written. GPKG is for 1.2 and later. GP10 is for 1.0, GP11 is for 1.1.
  • Add a step "if the integer representation of the user_version string is less than 10300, fall back to the tests for GeoPackage 1.2" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants