New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header length specification. #209

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@bradh
Contributor

bradh commented Apr 16, 2016

If you want it to be 16 bytes to match the way sqlite does it, you
need to figure out how to express the embedded NULL (C escape \0)
in spec-compliant way.

Fix header length specification.
If you want it to be 16 bytes to match the way sqlite does it, you
need to figure out how to express the embedded NULL (C escape \0)
in spec-compliant way.
@pepijnve

This comment has been minimized.

Contributor

pepijnve commented Apr 18, 2016

Perhaps it's clearer as 'the first 16-bytes shall be the zero terminated ASCII string ...' or add ' including the nul terminator character at the end' like the SQLite format spec does it.

@bradh

This comment has been minimized.

Contributor

bradh commented Apr 19, 2016

Zero terminated seems worse (because that could be ASCII 0x30). I can live with NUL terminated.

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented May 8, 2016

In the 4/21 SWG we decided to say NULL terminated ASCII string. I'm just going to close this PR and fix it separately. Sorry for the delay.

@jyutzler jyutzler closed this May 8, 2016

jyutzler added a commit to jyutzler/geopackage that referenced this pull request May 8, 2016

jyutzler added a commit that referenced this pull request May 17, 2016

@jyutzler jyutzler added this to the 1.2 milestone Oct 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment