Fix header length specification. #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want it to be 16 bytes to match the way sqlite does it, you need to figure out how to express the embedded NULL (C escape \0) in spec-compliant way.
|
Perhaps it's clearer as 'the first 16-bytes shall be the zero terminated ASCII string ...' or add ' including the nul terminator character at the end' like the SQLite format spec does it. |
|
Zero terminated seems worse (because that could be ASCII 0x30). I can live with NUL terminated. |
|
In the 4/21 SWG we decided to say NULL terminated ASCII string. I'm just going to close this PR and fix it separately. Sorry for the delay. |
jyutzler
added a commit
to jyutzler/geopackage
that referenced
this pull request
May 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want it to be 16 bytes to match the way sqlite does it, you
need to figure out how to express the embedded NULL (C escape \0)
in spec-compliant way.