From 4f1bac8a49efe1885be1e6a5ae972baaf794888e Mon Sep 17 00:00:00 2001 From: Matthias Mohr Date: Mon, 5 Dec 2022 16:31:38 +0100 Subject: [PATCH 1/2] Require minimum length of 1 for primary_geometry #129 --- format-specs/geoparquet.md | 6 +++--- format-specs/schema.json | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/format-specs/geoparquet.md b/format-specs/geoparquet.md index 226901f..cf53feb 100644 --- a/format-specs/geoparquet.md +++ b/format-specs/geoparquet.md @@ -37,9 +37,9 @@ All file-level metadata should be included under the "geo" key in the parquet me | Field Name | Type | Description | | ------------------ | ------ | -------------------------------------------------------------------- | -| version | string | **REQUIRED** The version of the GeoParquet metadata standard used when writing. | -| primary_column | string | **REQUIRED** The name of the "primary" geometry column. | -| columns | object | **REQUIRED** Metadata about geometry columns, with each key is the name of a geometry column in the table. | +| version | string | **REQUIRED** The version of the GeoParquet metadata standard used when writing. | +| primary_column | string | **REQUIRED** The name of the "primary" geometry column with a minimum length of 1. | +| columns | object | **REQUIRED** Metadata about geometry columns. Each key is the name of a geometry column in the table. | At this level, additional implementation-specific fields (e.g. library name) are allowed, and thus readers should be robust in ignoring those. diff --git a/format-specs/schema.json b/format-specs/schema.json index 7474b82..8d3dcad 100644 --- a/format-specs/schema.json +++ b/format-specs/schema.json @@ -11,6 +11,7 @@ }, "primary_column": { "type": "string", + "minLength": 1, "description": "The name of the 'primary' geometry column." }, "columns": { From 5907910f3d61671ef566d0b343cbc85c6e190578 Mon Sep 17 00:00:00 2001 From: Chris Holmes Date: Mon, 5 Dec 2022 09:28:08 -0800 Subject: [PATCH 2/2] Update format-specs/geoparquet.md --- format-specs/geoparquet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/format-specs/geoparquet.md b/format-specs/geoparquet.md index cf53feb..f61215e 100644 --- a/format-specs/geoparquet.md +++ b/format-specs/geoparquet.md @@ -38,7 +38,7 @@ All file-level metadata should be included under the "geo" key in the parquet me | Field Name | Type | Description | | ------------------ | ------ | -------------------------------------------------------------------- | | version | string | **REQUIRED** The version of the GeoParquet metadata standard used when writing. | -| primary_column | string | **REQUIRED** The name of the "primary" geometry column with a minimum length of 1. | +| primary_column | string | **REQUIRED** The name of the "primary" geometry column. | | columns | object | **REQUIRED** Metadata about geometry columns. Each key is the name of a geometry column in the table. | At this level, additional implementation-specific fields (e.g. library name) are allowed, and thus readers should be robust in ignoring those.