Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allignments - Annex E #234

Merged
merged 19 commits into from Dec 1, 2021
Merged

Allignments - Annex E #234

merged 19 commits into from Dec 1, 2021

Conversation

nicholascar
Copy link
Collaborator

Closes Issue #74

@nicholascar nicholascar added this to the GeoSPARQL 1.1 milestone Nov 17, 2021
@nicholascar nicholascar self-assigned this Nov 17, 2021
@nicholascar nicholascar changed the title first set of allignments in Annex D Allignments in Annex D Nov 17, 2021
@nicholascar nicholascar changed the title Allignments in Annex D Allignments - Annex D Nov 17, 2021
@nicholascar nicholascar changed the title Allignments - Annex D Allignments - Annex E Nov 17, 2021
@situx
Copy link
Collaborator

situx commented Nov 17, 2021

I wonder if we should provide these alignments also in RDF? Would that not be reasonable?

@nicholascar
Copy link
Collaborator Author

I wonder if we should provide these alignments also in RDF?

If people are happy with them then yet we can, as a separate RDF file or perhaps one filer per alignment - for easy separate loading.

But we need to have a few reviews here so that the alignments are broadly thought to be correct. I will contact all the authors of the things aligned with for review.

1.1/spec/20-Annex-D.adoc Outdated Show resolved Hide resolved
1.1/spec/20-Annex-D.adoc Outdated Show resolved Hide resolved
1.1/spec/20-Annex-D.adoc Outdated Show resolved Hide resolved
1.1/spec/20-Annex-D.adoc Outdated Show resolved Hide resolved
1.1/spec/20-Annex-D.adoc Outdated Show resolved Hide resolved
1.1/spec/20-Annex-D.adoc Outdated Show resolved Hide resolved
| `geo:hasGeometry` | `rdfs:subPropertyOf` | `locn:geometry` | The LOCN property notes say "Depending on how a geometry is encoded, the range of this property may be one of..." so GeoSPARQL's proerty is learly more specialized.
| `locn:Address` | `rdfs:subClassOf` | `geo:Feature` | Although LOCN indicates no spatial or geometry properties for `locn:Address`, `locn:Address` is clearly some specialized form of a Feature
| `geo:Geometry` | `owl:equivalentClass` | `locn:Geometry` | The LOCN class "defines the notion of "geometry" at the conceptual level, and it shall be encoded by using different formats", so GeoSPARQL's class is equivalent.
| `geo:hasGeometry` | `owl:equivalent` | `locn:geometry` | The LOCN property notes say "Depending on how a geometry is encoded, the range of this property may be one of..." so GeoSPARQL's property is clearly more specialized.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owl:equivalentProperty

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adopted the first - geo:Geometry owl:equivalentClass locn:Geometry but not the second geo:hasGeometry owl:equivalent[Property] locn:geometry as I've chosen to keep using rdfs:subPropertyOf since GeoSPARQL's version of this property is clearly more specialized!

@nicholascar
Copy link
Collaborator Author

@dr-shorthair I've adopted all but one of your recommendations and that one's noted above (unresolved comment).

@situx can you please review?

@kjano if you would like to review, I would love you to!

This appendix renders nicely in GitHub at https://github.com/opengeospatial/ogc-geosparql/blob/alignments/1.1/spec/20-Annex-E.adoc

Copy link
Collaborator

@situx situx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mappings so far look ok to me and we could merge them. We should add the missing ones though

@nicholascar
Copy link
Collaborator Author

We should add the missing ones though

Which missing ones? Did we list the others we wanted somewhere, I forget. We can merge and then have a follow-up PR, unless you can remember the missing ones quickly.

@situx
Copy link
Collaborator

situx commented Dec 1, 2021

Yes, the others are at the end of this pull request in Annex E, Wikidata a.s.o. I will find some time to put them in later

@nicholascar
Copy link
Collaborator Author

That's right, they are in the Doc already, just incomplete. I knew I had seen them somewhere!

@nicholascar
Copy link
Collaborator Author

I've added quite a few Wikidata mappings

@situx
Copy link
Collaborator

situx commented Dec 1, 2021

Thanks, I think there are even more. I will dig them up later.

@mperry455 mperry455 self-requested a review December 1, 2021 21:12
Copy link
Collaborator

@jabhay jabhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think when we go to 1.2, we should separate this annex from the standard to allow it to be maintained outside of the standard revision process.

@mperry455
Copy link
Collaborator

Looks good to me.

@jabhay
Copy link
Collaborator

jabhay commented Dec 1, 2021

2 approvals, merging

@jabhay jabhay merged commit 924bf6a into master Dec 1, 2021
@jabhay jabhay deleted the alignments branch December 1, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants