Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbox.yaml constaints only work for CRS84 #60

Closed
rouault opened this issue Mar 5, 2018 · 3 comments · Fixed by #94
Closed

bbox.yaml constaints only work for CRS84 #60

rouault opened this issue Mar 5, 2018 · 3 comments · Fixed by #94
Assignees
Labels

Comments

@rouault
Copy link
Contributor

rouault commented Mar 5, 2018

https://raw.githubusercontent.com/opengeospatial/WFS_FES/master/core/openapi/parameters/bbox.yaml defines -180/180 as the min/max for bbox values. That won't work for default CRS that aren't geodetic ones.

@rouault rouault changed the title bbox.yaml constains only work for CRS84 bbox.yaml constaints only work for CRS84 Mar 5, 2018
@cportele
Copy link
Member

cportele commented Mar 6, 2018

It currently is like that since the only CRS supported by the Core is WGS84 lon/lat. But of course whatever we specify in the Core must be compatible with extensions that support other CRSs. If we want to make it work in general beyond WGS84 lon/lat we need to remove maxItems: 4 and the minimum/maximum - and clarify how to specify the CRS.

@cportele cportele self-assigned this Mar 8, 2018
@cportele cportele added the Part 1: Core Issue related to Part 1 - Core label Mar 8, 2018
@cportele cportele added this to the Part 1, First Draft Release milestone Mar 8, 2018
@ilkkarinne
Copy link
Contributor

+1 for generalizing the BBOX to support other CRSes that CRS84, but defaulting to CRS84. I would also like to see placeholder to giving the crs ID as an optional parameter, even if the Core services are not required to support it

@cportele
Copy link
Member

See pull request #94.

I removed the minimum/maximum values and changed maxItems to 6 to prepare for other CRSs. bbox-crs has been reserved for a parameter in the CRS extension to specify a different CRS for the BBOX values (I have made it a separate parameter so that bbox can still be an array of numbers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants