Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bbox/time parameter behavior for features without bbox/time data #122

Closed
wants to merge 1 commit into from

Conversation

JivanAmara
Copy link
Contributor

Likely resolution of #121.

Defines behavior of filters to match bbox/time queries if the feature doesn't have geometry/temporal data.

Copy link
Member

@cportele cportele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one proposal for changing the first addition. The rest looks fine.

@@ -58,6 +58,9 @@ in the response are determined by the server based on parameters of the request.

A `bbox` or `time` parameter may be used to select only a subset of the features in
the collection (the features that are located in the bounding box or time period).
If the collection does not contain bbox data it SHALL be considered to match all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement is more specific, if we talk about features, not data in general. My suggestion:

"The bbox parameter SHALL be considered to match all features in the collection that are not associated with a location. The time parameter SHALL be considered to match all features in the collection that are not associated with a time stamp or period. "

@cportele
Copy link
Member

cportele commented May 3, 2019

Edits transferred to #208. See 7a1e083.

@cportele cportele closed this May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants