Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rel:item to rel:items #175

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Change rel:item to rel:items #175

merged 2 commits into from
Feb 14, 2019

Conversation

cholmes
Copy link
Member

@cholmes cholmes commented Oct 12, 2018

The rel link here links to the /items endpoint, but has a 'rel' of 'items'. In STAC we extensively use rel=item to link to a specific item in our catalog. We are trying hard for WFS compatibility, and if this changes to 'items' instead of 'item' then we can be very compatible. We'd make use of rel=items to link to the wfs queryable endpoint, and rel=item to indicate a catalog link to a single item.

This was the only reference I found to this - not sure if it's even truly specified. It may be good to have some recommendations in or near the spec on the rel types that are used, and what they are used for.

@m-mohr
Copy link
Contributor

m-mohr commented Oct 15, 2018

Supporting this. It doesn't make any sense to call a list of items just item.

@cportele
Copy link
Member

Yes, we used item as it is a registered relation type, but the semantics are not clean as i is. item should only be used for links to a single item. I would be fine with using items for these links.

However, the change fixes only the example, not the following places:

  • requirement 13, /req/core/fc-md-items-links
  • the first paragraph of example 4
  • the examples in Annex C

Should I take care of them?

@cholmes
Copy link
Member Author

cholmes commented Oct 15, 2018

Great. Sorry for missing those other places, I tried to do a search for it but obviously came up short. Would be great if you could make those changes, my time is pretty limited these days.

@cportele cportele self-assigned this Oct 16, 2018
@cportele
Copy link
Member

OK, will do. It may take a while, but there is no rush. We will start editing the document again more actively in early 2019.

@cportele cportele merged commit a808933 into master Feb 14, 2019
@cportele
Copy link
Member

Merge PR since the outstanding edits have been added...

@cportele cportele deleted the items-rel-link branch February 14, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants