Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement display of hierarchies in new HTML report of TEAM Engine #319

Closed
dstenger opened this issue Mar 8, 2018 · 17 comments

Comments

Projects
None yet
3 participants
@dstenger
Copy link
Contributor

commented Mar 8, 2018

No description provided.

@dstenger dstenger added the enhancement label Mar 8, 2018

@lgoltz

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2018

Proposal for a first draft:

  • In the new HTML report (based on CTL) the test on the first level shows the result of the group but does not display the complete hierarchy. A reference to the detailed test report could be helpful.

@keshav-nangare Are changes or enhancements in the EARL report required to display hierarchies?

@dstenger

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2018

@keshav-nangare
Can you please check the steps required to display hierarchies?
Are all informations included in EARL report?
Do we just have to adjust the XSLT transformation?

@keshav-nangare

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2018

Steps to display hierarchies:

  1. Need to update the EARL document with the parent-child relation of the test.
  2. Update XSLT transformation to convert it to HTML.
  3. Need to think about how to represent the hierarchy of test in the HTML page.

@lgoltz lgoltz assigned lgoltz and unassigned keshav-nangare Mar 20, 2018

lgoltz added a commit that referenced this issue Mar 21, 2018

lgoltz added a commit that referenced this issue Mar 21, 2018

lgoltz added a commit that referenced this issue Mar 21, 2018

lgoltz added a commit that referenced this issue Mar 21, 2018

lgoltz added a commit that referenced this issue Mar 21, 2018

@lgoltz

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2018

  1. Need to update the EARL document with the parent-child relation of the test.

This is already done in branch https://github.com/opengeospatial/teamengine/tree/hierarchiesInNewHtmlReport-319.

Besides the enhancements to display hierarchies, the class CtlEarlReporter was formatted and refactored. Furthermore some bugs was fixed:

  • Include of http:Request as child of a TestResult (was child of the root element)
  • Output of the response (was empty)
  • Increasing of the number of passed tests (was 0 in each case)

lgoltz added a commit to lat-lon/teamengine that referenced this issue Mar 28, 2018

lgoltz added a commit to lat-lon/teamengine that referenced this issue Mar 28, 2018

lgoltz added a commit to lat-lon/teamengine that referenced this issue Mar 28, 2018

lgoltz added a commit to lat-lon/teamengine that referenced this issue Mar 28, 2018

@lgoltz

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2018

Added Unit Tests for CtlEarlReporter and fixed some more bugs.

@lgoltz

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2018

The xslt script transforming the EARL report to the new HTML report was adjusted to display the hierarchies (currently the test cases are indented on the main page, dependent on the level of the hierarchy depth).
UnitTest was added to test the transformation (therefore the code was moved from class TECore to a new class (EarlToHtmlTransformer).

As the generated EARL report seems to differ if the report is created multiple times from the same source there was missing test cases. This was fixed in 47028b6

Handling of inheritedFailures was added within cf53e2a. For a consistent working with the URLs provided by EARL and added with the CITE enhancements the URLs should be adjusted. Ticket #326 was created, the URL for the InheritedFailures was already adjusted in 149d827

@lgoltz

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2018

Simplified calculation of test (was counted by the TestCase/Assertions and did not work with test hierarchies):
f474069

@lgoltz

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2018

Fixed calculation of executed tests (included inherited tests): d53f4b4

@lgoltz

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2018

Implementation is finished so far. Currently tests without subtests (like data-preconditions in ETS WMS 1.3) contains no test results. How can we handle this?

The number of tests differs from the one in the old report as the first (main:main) and second (data-independent, data-preconditions, basic and queryable) levels tests are not included in the new html report. Furthermore inherited failures are not marked but counted as usually failures.

@dstenger

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2018

@keshav-nangare Can you please review the implementation and provide feedback if you identify any improvements?

@keshav-nangare

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2018

The changes are fine with me and the new HTML report with Hierarchies looking nice.

ERROR: The result is not showing in the testDetails page whether the test is passed or failed etc,

detailtestresult

lgoltz added a commit to lat-lon/teamengine that referenced this issue Apr 10, 2018

@lgoltz

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2018

ERROR: The result is not showing in the testDetails page whether the test is passed or failed etc,

Should be fixed with lat-lon@aef2fa6

@keshav-nangare Can you test again?

@keshav-nangare

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2018

@lgoltz

The issue fixed and showing the result in detail HTML page.

But, the current working branch is failing with Maven Unit test:testGenerateEarlReport

@lgoltz

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2018

But, the current working branch is failing with Maven Unit test:testGenerateEarlReport

Should be fixed with 8fefc6c

@lgoltz

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2018

@dstenger Please review notes in #319 (comment) and create new tickets, if required.

@dstenger

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2018

I reviewed notes in #319 (comment), created new tickets and added proposal for solution:

Pull request was created: #328

@keshav-nangare Can you please confirm if feature branch is working on your environment now?

@keshav-nangare

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2018

@dstenger

I have tested the feature branch and worked successfully with CTL and TestNG test-suites.

Tested Environment:

OS: Windows 8.1
JAVA: 1.8
ETS: gml32 1.26 and wms13 1.23-SNAPSHOT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.