New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash in feature list model #440

Merged
merged 2 commits into from Jan 23, 2019

Conversation

Projects
None yet
4 participants
@3nids
Copy link
Member

3nids commented Jan 17, 2019

fixes #432

I am not sure this is the correct fix (i.e. is there an issue hidden behind) but it does prevent the crash.
My wild guess is that with the project in the issue report (QGEP), rendering takes more time than the timer (100ms) so everything is not correctly set when the timer ends, but I didn't look further.

@m-kuhn thoughts?

@3nids 3nids requested a review from m-kuhn Jan 17, 2019

@@ -147,6 +147,9 @@ void FeatureListModel::processReloadLayer()
{
mEntries.clear();

if ( !mCurrentLayer )
return;

This comment has been minimized.

@3nids

3nids Jan 17, 2019

Author Member

my changes are actually here!

@qfield-fairy

This comment has been minimized.

Copy link
Collaborator

qfield-fairy commented Jan 17, 2019

Uploaded test apks for armv7 and x86

@m-kuhn

This comment has been minimized.

Copy link
Member

m-kuhn commented Jan 17, 2019

Yes, it's probably not the best fix, but I can't come up with a better one right now. It should probably be connected to a signal instead of the timer. Just a quick check: are there a lot of ValueRelations on this layer? They take a long time to load.

Maybe retrigger the timer in this case? If your suspicion is correct, that should make the behavior still work but slower.

@schoeller

This comment has been minimized.

Copy link

schoeller commented Jan 18, 2019

I have downloaded and installed the apk from #440 (comment). When opening the dataset from #432 (comment) on the Android 8.1 device I cannot register any more crashes. Thanks

@3nids

This comment has been minimized.

Copy link
Member Author

3nids commented Jan 21, 2019

@m-kuhn and @schoeller thanks for the feedback

@m-kuhn no every thing is ready at that time.

@schoeller The issue is that the given project has invalid relations (i.e. missing layers).

I will provide a better fix asap

do not show widget for invalid relation
display warning instead

@3nids 3nids force-pushed the fix432 branch from efc97dc to 040d9ff Jan 22, 2019

@3nids

This comment has been minimized.

Copy link
Member Author

3nids commented Jan 22, 2019

here we go
screenshot 2019-01-21 at 20 55 35

@3nids 3nids merged commit 82fecfb into master Jan 23, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@3nids 3nids deleted the fix432 branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment