New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ways to deduce qgs file #453

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@marioba
Copy link
Contributor

marioba commented Jan 25, 2019

Improves the file selector by adding more possibilities to deduce the correct path of the qgs project.

References #390

Add ways to deduce qgs file
Improves the file selector by adding more possibilities to deduce the correct path of the qgs project.

@marioba marioba requested review from m-kuhn and 3nids Jan 25, 2019

@m-kuhn

m-kuhn approved these changes Jan 27, 2019

Copy link
Member

m-kuhn left a comment

Looks good to me.
It's hard to do more than a very basic review.
Are there any issues this is supposed to fix?

@marioba

This comment has been minimized.

Copy link
Contributor Author

marioba commented Jan 28, 2019

@m-kuhn This change possibly fixes issue #390 but I can't say for sure because I can't reproduce the problem.
However, it does not imply any change for those who already were able to open the projects correctly.

@m-kuhn

This comment has been minimized.

Copy link
Member

m-kuhn commented Jan 28, 2019

Let's see then.
Can you add a "References #390" to the commit message?

@m-kuhn m-kuhn closed this Jan 29, 2019

@m-kuhn m-kuhn reopened this Jan 29, 2019

@qfield-fairy

This comment has been minimized.

Copy link
Collaborator

qfield-fairy commented Jan 29, 2019

Uploaded test apks for armv7 and x86

@m-kuhn m-kuhn merged commit 029be84 into master Jan 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@m-kuhn m-kuhn deleted the better_file_selector branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment