Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear value in date/time if invalid when losing focus #464

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
3 participants
@3nids
Copy link
Member

3nids commented Jan 30, 2019

@saemiw this should fix the issue of leaving an invalid date/time after the widget loses focus.
Works for you?

@qfield-fairy

This comment has been minimized.

Copy link
Collaborator

qfield-fairy commented Jan 30, 2019

Uploaded test apks for armv7 and x86

@saemiw

This comment has been minimized.

Copy link

saemiw commented Jan 31, 2019

@3nids Yes that works.

If it is easy to change it would however be better to change it the following:
Currently the non-sense time is removed as soon as you tap into the next attribute field (which is an improvement). If the time is however your last field you enter, you won't notice that non-sense entries will be removed.
So it would be better to remove the non-sense entry directly after pushing the o.k. button (circled in blue in the pic below). Like this you would immediately notice that QField is not accepting the non-sense entry.

screenshot_20190131-095654_qfield

@3nids

This comment has been minimized.

Copy link
Member Author

3nids commented Mar 5, 2019

it's a bit more complicated to handle this, I will try.
Merging it now to get it in RC4.

@3nids 3nids merged commit e12c290 into master Mar 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@3nids 3nids deleted the handle_invalid_date_focus branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.