Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite directories in file selector #507

Merged
merged 5 commits into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@marioba
Copy link
Contributor

marioba commented Mar 7, 2019

Add a section in file selection first activity with the favorite directories.
To add a directory to the favorites, do a long click on the directory.
To remove a directory from the favorites do a long click on the entry in the favorites section.

marioba added some commits Mar 7, 2019

Implement favorite directories
long click on a directory add it to the favorites
Implement favorite directories
long click on a directory add it to the favorites
@qfield-fairy

This comment has been minimized.

Copy link
Collaborator

qfield-fairy commented Mar 7, 2019

Uploaded test apks for armv7 and x86

@qfield-fairy

This comment has been minimized.

Copy link
Collaborator

qfield-fairy commented Mar 7, 2019

Uploaded test apks for armv7 and x86

@mbernasocchi mbernasocchi self-requested a review Mar 7, 2019

@mbernasocchi
Copy link
Member

mbernasocchi left a comment

great work.

@@ -2,7 +2,7 @@
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent" android:layout_height="match_parent">

<ListView android:id="@android:id/list" android:layout_width="match_parent"
<ListView android:id="@+id/list" android:layout_width="match_parent"

This comment has been minimized.

@mbernasocchi

mbernasocchi Mar 7, 2019

Member

just out of curiosity, what is the +?

This comment has been minimized.

@marioba

marioba Mar 7, 2019

Author Contributor

+id tells android to add a new id in the resources so you can call it from java with R.

@marioba marioba merged commit 69d7b85 into master Mar 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the favorites branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.