Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate popup #510

Merged
merged 14 commits into from Mar 12, 2019

Conversation

Projects
None yet
3 participants
@marioba
Copy link
Contributor

marioba commented Mar 11, 2019

Add "Rate this app" dialog that appears after at least 30 days and 10 openings of the app.

To test this pull request you can overwrite the following parameters:

  • LauchCount: long, number of launches of the app
  • FirstLauch: long, unix time in seconds of the first launch of the app
  • DontShowAgain: boolean, if true, the popup is never displayed

to pass the parameters to the app launch it using adb shelllike this:

adb shell am start -n ch.opengis.qfield/.QFieldActivity --el LaunchCount 10 --el FirstLaunch 1546300800 --ez DontShowAgain false

@marioba marioba marked this pull request as ready for review Mar 11, 2019

@qfield-fairy

This comment has been minimized.

Copy link
Collaborator

qfield-fairy commented Mar 11, 2019

Uploaded test apks for armv7 and x86

marioba added some commits Mar 11, 2019

@qfield-fairy

This comment has been minimized.

Copy link
Collaborator

qfield-fairy commented Mar 11, 2019

Uploaded test apks for armv7 and x86

@qfield-fairy

This comment has been minimized.

Copy link
Collaborator

qfield-fairy commented Mar 11, 2019

Uploaded test apks for armv7 and x86

@qfield-fairy

This comment has been minimized.

Copy link
Collaborator

qfield-fairy commented Mar 11, 2019

Uploaded test apks for armv7 and x86

@qfield-fairy

This comment has been minimized.

Copy link
Collaborator

qfield-fairy commented Mar 11, 2019

Uploaded test apks for armv7 and x86

@mbernasocchi

This comment has been minimized.

Copy link
Member

mbernasocchi commented Mar 11, 2019

@marioba I'm happy with it now, for me you can merge

@marioba marioba merged commit 45ce036 into master Mar 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the rate_popup branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.