Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v6.89.0 #6898

Merged
merged 13 commits into from
Nov 16, 2023
Merged

build: release v6.89.0 #6898

merged 13 commits into from
Nov 16, 2023

Conversation

wanlingt
Copy link
Contributor

@wanlingt wanlingt commented Nov 15, 2023 •
edited by tshuli
Loading

New

  • fix: add learn more link #6897
  • chore: security upgrade axios to 1.6.2 #6893
  • feat: myinfo for storage-mode #6870
  • feat: announcement modal and what's new for myinfo storage-mode #6892
  • chore: remove eb shift frontend feature flags #6869
  • build: merge release 6.88.0 into develop #6882
  • build: release v6.88.0 #6881
  • chore: bump version to v6.89.0 e511d27

Dependencies

  • chore(deps): bump axios from 1.2.1 to 1.6.0 in /frontend #6887
  • fix(deps): bump axios from 1.2.1 to 1.6.0 #6886
  • fix(deps): bump type-fest from 4.5.0 to 4.7.1 in /shared #6883

Dev-Dependencies

  • chore(deps-dev): bump @types/lodash from 4.14.200 to 4.14.201 in /shared #6888

Tests

feat: myinfo for storage-mode #6870

@KenLSM

  1. Submit normal storage mode form, without MyInfo fields (regression)
  • Create a normal storage mode form with no authentication
  • You should be able to submit the form successfully

Singpass MyInfo
@tshuli
2a. Submit storage mode form with Singpass MyInfo fields

  • Create a normal storage mode form with Singpass MyInfo as the authentication type
  • Add at least the following MyInfo fields: Name, DOB, Nationality, Vehicle Number, Child
  • Add an attachment field
  • Add a payment field
  • Set up a webhook receiver and update the URL in the form's settings
  • You should be able to submit the form successfully (use any of these mock profiles)
  • Navigate to the responses page, check that the response shows up
  • Click into the response. All the results should be there
  • Download the responses as a CSV. All the results should be there
  • The form responses should be sent via webhook and decrypted successfully
    • Note: the field id for child field is _id: 'childrenbirthrecords.6554b51337f5890012d65f8a.childname.0.Tan Wen Jie',

2b. Duplicate email mode form as storage mode using the duplicate button

  • Create an email mode form set to Singpass MyInfo as the authentication type
  • Duplicate the form, this time as a storage mode form
  • Navigate to the form's settings page. The authentication type should be set to Singpass MyInfo instead of NIL

2c. Duplicate email mode form as storage mode using the use-template link

  • Create an email mode form set to Singpass MyInfo as the authentication type
  • Duplicate the form by using the use-template link, this time as a storage mode form
  • Navigate to the form's settings page. The authentication type should be set to Singpass MyInfo instead of NIL

SGID MyInfo
@justynoh
3a. Submit storage mode form with SGID MyInfo fields

  • Create a normal storage mode form with SGID MyInfo as the authentication type
  • Add at least the following MyInfo fields: Name, DOB, Nationality, Vehicle Number
  • Add an attachment field
  • Add a payment field
  • Set up a webhook receiver and update the URL in the form's settings
  • You should be able to submit the form successfully
  • Navigate to the responses page, check that the response shows up
  • Click into the response. All the results should be there
  • Download the responses as a CSV. All the results should be there
  • The form responses should be sent via webhook and decrypted successfully

3b. Duplicate email mode form as storage mode

  • Create an email mode form set to SGID MyInfo as the authentication type
  • Duplicate the form, this time as a storage mode form
  • Navigate to the form's settings page. The authentication type should be set to SGID MyInfo instead of NIL

3c. Duplicate email mode form as storage mode using the use-template link

  • Create an email mode form set to SGID MyInfo as the authentication type
  • Duplicate the form by using the use-template link, this time as a storage mode form
  • Navigate to the form's settings page. The authentication type should be set to SGID MyInfo instead of NIL

chore: remove eb shift frontend feature flags #6869

@wanlingt

  • Create storage mode form. Open in public form view.
  • Submission with attachment works
  • Attachment is uploaded to s3
  • Malicious attachment is blocked
    secure.eicar.org_eicar.com.txt

wanlingt and others added 11 commits November 9, 2023 15:10
@wanlingt
Merge pull request #6882 from opengovsg/release-al2
ae2ee77 
build: merge release 6.88.0 into develop
@dependabot
fix(deps): bump type-fest from 4.5.0 to 4.7.1 in /shared (#6883)
c6dadff 
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.5.0 to 4.7.1.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.5.0...v4.7.1)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump axios from 1.2.1 to 1.6.0 (#6886)
2b813a4 
Bumps [axios](https://github.com/axios/axios) from 1.2.1 to 1.6.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.2.1...v1.6.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump axios from 1.2.1 to 1.6.0 in /frontend (#6887)
61318c3 
Bumps [axios](https://github.com/axios/axios) from 1.2.1 to 1.6.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.2.1...v1.6.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/lodash from 4.14.200 to 4.14.201 in /sha…
7baacef 
…red (#6888)

Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.200 to 4.14.201.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash)

---
updated-dependencies:
- dependency-name: "@types/lodash"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tshuli
chore: remove eb shift frontend feature flags (#6869)
d5bbb4d 
* chore: remove virus scanner feature flag

* chore: remove enable encryption boundary shift feature flag

* chore: remove growthbook in public form provider

* chore: remove unused storage submission modes

* chore: fetch fallback should also use virus scanning

* chore: update mutation

* chore: move fallback to catch block

* chore: add back network error check

* chore: remove unused import and const

* chore: remove clear word
@wanlingt
feat: announcement modal and what's new for myinfo storage-mode (#6892)
432ebdf 
* feat: add myinfo storage mode announcement

* feat: add graphic and amend copy

* fix: update copy
@wanlingt
feat: myinfo for storage-mode (#6870)
3e8b06a 
* feat: allow myinfo field to be added to storage-mode form

* feat: remove FormAuthType.MyInfo check from submitEncryptModeForm

* fix: add MyInfo case for authType validator

* fix: use set instead of validator for form.server.model

* feat: validate myinfo response in backend

* fix: clean up imports and comments

* fix: refine error

* test: remove MyInfo test

* test: add myinfo e2e test

* feat: add sgid myinfo

* ref: refactor authtypes

* fix: remove console.log

* feat: allow storage mode in myinfo form duplication

* ref: remove unused declaration

* feat: process each child subfield as a new field

* feat: rename session cookie to formsg.connect.sid in local dev

* feat: remove containsMyInfoFields from create and dupe form wizards

* ref: use common FORM_AUTHTYPES for email and storage mode forms

* fix: use triple = for authType check

* feat: remove check for authType in validation

* test: add MyInfo and SGID MyInfo test cases

* fix: use ADMIN_LOGIN_SESSION_COOKIE_NAME constant for tests

* ref: extract common functions getMyInfoPrefix and getAnswersForChild to shared submission.utils

* fix: error handling in validateStorageSubmission

* fix: clean up constants and unused imports
@justynoh
chore: security upgrade axios to 1.6.2 (#6893)
ded4926 
chore: upgrade axios to 1.6.0
@wanlingt
fix: add learn more link (#6897)
9d426d4
@wanlingt
chore: bump version to v6.89.0
1665a48
@justynoh
Copy link
Contributor

why does the infobox on the left panel still say "Only 30 MyInfo fields are allowed in Email mode" when the form is now on Storage mode haha
image

@wanlingt
Copy link
Contributor Author

wanlingt commented Nov 15, 2023 •
edited
Loading

why does the infobox on the left panel still say "Only 30 MyInfo fields are allowed in Email mode" when the form is now on Storage mode haha image

thanks for spotting this!! I'll push a fix directly to this branch

edit: 5a45c98

@wanlingt
fix: remove myinfo child from storage mode (#6901)
8f753e6 
* fix: remove myinfo child from storage mode

* fix: re-add the formatting
@wanlingt wanlingt merged commit 6ee4b2d into release-al2 Nov 16, 2023
20 of 22 checks passed
@wanlingt wanlingt deleted the release_v6.89.0 branch November 16, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshuli tshuli tshuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wanlingt @justynoh @tshuli