Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught error if from address is not verified for transactional email endpoint #1837

Closed
lamkeewei opened this issue Oct 10, 2022 · 1 comment · Fixed by #1920
Closed

Uncaught error if from address is not verified for transactional email endpoint #1837

lamkeewei opened this issue Oct 10, 2022 · 1 comment · Fixed by #1920
Labels
bug Something isn't working

Comments

@lamkeewei
Copy link
Contributor

image
@lamkeewei lamkeewei added the bug Something isn't working label Oct 10, 2022
@zxt-tzx
Copy link
Contributor

zxt-tzx commented Oct 13, 2022

We actually noticed and discussed this earlier (see here) and @stanleynguyen is in the process of building out an endpoint for verifying from address (see here)

Actually, I was typing this, I realize a simple way would be to check out email_from_address table (rather than actually run the check with AWS SES 🤔)

@zxt-tzx zxt-tzx mentioned this issue Oct 26, 2022
Merged
@zxt-tzx zxt-tzx mentioned this issue Jan 17, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: better error message for unverified custom from address opengovsg/postmangovsg
2 participants
@lamkeewei @zxt-tzx