From fe91fb635a3e36c60e50948af9e2dfd02bc7c43b Mon Sep 17 00:00:00 2001 From: pali Date: Thu, 15 Jul 2021 20:49:59 +0300 Subject: [PATCH] [ihc] Improved command handling when controller is not ready (#10895) * [ihc] Improved command handling when controller is not ready When connection from binding to IHC controller is open, but controller is in programming state, things state is offline with special status to indicate that binding can't send or receive any resource updates at the moment. Things status check during command sending will prevent unnecessary resource updates which will eventually fail and binding then tries to restart the connection. Signed-off-by: Pauli Anttila --- .../openhab/binding/ihc/internal/handler/IhcHandler.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/bundles/org.openhab.binding.ihc/src/main/java/org/openhab/binding/ihc/internal/handler/IhcHandler.java b/bundles/org.openhab.binding.ihc/src/main/java/org/openhab/binding/ihc/internal/handler/IhcHandler.java index 9c7d36ea1e30..8590338583c2 100644 --- a/bundles/org.openhab.binding.ihc/src/main/java/org/openhab/binding/ihc/internal/handler/IhcHandler.java +++ b/bundles/org.openhab.binding.ihc/src/main/java/org/openhab/binding/ihc/internal/handler/IhcHandler.java @@ -202,16 +202,21 @@ public void handleCommand(ChannelUID channelUID, Command command) { logger.debug("Received channel: {}, command: {}", channelUID, command); if (ihc == null) { - logger.warn("Connection is not initialized, abort resource value update for channel '{}'!", channelUID); + logger.debug("Connection is not initialized, aborting resource value update for channel '{}'!", channelUID); return; } if (ihc.getConnectionState() != ConnectionState.CONNECTED) { - logger.warn("Connection to controller is not open, abort resource value update for channel '{}'!", + logger.debug("Connection to controller is not open, aborting resource value update for channel '{}'!", channelUID); return; } + if (thing.getStatus() != ThingStatus.ONLINE) { + logger.debug("Controller is not ONLINE, aborting resource value update for channel '{}'!", channelUID); + return; + } + switch (channelUID.getId()) { case CHANNEL_CONTROLLER_STATE: if (command.equals(RefreshType.REFRESH)) {