From 5f83b6ffc898414e95061367a19721517ae52de4 Mon Sep 17 00:00:00 2001 From: Matt Myers Date: Sun, 30 May 2021 17:28:29 -0400 Subject: [PATCH 1/4] Update unit formating Signed-off-by: Matt Myers --- .../src/main/feature/feature.xml | 2 +- .../internal/handler/HaywardBackyardHandler.java | 2 +- .../internal/handler/HaywardBridgeHandler.java | 4 ++-- .../internal/handler/HaywardChlorinatorHandler.java | 4 ++-- .../internal/handler/HaywardColorLogicHandler.java | 2 +- .../internal/handler/HaywardFilterHandler.java | 2 +- .../internal/handler/HaywardRelayHandler.java | 2 +- .../internal/handler/HaywardVirtualHeaterHandler.java | 2 +- .../src/main/resources/OH-INF/thing/backyard.xml | 2 +- .../src/main/resources/OH-INF/thing/bow.xml | 2 +- .../src/main/resources/OH-INF/thing/chlorinator.xml | 8 ++++---- .../src/main/resources/OH-INF/thing/colorlogic.xml | 4 ++-- .../src/main/resources/OH-INF/thing/filter.xml | 4 ++-- .../src/main/resources/OH-INF/thing/virtualHeater.xml | 2 +- 14 files changed, 21 insertions(+), 21 deletions(-) diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/feature/feature.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/feature/feature.xml index 463c80c134f0..303874a46b54 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/feature/feature.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/feature/feature.xml @@ -2,7 +2,7 @@ mvn:org.openhab.core.features.karaf/org.openhab.core.features.karaf.openhab-core/${ohc.version}/xml/features - + openhab-runtime-base mvn:org.openhab.addons.bundles/org.openhab.binding.haywardomnilogic/${project.version} diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardBackyardHandler.java b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardBackyardHandler.java index 0419770ea47b..20d6c305ff10 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardBackyardHandler.java +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardBackyardHandler.java @@ -101,7 +101,7 @@ public boolean getAlarmList(String systemID) throws HaywardException { .evaluateXPath("/Response/Parameters//Parameter[@name='Status']/text()", xmlResponse) .get(0); - if (!(status.equals("0"))) { + if (!("0".equals(status))) { logger.trace("Hayward getAlarm XML response: {}", xmlResponse); return false; } diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardBridgeHandler.java b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardBridgeHandler.java index 8e3d1d9919ad..13792f3e9892 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardBridgeHandler.java +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardBridgeHandler.java @@ -186,7 +186,7 @@ public synchronized boolean login() throws HaywardException, InterruptedExceptio status = evaluateXPath("/Response/Parameters//Parameter[@name='Status']/text()", xmlResponse).get(0); - if (!(status.equals("0"))) { + if (!("0".equals(status))) { logger.debug("Hayward Connection thing: Login XML response: {}", xmlResponse); return false; } @@ -234,7 +234,7 @@ public synchronized boolean getSiteList() throws HaywardException, InterruptedEx status = evaluateXPath("/Response/Parameters//Parameter[@name='Status']/text()", xmlResponse).get(0); - if (!(status.equals("0"))) { + if (!("0".equals(status))) { logger.debug("Hayward Connection thing: getSiteList XML response: {}", xmlResponse); return false; } diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardChlorinatorHandler.java b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardChlorinatorHandler.java index 0d1e12f7aa32..8743f1072833 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardChlorinatorHandler.java +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardChlorinatorHandler.java @@ -128,7 +128,7 @@ public void handleCommand(ChannelUID channelUID, Command command) { try { switch (channelUID.getId()) { case HaywardBindingConstants.CHANNEL_CHLORINATOR_ENABLE: - if (cmdString.equals("1")) { + if ("1".equals(cmdString)) { chlorCfgState = "3"; chlorTimedPercent = this.chlorTimedPercent; } else { @@ -168,7 +168,7 @@ public void handleCommand(ChannelUID channelUID, Command command) { String status = bridgehandler.evaluateXPath("//Parameter[@name='Status']/text()", xmlResponse) .get(0); - if (!(status.equals("0"))) { + if (!("0".equals(status))) { logger.debug("haywardCommand XML response: {}", xmlResponse); return; } diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardColorLogicHandler.java b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardColorLogicHandler.java index bb42b06eb97c..ed98a1be63fa 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardColorLogicHandler.java +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardColorLogicHandler.java @@ -135,7 +135,7 @@ public void handleCommand(ChannelUID channelUID, Command command) { String status = bridgehandler.evaluateXPath("//Parameter[@name='Status']/text()", xmlResponse) .get(0); - if (!(status.equals("0"))) { + if (!("0".equals(status))) { logger.debug("haywardCommand XML response: {}", xmlResponse); return; } diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardFilterHandler.java b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardFilterHandler.java index b39740cd8d38..edf7a96d33b0 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardFilterHandler.java +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardFilterHandler.java @@ -140,7 +140,7 @@ public void handleCommand(ChannelUID channelUID, Command command) { String status = bridgehandler.evaluateXPath("//Parameter[@name='Status']/text()", xmlResponse) .get(0); - if (!(status.equals("0"))) { + if (!("0".equals(status))) { logger.debug("haywardCommand XML response: {}", xmlResponse); return; } diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardRelayHandler.java b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardRelayHandler.java index f890cd8e708c..c002d5acc12b 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardRelayHandler.java +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardRelayHandler.java @@ -104,7 +104,7 @@ public void handleCommand(ChannelUID channelUID, Command command) { String status = bridgehandler.evaluateXPath("//Parameter[@name='Status']/text()", xmlResponse) .get(0); - if (!(status.equals("0"))) { + if (!("0".equals(status))) { logger.debug("haywardCommand XML response: {}", xmlResponse); return; } diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardVirtualHeaterHandler.java b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardVirtualHeaterHandler.java index 6ee8246a8562..b06a7e96b290 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardVirtualHeaterHandler.java +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardVirtualHeaterHandler.java @@ -131,7 +131,7 @@ public void handleCommand(ChannelUID channelUID, Command command) { String status = bridgehandler.evaluateXPath("//Parameter[@name='Status']/text()", xmlResponse) .get(0); - if (!(status.equals("0"))) { + if (!("0".equals(status))) { logger.debug("haywardCommand XML response: {}", xmlResponse); return; } diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/backyard.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/backyard.xml index c947bc307763..13f50a2a2de2 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/backyard.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/backyard.xml @@ -33,7 +33,7 @@ Number:Temperature Air Temp - + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/bow.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/bow.xml index aa594741bb4c..d8a59193b192 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/bow.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/bow.xml @@ -34,7 +34,7 @@ Number:Temperature Water Temp - + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml index 4b77e92ca29a..650f4c32317c 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml @@ -47,7 +47,7 @@ Number:Dimensionless Current salt output setting for the chlorinator (%). - + @@ -84,20 +84,20 @@ Number:Dimensionless Average Salt Level - + Number:Dimensionless Instant Salt Level - + Number Status - + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/colorlogic.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/colorlogic.xml index 25d882eb2445..a8c92b3f964b 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/colorlogic.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/colorlogic.xml @@ -30,8 +30,8 @@ Light State - - + + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/filter.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/filter.xml index 00529184bb7f..98e04fbb2f22 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/filter.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/filter.xml @@ -48,7 +48,7 @@ Number:Dimensionless Filter Speed in % - + @@ -77,7 +77,7 @@ Number:Dimensionless Last Speed - + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/virtualHeater.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/virtualHeater.xml index 89d7d410c17e..6464c9a4c062 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/virtualHeater.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/virtualHeater.xml @@ -28,7 +28,7 @@ Current Setpoint Temperature - + From 843de4fd8e4140c6773700848ac543337ef7a818 Mon Sep 17 00:00:00 2001 From: Matt Myers Date: Mon, 7 Jun 2021 16:18:08 -0400 Subject: [PATCH 2/4] Updates per last review Signed-off-by: Matt Myers --- .../src/main/feature/feature.xml | 2 +- .../src/main/resources/OH-INF/thing/backyard.xml | 2 +- .../src/main/resources/OH-INF/thing/bow.xml | 2 +- .../src/main/resources/OH-INF/thing/chlorinator.xml | 6 +++--- .../src/main/resources/OH-INF/thing/colorlogic.xml | 4 ++-- .../src/main/resources/OH-INF/thing/filter.xml | 4 ++-- .../src/main/resources/OH-INF/thing/virtualHeater.xml | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/feature/feature.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/feature/feature.xml index 303874a46b54..463c80c134f0 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/feature/feature.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/feature/feature.xml @@ -2,7 +2,7 @@ mvn:org.openhab.core.features.karaf/org.openhab.core.features.karaf.openhab-core/${ohc.version}/xml/features - + openhab-runtime-base mvn:org.openhab.addons.bundles/org.openhab.binding.haywardomnilogic/${project.version} diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/backyard.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/backyard.xml index 13f50a2a2de2..33693e2f138b 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/backyard.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/backyard.xml @@ -33,7 +33,7 @@ Number:Temperature Air Temp - + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/bow.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/bow.xml index d8a59193b192..5c1b61b3f01b 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/bow.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/bow.xml @@ -34,7 +34,7 @@ Number:Temperature Water Temp - + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml index 650f4c32317c..3c3135c51148 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml @@ -47,7 +47,7 @@ Number:Dimensionless Current salt output setting for the chlorinator (%). - + @@ -84,14 +84,14 @@ Number:Dimensionless Average Salt Level - + Number:Dimensionless Instant Salt Level - + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/colorlogic.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/colorlogic.xml index a8c92b3f964b..25d882eb2445 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/colorlogic.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/colorlogic.xml @@ -30,8 +30,8 @@ Light State - - + + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/filter.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/filter.xml index 98e04fbb2f22..f29f3d63c008 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/filter.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/filter.xml @@ -48,7 +48,7 @@ Number:Dimensionless Filter Speed in % - + @@ -77,7 +77,7 @@ Number:Dimensionless Last Speed - + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/virtualHeater.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/virtualHeater.xml index 6464c9a4c062..ebbcb68bc6d3 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/virtualHeater.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/virtualHeater.xml @@ -28,7 +28,7 @@ Current Setpoint Temperature - + From 83bc37e0b547d66ec9bb511c169980da3067b082 Mon Sep 17 00:00:00 2001 From: Matt Myers Date: Sat, 12 Jun 2021 10:27:28 -0400 Subject: [PATCH 3/4] Updated units to decimal Signed-off-by: Matt Myers --- .../src/main/resources/OH-INF/thing/backyard.xml | 2 +- .../src/main/resources/OH-INF/thing/bow.xml | 2 +- .../src/main/resources/OH-INF/thing/chlorinator.xml | 8 ++++---- .../src/main/resources/OH-INF/thing/filter.xml | 4 ++-- .../src/main/resources/OH-INF/thing/pump.xml | 2 +- .../src/main/resources/OH-INF/thing/virtualHeater.xml | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/backyard.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/backyard.xml index 33693e2f138b..16983ad5157a 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/backyard.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/backyard.xml @@ -33,7 +33,7 @@ Number:Temperature Air Temp - + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/bow.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/bow.xml index 5c1b61b3f01b..ca07c5cf92b3 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/bow.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/bow.xml @@ -34,7 +34,7 @@ Number:Temperature Water Temp - + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml index 3c3135c51148..a0e6bd8849ad 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/chlorinator.xml @@ -47,7 +47,7 @@ Number:Dimensionless Current salt output setting for the chlorinator (%). - + @@ -84,20 +84,20 @@ Number:Dimensionless Average Salt Level - + Number:Dimensionless Instant Salt Level - + Number Status - + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/filter.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/filter.xml index f29f3d63c008..886904432da7 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/filter.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/filter.xml @@ -48,7 +48,7 @@ Number:Dimensionless Filter Speed in % - + @@ -77,7 +77,7 @@ Number:Dimensionless Last Speed - + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/pump.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/pump.xml index 16f1a094b6e2..d9e43f45e446 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/pump.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/pump.xml @@ -31,7 +31,7 @@ Number:Dimensionless Pump Speed - + diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/virtualHeater.xml b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/virtualHeater.xml index ebbcb68bc6d3..65c502e39d87 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/virtualHeater.xml +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/resources/OH-INF/thing/virtualHeater.xml @@ -28,7 +28,7 @@ Current Setpoint Temperature - + From c60b53dd0ed324efa1b7442347ad22b29910fb0f Mon Sep 17 00:00:00 2001 From: Matt Myers Date: Mon, 19 Jul 2021 15:06:09 -0400 Subject: [PATCH 4/4] Removed erroneous chlorinator code from filterhandler Signed-off-by: Matt Myers --- .../internal/handler/HaywardFilterHandler.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardFilterHandler.java b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardFilterHandler.java index edf7a96d33b0..4c0dc646381e 100644 --- a/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardFilterHandler.java +++ b/bundles/org.openhab.binding.haywardomnilogic/src/main/java/org/openhab/binding/haywardomnilogic/internal/handler/HaywardFilterHandler.java @@ -61,10 +61,6 @@ public void getTelemetry(String xmlResponse) throws HaywardException { String thingSystemID = getThing().getUID().getId(); for (int i = 0; i < systemIDs.size(); i++) { if (systemIDs.get(i).equals(thingSystemID)) { - // Operating Mode - data = bridgehandler.evaluateXPath("//Chlorinator/@operatingMode", xmlResponse); - updateData(HaywardBindingConstants.CHANNEL_CHLORINATOR_OPERATINGMODE, data.get(i)); - // Valve Position data = bridgehandler.evaluateXPath("//Filter/@valvePosition", xmlResponse); updateData(HaywardBindingConstants.CHANNEL_FILTER_VALVEPOSITION, data.get(i));