[tradfri] Add support for Air Purifier #14836

vivienbo · 2023-04-17T02:02:29Z

Description

This PR adds support for Tradfri Air Purifier (Strakvind) into the tradfri binding.
It supports:

changing fan mode, controlling LED and locking physical button.
reading current fan speed, PM2.5 ppm reading, filter uptime, time remaining before next filer check, air quality reading (aligned with Tradfri app) and a Switch to signal when filter needs to be reviewed.

Note: you will still need to run the filter review process through the Tradfri Mobile App.

Testing

Tested on OpenHAB 4.0.0-M1 and on 3.4.4.

Changelog

General matter:

Added documentation disambiguation Tradfri vs Dirigera
Tradfri Air Purifier features:
Added Tradfri Air Purifier - fanMode and fanSpeed
Workable Tradfri Air Purifier basic implementation
Tradfri: modified fanMode type and definition
Tradfri Air Purifier: Added disableLed
Tradfri Air Purifier: Added lockPhysicalButton
Tradfri Air Purifier: Added airQuality data
Tradfri Air Purifier: Added filterCheck data
Tradfri Air Purifier: Added translations
Tradfri Air Purifier: Added filter_uptime
Tradfri Air Purifier: code optimization
Documentation for supported Air Purifier channels

Related issues:

[tradfri] Add Support for Air Purifier #14816

Added Support for Tradfri Air Purifier: * Added documentation disambiguation Tradfri vs Dirigera * Added Tradfri Air Purifier - fanMode and fanSpeed * Workable Tradfri Air Purifier basic implementation * Tradfri: modified fanMode type and definition * Tradfri Air Purifier: Added disableLed * Tradfri Air Purifier: Added lockPhysicalButton * Tradfri Air Purifier: Added airQuality data * Tradfri Air Purifier: Added filterCheck data * Tradfri Air Purifier: Added translations * Tradfri Air Purifier: Added filter_uptime * Tradfri Air Purifier: code optimization * Documentation for supported Air Purifier channels Fixes openhab#14816 Signed-off-by: Vivien Boistuaud <github@boistuaud.net>

openhab-bot · 2023-04-17T02:03:13Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/tradfri-binding-support-for-air-purifiers/146119/1

* [tradfri] Updated README: * Reverts unnecessary formatting changes * Fixes centering of capabilities for non-lightning devices list * Removes 0202, 0203 and position from lightning devices list Signed-off-by: Vivien Boistuaud <github@boistuaud.net>

vivienbo · 2023-04-19T20:54:04Z

Made some updates to the README to fix some formatting and content-splitting issues (8f17e0c)

* Fixes Alphabetical order of properties * Fixes a typo in some names Signed-off-by: Vivien Boistuaud <github@boistuaud.net>

vivienbo · 2023-04-21T01:13:16Z

Proactive fixes in 7f4accf:

Fixes Alphabetical order of properties
Fixes a typo in some names

Note: Additions of the ^M endings in tradfri.properties is coming from execution of mvn i18n:generate-default-translations and probably this command hasn't been run on this file since it was added hence the increased number of changes

jlaur

Thanks for your contribution! The code looks good, only a few minor comments.

bundles/org.openhab.binding.tradfri/README.md

bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/i18n/tradfri_de.properties

bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/i18n/tradfri_fi.properties

bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/i18n/tradfri_fr.properties

bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/i18n/tradfri_it.properties

...ding.tradfri/src/main/java/org/openhab/binding/tradfri/internal/TradfriBindingConstants.java

bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/thing/thing-types.xml

* README.md alignment update * reverting translation changes to comply with automation rules via Crowdin * refactor things definition * Simplify the Air Purifier thing name * Add categories for Time and Fan * Simplified binding constants * reverted tradfri.properties due to formatting issues * added default text in tradfri.properties Signed-off-by: Vivien Boistuaud <github@boistuaud.net>

vivienbo

Thanks a lot @jlaur for your code review, really appreciated.
I fixed everything according to your recommendation, built and tested it to confirm it is still totally functional. New test packages for 3.4.4 and 4.0.0 have been updated in the description.

jlaur

Before merging, perhaps you could have a look at these small findings in the README?

bundles/org.openhab.binding.tradfri/README.md

Updates to the documentation to: * Fix Item Types * Fix abreviations (min -> minutes) * Standardize `description` column of the `Channel Type ID` table * Align the `Channel Type ID` table * Improve the `Channels` > `Air Purifier` paragraph * Align the non-ZLL capabilities table to similar format as ZLL One (uppercase first letter of each word; Align capabilities labels to `Channel Type ID` labels) Signed-off-by: Vivien Boistuaud <github@boistuaud.net>

vivienbo · 2023-05-20T11:01:02Z

Hi @jlaur, I reviewed the additions to the documentation and standardization of the tables to:

Fix Item Types
Fix abreviations (min -> minutes)
Standardize description column of the Channel Type ID table (first letter in uppercase)
Align the Channel Type ID table
Improve the Channels > Air Purifier descriptive paragraph
Align the non-ZLL capabilities table to similar format as ZLL One (uppercase first letter of each word; Align capabilities labels to Channel Type ID labels for consistency)

Waiting for the build to complete and will ask for re-review.
Thanks a lot for your support.

vivienbo

Reviewed all changes and submitted new commit with further enhancements after rewriting the Air Purifier documentation.

jlaur

The documentation update looks good. 👍 Only some nitty gritty last details.

bundles/org.openhab.binding.tradfri/README.md

* Fixed for language consistency purposes Signed-off-by: Vivien Boistuaud <github@boistuaud.net>

jlaur

LGTM. 👍 @kaikreuzer, @cweitkamp - you are both code owners for this binding, would you like to review?

jlaur · 2023-05-28T21:18:33Z

LGTM. 👍 @kaikreuzer, @cweitkamp - you are both code owners for this binding, would you like to review?

@kaikreuzer, @cweitkamp - gentle ping. 🙂

jlaur · 2023-06-17T11:14:31Z

@kaikreuzer, @cweitkamp - I really just need to know if you'd like to have a look before merging - or not? 🙂

kaikreuzer · 2023-06-17T13:28:42Z

Thanks for the regular pings @jlaur, I somehow missed them. I'd say you can feel free to merge if you do not hear anything back after a ping within 2 weeks. :-)
Many thanks for reviewing it!

kaikreuzer · 2023-06-17T13:29:23Z

(and of course many thanks to @vivienbo for the contribution!)

* [tradfri] Added Support for Air Purifier (openhab#7) Added Support for Tradfri Air Purifier: * Added documentation disambiguation Tradfri vs Dirigera * Added Tradfri Air Purifier - fanMode and fanSpeed * Workable Tradfri Air Purifier basic implementation * Tradfri: modified fanMode type and definition * Tradfri Air Purifier: Added disableLed * Tradfri Air Purifier: Added lockPhysicalButton * Tradfri Air Purifier: Added airQuality data * Tradfri Air Purifier: Added filterCheck data * Tradfri Air Purifier: Added translations * Tradfri Air Purifier: Added filter_uptime * Tradfri Air Purifier: code optimization * Documentation for supported Air Purifier channels Fixes openhab#14816 Signed-off-by: Vivien Boistuaud <github@boistuaud.net> Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>

* [tradfri] Added Support for Air Purifier (openhab#7) Added Support for Tradfri Air Purifier: * Added documentation disambiguation Tradfri vs Dirigera * Added Tradfri Air Purifier - fanMode and fanSpeed * Workable Tradfri Air Purifier basic implementation * Tradfri: modified fanMode type and definition * Tradfri Air Purifier: Added disableLed * Tradfri Air Purifier: Added lockPhysicalButton * Tradfri Air Purifier: Added airQuality data * Tradfri Air Purifier: Added filterCheck data * Tradfri Air Purifier: Added translations * Tradfri Air Purifier: Added filter_uptime * Tradfri Air Purifier: code optimization * Documentation for supported Air Purifier channels Fixes openhab#14816 Signed-off-by: Vivien Boistuaud <github@boistuaud.net> Signed-off-by: Matt Myers <mmyers75@icloud.com>

* [tradfri] Added Support for Air Purifier (openhab#7) Added Support for Tradfri Air Purifier: * Added documentation disambiguation Tradfri vs Dirigera * Added Tradfri Air Purifier - fanMode and fanSpeed * Workable Tradfri Air Purifier basic implementation * Tradfri: modified fanMode type and definition * Tradfri Air Purifier: Added disableLed * Tradfri Air Purifier: Added lockPhysicalButton * Tradfri Air Purifier: Added airQuality data * Tradfri Air Purifier: Added filterCheck data * Tradfri Air Purifier: Added translations * Tradfri Air Purifier: Added filter_uptime * Tradfri Air Purifier: code optimization * Documentation for supported Air Purifier channels Fixes openhab#14816 Signed-off-by: Vivien Boistuaud <github@boistuaud.net> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>

vivienbo requested review from cweitkamp and kaikreuzer as code owners April 17, 2023 02:02

jlaur changed the title ~~[tradfri] Added Support for Air Purifier~~ [tradfri] Add support for Air Purifier Apr 17, 2023

jlaur added the enhancement An enhancement or new feature for an existing add-on label Apr 17, 2023

vivienbo linked an issue Apr 20, 2023 that may be closed by this pull request

[tradfri] Add Support for Air Purifier #14816

Closed

[Tradfri] Translation fixes

7f4accf

* Fixes Alphabetical order of properties * Fixes a typo in some names Signed-off-by: Vivien Boistuaud <github@boistuaud.net>

jlaur requested changes May 10, 2023

View reviewed changes

vivienbo mentioned this pull request May 19, 2023

[tradfri] Air Purifier Fixes for Code Review number 1 vivienbo/openhab-addons#10

Merged

vivienbo commented May 19, 2023

View reviewed changes

vivienbo requested a review from jlaur May 19, 2023 22:38

jlaur requested changes May 20, 2023

View reviewed changes

vivienbo commented May 20, 2023

View reviewed changes

vivienbo requested a review from jlaur May 20, 2023 11:09

jlaur requested changes May 20, 2023

View reviewed changes

bundles/org.openhab.binding.tradfri/README.md Outdated Show resolved Hide resolved

bundles/org.openhab.binding.tradfri/README.md Outdated Show resolved Hide resolved

[tradfri] Air Purifier Fixes in documentation

8e7ad65

* Fixed for language consistency purposes Signed-off-by: Vivien Boistuaud <github@boistuaud.net>

vivienbo requested a review from jlaur May 20, 2023 14:03

jlaur approved these changes May 20, 2023

View reviewed changes

kaikreuzer merged commit 801b860 into openhab:main Jun 17, 2023
3 checks passed

kaikreuzer added this to the 4.0 milestone Jun 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tradfri] Add support for Air Purifier #14836

[tradfri] Add support for Air Purifier #14836

vivienbo commented Apr 17, 2023 •

edited

openhab-bot commented Apr 17, 2023

vivienbo commented Apr 19, 2023

vivienbo commented Apr 21, 2023 •

edited

jlaur left a comment

vivienbo left a comment •

edited

jlaur left a comment

vivienbo commented May 20, 2023 •

edited

vivienbo left a comment

jlaur left a comment

jlaur left a comment

jlaur commented May 28, 2023

jlaur commented Jun 17, 2023

kaikreuzer commented Jun 17, 2023

kaikreuzer commented Jun 17, 2023

[tradfri] Add support for Air Purifier #14836

[tradfri] Add support for Air Purifier #14836

Conversation

vivienbo commented Apr 17, 2023 • edited

Description

Testing

Changelog

openhab-bot commented Apr 17, 2023

vivienbo commented Apr 19, 2023

vivienbo commented Apr 21, 2023 • edited

jlaur left a comment

Choose a reason for hiding this comment

vivienbo left a comment • edited

Choose a reason for hiding this comment

jlaur left a comment

Choose a reason for hiding this comment

vivienbo commented May 20, 2023 • edited

vivienbo left a comment

Choose a reason for hiding this comment

jlaur left a comment

Choose a reason for hiding this comment

jlaur left a comment

Choose a reason for hiding this comment

jlaur commented May 28, 2023

jlaur commented Jun 17, 2023

kaikreuzer commented Jun 17, 2023

kaikreuzer commented Jun 17, 2023

vivienbo commented Apr 17, 2023 •

edited

vivienbo commented Apr 21, 2023 •

edited

vivienbo left a comment •

edited

vivienbo commented May 20, 2023 •

edited