[squeezebox] Fix notification sometimes playing last playlist item first

[t2000]

Fixes #16367

[mhilbush]

Thanks for this change.

I'm curious what you're using as a player. I know that some players (such as piCorePlayer) don't need to be powered on. But I wasn't sure about the original SqueezeBox devices, such as the SqueezeBox Receiver.

Do you think the call to isPoweredOn is not needed in restorePlayerState? And, if not needed there, should that method and associated attribute be removed completely from SqueezeBoxPlayerState.java?

[t2000]

I am indeed using software players with piCoreplayer and squeezeboxlite binaries.

Unfortunately I do not have a hardware squeezebox device to test :(

I would probably not remove it from SqueezeBoxPlayerState.java as it IS a state of the player. In the webUI of the Logitech media Server you can click the "on/off" button wich says "Power:XYZ". So I would keep it in the state, as it reflects the real player's state.

However, I would certainly remove it from the start of a notification as this leads to the undesired behavior of playing something that's still in the playlist from the last powered off moment.

[mhilbush]

Unfortunately I do not have a hardware squeezebox device to test :(

Neither do I. But i'm fine with the change. We'll just need to see if anyone who uses those devices has a problem.

But what about the call to isPoweredOn in restorePlayerState? Should that also be removed? If we're not sending the power on command, why would we want to send a power off command?

[t2000]

But what about the call to isPoweredOn in restorePlayerState? Should that also be removed? If we're not sending the power on command, why would we want to send a power off command?

Well, the playlist play NUMBER turns the player ON, i.e. the power state changes with that to ON automatically. Stopping it alone does not power it OFF. So I would suggest to keep it in there, especially in cases where real devices have to be powered off. What do you think?

[mhilbush]

So I would suggest to keep it in there, especially in cases where real devices have to be powered off. What do you think?

Yes, I think that makes sense.

[mhilbush]

LGTM

[jlaur]

I can give it a test with Radio/Receiver tonight.

[jlaur]

Thanks for the fix! It works perfectly with Squeezebox Receiver and Radio when they are initially off. After playing the notification, they are automatically turned off again.