Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[haywardomnilogic] Fix chlorinator units. Continuation of PR#15478 #16733

Merged
merged 16 commits into from
May 10, 2024

Conversation

matchews
Copy link
Contributor

@matchews matchews commented May 9, 2024

Failed to resolve one minor unit issue in PR#15478 before it was merged.

Signed-off-by: Matt Myers <mmyers75@icloud.com>
…dditional Shows)

Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
…rays based on updated Hayward API

Signed-off-by: Matt Myers <mmyers75@icloud.com>
… values

Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: Matt Myers <mmyers75@icloud.com>
@matchews matchews requested a review from lsiepel May 9, 2024 23:52
Signed-off-by: Matt <mmyers75@icloud.com>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

@lsiepel lsiepel merged commit 6c56f29 into openhab:main May 10, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.2 milestone May 10, 2024
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label May 10, 2024
PRosenb pushed a commit to PRosenb/openhab-addons that referenced this pull request May 22, 2024
…penhab#16733)

* Fixed units on chlorinator timed percent state description pattern

Signed-off-by: Matt Myers <mmyers75@icloud.com>
PRosenb pushed a commit to PRosenb/openhab-addons that referenced this pull request May 22, 2024
…penhab#16733)

* Fixed units on chlorinator timed percent state description pattern

Signed-off-by: Matt Myers <mmyers75@icloud.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
…penhab#16733)

* Fixed units on chlorinator timed percent state description pattern

Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…penhab#16733)

* Fixed units on chlorinator timed percent state description pattern

Signed-off-by: Matt Myers <mmyers75@icloud.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants