[freeboxos] FreeboxOsIconProvider should only provide icons for its own icon set #16792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
lolodomo
requested changes
May 23, 2024
...ng.freeboxos/src/main/java/org/openhab/binding/freeboxos/internal/FreeboxOsIconProvider.java
Outdated
Show resolved
Hide resolved
...ng.freeboxos/src/main/java/org/openhab/binding/freeboxos/internal/FreeboxOsIconProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
lolodomo
reviewed
May 24, 2024
...ng.freeboxos/src/main/java/org/openhab/binding/freeboxos/internal/FreeboxOsIconProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 15, 2024
…wn icon set (openhab#16792) * FreeboxOsIconProvider should only provide icons for its icon set Signed-off-by: Gaël L'hopital <gael@lhopital.org> Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…wn icon set (openhab#16792) * FreeboxOsIconProvider should only provide icons for its icon set Signed-off-by: Gaël L'hopital <gael@lhopital.org> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the FreeboxOsIconProvider tries to provide icons for every icon requests. This should be restricted to
freeboxos:iconnameUpdated ipaddress dependency because previous version was marked with one known vulnerability.