[benqprojector] Add SDDP discovery and missing menu options #16848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
mlobstein
added
the
enhancement
lolodomo
reviewed
Jun 6, 2024
.../org/openhab/binding/benqprojector/internal/discovery/BenqProjectorDiscoveryParticipant.java
Show resolved
Hide resolved
.../org/openhab/binding/benqprojector/internal/discovery/BenqProjectorDiscoveryParticipant.java
Outdated
Show resolved
Hide resolved
lolodomo
reviewed
Jun 6, 2024
bundles/org.openhab.binding.benqprojector/src/main/resources/OH-INF/addon/addon.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
lolodomo
approved these changes
Jun 7, 2024
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 16, 2024
…16848) * Add SDDP discovery Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
psmedley
added a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 16, 2024
…penhab#16848)" This reverts commit b280eaf.
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…16848) * Add SDDP discovery Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some newer BenQ projectors such as the W5800 now support Control4/SDDP discovery according to the user manual. This PR implements SddpDiscoveryParticipant as well as adding the appropriate discovery-methods for the addon finder.
Some missing menu options for the
source,picturemodeandaspectratiochannels were added to support these options that are found on newer projectors.No functional testing was done because I do not own a BenQ projector.