Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[verisure] Fix logging statement #16984

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[verisure] Fix logging statement #16984

merged 1 commit into from
Jul 3, 2024

Conversation

logresearch
Copy link
Contributor

Title

Fix the logging statement typo

Description

Hi,
We found a typo in the logging messages.
It's an incremental commit but it can improve the quality of logging messages.

Signed-off-by: logresearch <log.researchovo@gmail.com>
@jlaur jlaur changed the title Fix logging statement [verisure] Fix logging statement Jul 3, 2024
@lolodomo lolodomo merged commit 913ce68 into openhab:main Jul 3, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Jul 3, 2024
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Jul 3, 2024
@logresearch
Copy link
Contributor Author

Hi @lolodomo ,
Thanks for merging this PR.
Really hope my contribution can make openhab-addons more perfect, though the contribution is incremental.
I further reviewed some source code and logging messages and found some typos and inaccurate expression of the relation between the logging statement and its corresponding action in the source code.
Please see the details in #16989

psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jul 12, 2024
Signed-off-by: logresearch <log.researchovo@gmail.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: logresearch <log.researchovo@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants