Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[govee] Fix invalid status response handling #17048

Merged
merged 9 commits into from
Jul 16, 2024
Merged

[govee] Fix invalid status response handling #17048

merged 9 commits into from
Jul 16, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Jul 13, 2024 •
edited
Loading

@lsiepel
Fix issue and add test
0b7f751 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Jul 13, 2024
@lsiepel
Final adjustment
270fdca 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
jlaur requested changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I have added a few questions.

...g.govee/src/test/java/org/openhab/binding/govee/internal/GoveeSerializeGoveeHandlerTest.java Outdated Show resolved Hide resolved
...org.openhab.binding.govee/src/main/java/org/openhab/binding/govee/internal/GoveeHandler.java Outdated Show resolved Hide resolved
...hab.binding.govee/src/main/java/org/openhab/binding/govee/internal/CommunicationManager.java Outdated Show resolved Hide resolved
...hab.binding.govee/src/main/java/org/openhab/binding/govee/internal/CommunicationManager.java Outdated Show resolved Hide resolved
...org.openhab.binding.govee/src/main/java/org/openhab/binding/govee/internal/GoveeHandler.java Outdated Show resolved Hide resolved
@lsiepel
Review comments
58cb515 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Fix review comments
3cca5fa 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
jlaur requested changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, hopefully last iteration, found additional minor things that could be improved.

...org.openhab.binding.govee/src/main/java/org/openhab/binding/govee/internal/GoveeHandler.java Outdated Show resolved Hide resolved
...org.openhab.binding.govee/src/main/java/org/openhab/binding/govee/internal/GoveeHandler.java Outdated Show resolved Hide resolved
@lsiepel
Change logic due to review comments.
b5a3146 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Fix block
28e4b9d 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Spotless my friend
0988428 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Adjust test
b2a295d 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
jlaur requested changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. @stefan-hoehn, would you like to review this fix?

...hab.binding.govee/src/main/java/org/openhab/binding/govee/internal/CommunicationManager.java Outdated Show resolved Hide resolved
...org.openhab.binding.govee/src/main/java/org/openhab/binding/govee/internal/GoveeHandler.java Show resolved Hide resolved
...openhab.binding.govee/src/test/java/org/openhab/binding/govee/internal/GoveeHandlerMock.java Outdated Show resolved Hide resolved
...g.govee/src/test/java/org/openhab/binding/govee/internal/GoveeSerializeGoveeHandlerTest.java Outdated Show resolved Hide resolved
@lsiepel
Final comment fixes
7f412b4 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
jlaur approved these changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefan-hoehn
Copy link
Contributor

@lsiepel Thanks for jumping in. You probably fixed it much better than I could have ever done it myself 🙏🏻

@jlaur jlaur merged commit 30fa2d2 into openhab:main Jul 16, 2024
5 checks passed
@jlaur jlaur added this to the 4.3 milestone Jul 16, 2024
jlaur pushed a commit that referenced this pull request Jul 16, 2024
@lsiepel @jlaur
[govee] Fix invalid status response handling (#17048)
d29ba80 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Jul 16, 2024
@lsiepel lsiepel deleted the govee-fix branch July 16, 2024 18:07
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Jul 18, 2024
@lsiepel @andrewfg
[govee] Fix invalid status response handling (openhab#17048)
96abfd2 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel mentioned this pull request Aug 19, 2024
Merged
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
@lsiepel @digitaldan
[govee] Fix invalid status response handling (openhab#17048)
bcf4a88 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@lsiepel @pgfeller
[govee] Fix invalid status response handling (openhab#17048)
d1326f9 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maniac103 maniac103 maniac103 left review comments

@stefan-hoehn stefan-hoehn stefan-hoehn approved these changes

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[govee] binding crashes silently if receiving "wrong" values
4 participants
@lsiepel @stefan-hoehn @maniac103 @jlaur