Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[denonmarantz] Fix clearing Now Playing channels #17185

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[denonmarantz] Fix clearing Now Playing channels #17185

merged 1 commit into from
Aug 1, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jul 30, 2024

@jlaur
Fix clearing Now Playing channels
a3754d6 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Jul 30, 2024
@jlaur jlaur requested a review from jwveldhuis as a code owner July 30, 2024 19:23
lsiepel
lsiepel approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once tests are confirmed, I think this can be backported to 4.2

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/anyone-using-the-denon-marantz-binding-willing-to-help-with-a-few-tests/156042/29

@jlaur jlaur added community approved and removed additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Aug 1, 2024
@lsiepel lsiepel merged commit 87eb3a5 into openhab:main Aug 1, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Aug 1, 2024
lsiepel pushed a commit that referenced this pull request Aug 1, 2024
@jlaur @lsiepel
Fix clearing Now Playing channels (#17185)
e514860 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Aug 1, 2024
@jlaur jlaur deleted the denonmarantz-now-playing branch August 12, 2024 20:25
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
@jlaur @digitaldan
Fix clearing Now Playing channels (openhab#17185)
f24f30f 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@jlaur @pgfeller
Fix clearing Now Playing channels (openhab#17185)
ba0d192 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@jwveldhuis jwveldhuis Awaiting requested review from jwveldhuis jwveldhuis is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on community approved patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jlaur @openhab-bot @lsiepel