Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[yeelight] Fix autodiscovery with multiple network interfaces. (#6643) #6644

Merged
merged 3 commits into from Dec 22, 2019
Merged

[yeelight] Fix autodiscovery with multiple network interfaces. (#6643) #6644

merged 3 commits into from Dec 22, 2019

Conversation

vkoop
Copy link
Contributor

@vkoop vkoop commented Dec 20, 2019 •
edited by Hilbrand

Fixes and optimizes the yeelight auto discovery issues described in #6643

Closes #6643

@vkoop vkoop requested a review from claell as a code owner December 20, 2019 20:07
@TravisBuddy
Copy link

Travis tests were successful

Hey @vkoop,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@vkoop
[yeelight] Fix autodiscovery with multiple network interfaces. (#6643)
8c3ebcd 
Signed-off-by: Viktor Koop <viktor.koop@gmail.com>
@TravisBuddy
Copy link

Travis tests were successful

Hey @vkoop,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @vkoop,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Hilbrand
Hilbrand requested changes Dec 22, 2019
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small comments.

...yeelight/src/main/java/org/openhab/binding/yeelight/internal/lib/services/DeviceManager.java Outdated
logger.debug("{}: got message: {}", TAG, receivedMessage);
// we can skip the request because we aren't interested in our own search broadcast
// message.
if ((receivedMessage.startsWith("M-SEARCH"))) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ((receivedMessage.startsWith("M-SEARCH"))) {
if (receivedMessage.startsWith("M-SEARCH")) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this.

...yeelight/src/main/java/org/openhab/binding/yeelight/internal/lib/services/DeviceManager.java
logger.debug("Failed to get device information", e);
return false;
}
}).collect(Collectors.toList());

executorService = Executors.newFixedThreadPool(networkInterfaces.size());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were no changes on this line. But it looks like it creates a new fixed thread pool each time search is started 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be better to fetch the network devices only once.

I didn't know if I should keep my changes minimal or mix the bugfix and a refactoring.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I don't think it matters much. Only if the refactoring is large it could be the review process will become longer. So if you have a small fix and want that merged then keeping the change small increases the chance to get it merged quicker.

...yeelight/src/main/java/org/openhab/binding/yeelight/internal/lib/services/DeviceManager.java Outdated
}
stopDiscovery();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling stop here means it stops after the first device is found. Is that intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it wasn't intended. I've reverted this line. It was a left over from testing why the discovery didn't work.

@vkoop
[yeelight] Fix code style by removing redundant braces. (#6643)
6bbf335 
Signed-off-by: Viktor Koop <viktor.koop@gmail.com>
@TravisBuddy
Copy link

Travis tests were successful

Hey @vkoop,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@vkoop
[yeelight] Fix: Don't stop the search after first device. (#6643)
8d61116 
Signed-off-by: Viktor Koop <viktor.koop@gmail.com>
@TravisBuddy
Copy link

Travis tests were successful

Hey @vkoop,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@vkoop vkoop requested a review from Hilbrand December 22, 2019 22:33
@Hilbrand Hilbrand merged commit 08b4557 into openhab:master Dec 22, 2019
@Hilbrand Hilbrand mentioned this pull request Dec 22, 2019
Closed
@vkoop vkoop deleted the feature/6643-yeelight-fix-autodiscovery branch December 22, 2019 22:44
roieg pushed a commit to roieg/openhab-addons that referenced this pull request Dec 26, 2019
@vkoop @roieg
[yeelight] Fix autodiscovery with multiple network interfaces. (openh…
7401b66 
…ab#6643) (openhab#6644)

Signed-off-by: Viktor Koop <viktor.koop@gmail.com>
@kaikreuzer kaikreuzer added this to the 2.5.1 milestone Dec 29, 2019
kaikreuzer pushed a commit that referenced this pull request Dec 29, 2019
@vkoop @kaikreuzer
[yeelight] Fix autodiscovery with multiple network interfaces. (#6643) (
114d5c8 
#6644)

Signed-off-by: Viktor Koop <viktor.koop@gmail.com>
@darkcheater
Copy link

Thanks!
Please also have a look at my post #6026

J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jan 1, 2020
@vkoop @J-N-K
[yeelight] Fix autodiscovery with multiple network interfaces. (openh…
96c4b8a 
…ab#6643) (openhab#6644)

Signed-off-by: Viktor Koop <viktor.koop@gmail.com>
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of an add-on label Jan 12, 2020
renescherer added a commit to renescherer/openhab-addons that referenced this pull request Jan 15, 2020
@renescherer
Updated to latest 2.5.x branch
cd66b2b 
Squashed commit of the following:

commit 27534bfa0b860a22b14444328a14b2c75d0c4172
Author: Konstantin Polihronov <polychronov@gmail.com>
Date:   Wed Jan 15 10:23:17 2020 +0200

    [paradoxalarm] Limit maximum zones and partitions with new parameters and more channels added to partition thing (#6792)

    * Implementation of maxZones and maxPartitions parameters

    * Reworked creation of EvoCommunicator to use builder pattern
    * Added support for additional, non-mandatory parameters maxZones and
    maxPartitions which limit the maximum amount of zones and partitions
    that are used during refresh.
    * Changed Factory to create builder instead of communicator
    * Renamed classes to represent properly the new object creation design

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>

commit 1dd74c3e66fb279fad341057c529e5fd4897578c
Author: Sami Salonen <ssalonen@gmail.com>
Date:   Mon Jan 13 16:59:49 2020 +0200

    [modbus] Developer's guide to advice how to debug binding in IDE (#6674)

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>

commit 6764efbc95546c3bd67d7b19328ab8ce57b391ab
Author: Chris Carman <namraccr@gmail.com>
Date:   Mon Jan 13 09:58:35 2020 -0500

    [Mcp23017] Fix null pointer exception in dispose() for #6111 (#6618)

    Signed-off-by: 9037568 <namraccr@gmail.com>

commit eb3d2526c5c67571449c4cb94a5740ea7231e187
Author: Marcel <marcelrv@users.noreply.github.com>
Date:   Mon Jan 13 14:50:07 2020 +0100

    [miio] readme file creator (#6580)

    Support tool to create the miio binding readme file

    Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

commit f3bdebf62b73d2fb11af1f9803ef92e7126be753
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Mon Jan 13 13:56:23 2020 +0100

    Removed obsolete checkstyle configuration (#6829)

    See https://github.com/openhab/static-code-analysis/pull/306

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit ce293bab2b67fe19d6bb8cf30a2c8123eb6f0501
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Mon Jan 13 11:57:00 2020 +0100

    Fixed missing 2.5.2-SNAPSHOT changes (#6828)

    - Fixed itest bnd versions in tests
    - Fixed pom of disabled itests
    - Fixed version in skeleton scripts.
    - [mqtt.generic] Fixed xml formatting

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit c5efd4f6493f50253c6a9b4b216315431738c788
Author: BOFH90 <michael@becker-lan.de>
Date:   Mon Jan 13 10:48:24 2020 +0100

    [homematic] Update extra-descriptions.properties (#6827)

commit 9734fa4df90f836a7e0ef8df0d488ce16c5bc536
Author: ZzetT <6074452+ZzetT@users.noreply.github.com>
Date:   Mon Jan 13 10:28:58 2020 +0100

    [telegram] Cleanup thing status handling and avoid log flooding when connection was lost (#6789)

    * cleanup thing status handling and avoid log flooding when there is no connection

    Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

commit b2496e1af1d81f717c07791e998faf061189861c
Author: Jochen Klein <git@jochen.susca.de>
Date:   Sun Jan 12 18:46:48 2020 +0100

    [mqtt] introduce UoM for number values (#6763)

    Signed-off-by: Jochen Klein <git@jochen.susca.de>

commit e2b76330982f2658e968a58522b4aede248fd487
Merge: bd8f322a22 672a143074
Author: jenkins <jenkins@5ab8c2c3809c>
Date:   Sun Jan 12 12:49:51 2020 +0000

    Merge

commit bd8f322a22e8aa8e23c848ac1c53e861217f1eb8
Author: jenkins <jenkins@5ab8c2c3809c>
Date:   Sun Jan 12 12:49:40 2020 +0000

    [unleash-maven-plugin] Preparation for next development cycle.

commit 672a143074ba45806df794d446f239bfb11f7abc
Author: Kiryl Bahdanau <kirbah@gmail.com>
Date:   Sun Jan 12 15:49:19 2020 +0300

    [network] Added note for using DHCP with Docker (#6748)

    Signed-off-by: Kiryl Bahdanau <kirbah@gmail.com>

commit c5c2b31755fb6364f7effd02c767080111c6761b
Author: Andreas Hirsch <ando.hirsch@gmail.com>
Date:   Sun Jan 12 13:44:21 2020 +0100

    [network] Fix misleading latency values (#6770)

    * [network] Fix latency calculation (openhab#6741)
    * Introduce latency extraction from ping output (openhab#6741)
    * Provide configuration option for latency mode (openhab#6741)

    Signed-off-by: Andreas Hirsch <ando.hirsch@gmail.com>

commit 647d4c653e657c80e02691e0550839bde2fdf242
Author: pali <pauli.anttila@gmail.com>
Date:   Sun Jan 12 14:27:11 2020 +0200

    [ftpupload] Changed logging levels (#6811)

    Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>

commit b916ee9e5173cd6b93ea8f746bfa53ccf39e2aa7
Author: pali <pauli.anttila@gmail.com>
Date:   Sun Jan 12 14:26:39 2020 +0200

    [rfxcom] Changed logging level (#6810)

    Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>

commit 1f13d789ec64b4565c9c289d635105b393e8dda8
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Sun Jan 12 13:25:43 2020 +0100

    [darksky] Fixed example items in README.md (#6817)

    - Fixed example items in README.md

    Fixes #6812

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 35792c7350d3fd2a8155b0ad6a40c19d84f7cdc9
Author: pali <pauli.anttila@gmail.com>
Date:   Sat Jan 11 21:51:49 2020 +0200

    [Logreader] Changed FileTailer to use own executor service (#6786)

    Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>

commit 3afafa8e32c3b0e864932e2e5a95138613ae7f8c
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Sat Jan 11 15:07:46 2020 +0100

    [kodi] Strip URL parameters from the end of the file extension (#6809)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit dceb1f9f9e9615a9835366c7b14bc8afc7ae9a52
Author: Patrick Fink <mail@pfink.de>
Date:   Sat Jan 11 15:06:17 2020 +0100

    [bluetooth.bluez] Improve permission setup documentation (#6475)

    * [bluetooth.bluez] Improve permission setup documentation

    Signed-off-by: Patrick Fink <mail@pfink.de>

commit 8d4f904609b133e7f4c8e3fe7ccaebfc6cad22bd
Author: pali <pauli.anttila@gmail.com>
Date:   Sat Jan 11 16:03:47 2020 +0200

    [ftpupload] Improved README (#6805)

    * [ftpupload] Improved README

    Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>

commit 494c325776388c7622243528309fdc1467740df0
Author: Markkuuss <10926460+Markkuuss@users.noreply.github.com>
Date:   Sat Jan 11 15:00:17 2020 +0100

    [miio] Xiaomi Robot Vacuum Channel "state_code" and "error_code" added (#6779)

    * [miio] Channel state_code and error_code added

    Up to now, the status and error codes have only been output as text. On the one hand, this makes it complicated to create a mapping for your own status/error message (for example, in another language), and on the other hand, messages that are not yet implemented are only passed on as "UNKNOWN".

    The two channels state_code and error_code now output the integers directly, so a mapping to numbers can be easily done and new codes are also output.

    Signed-off-by: Markus Schraufstetter <markus.schraufstetter@gmail.com>

commit 6e3e59b360349e1e06b93d0eb5dcc2efd00dd148
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Sat Jan 11 11:46:18 2020 +0100

    [somfytahoma] Added checks to omit null type mismatch errors (#6797)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit c2fe2336b5667735fa735550a6bce72af96ea543
Author: Kai Kreuzer <kai@openhab.org>
Date:   Sat Jan 11 00:06:50 2020 +0100

    [azureiot] removed add-on (#6807)

    Signed-off-by: Kai Kreuzer <kai@openhab.org>

commit d21ce825898727e1fb53dc0ec570630136f12dc4
Author: Christian Güdel <cg@dmesg.ch>
Date:   Fri Jan 10 23:10:21 2020 +0100

    [tesla] Re-add force refresh channel and other small improvements (#6677)

    * Re-add force refresh channel and handler

    Also includes some other small improvements:
    - Channels cleaned up for various vehicles (allowwakeup is no longer a channel)
    - My 2018 Model S is identified by 'models2' by the API, fixed discovery service to handle this case as well

    Signed-off-by: Christian Güdel <cg@dmesg.ch>

commit b34e495a5fc0be72c9747027390bd1bed3338d69
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Fri Jan 10 22:21:18 2020 +0100

    [dsmr] Added support for Belgium smartmeter (#6645)

    * [dsmr] Added support for Belgium smartmeter

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit 184e4947cf87dbb81319b087c94841cd0467fbb8
Author: Markus Boremski <markus@boremski.net>
Date:   Fri Jan 10 22:16:25 2020 +0100

    [nanoleaf] Adding description for generation of authToken to README.md (#6759)

    * Update README.md

    Description on how to get authToken.
    Removed Panel1Brightness, because it is not supported right now.

    Signed-off-by: Markus Boremski <markus@boremski.net>

commit c31bd46a6710cf145ab1164fc366a29bc5e35aad
Author: druciak <druciak@users.noreply.github.com>
Date:   Fri Jan 10 22:07:23 2020 +0100

    [satel] Fixes for arming in mode 1 (#6772)

    * [satel] Fixes for arming in mode 1

    Signed-off-by: Krzysztof Goworek <krzysztof.goworek@gmail.com>

commit 4a5d67680f582c1bc798c1cc8ef409d47517358c
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Fri Jan 10 22:06:29 2020 +0100

    [tplinksmarthome] Added socket timeout avoids block (#6803)

    This adds a timeout to the socket connections otherwise it can possibly block forever.

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit 79a0cfd297c86a1c5732b5ef18a7b95f927ebeb3
Author: Markkuuss <10926460+Markkuuss@users.noreply.github.com>
Date:   Fri Jan 10 22:03:49 2020 +0100

    [miio] Xiaomi Robot Vacuum Status and Error Codes added. (#6778)

    Xiaomi Robot Vacuum Status Codes and Error Codes according to https://github.com/marcelrv/XiaomiRobotVacuumProtocol added.

    Signed-off-by: Markus Schraufstetter <markus.schraufstetter@gmail.com>

commit 8279fac7a49cb8612480c2946e28d6f6a09fa50a
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Fri Jan 10 21:34:45 2020 +0100

    [toon] Removed Toon binding (#6802)

    The Toon binding doesn't work anymore because they changed their API.
    Because there seems to be no activity for almost a year to fix this , it's better to remove the binding for now.
    If someone wants to fix this in the future it can simple be restored.

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit b2b3f3847a900f9186b51eeb2f87ec2f44745fb4
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Fri Jan 10 21:29:35 2020 +0100

    [zoneminder] Removed missing lib from classpath (#6796)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 9e81778fdb5870d4727541a0ea367228e8ae07aa
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Fri Jan 10 20:19:38 2020 +0100

    [tplinksmarthome] Added support for KP303 (#6773)

    * Added support for KP303
    * Fixes also global On/Off state of power strip devices.

    Closes #6576

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit 7e3e802fa8486f28d7964d6642f42bff3d19d17a
Author: Michael Geramb <mail@michael-geramb.at>
Date:   Wed Jan 8 13:11:09 2020 +0100

    Update readme (#6771)

    Hint to turn on the announcement feature.

commit 041f10b8e9bcc66cd1154afe5a8cca254653dc04
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Tue Jan 7 20:17:08 2020 +0100

    [tplinksmarthome] Fix special characters in data (#6776)

    Closes #6722

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit b9a5d479fe95bc24749c74580300de07ec233c21
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Tue Jan 7 20:14:27 2020 +0100

    [tplinksmarthome] Fix typo thing xml kl110 devices (#6774)

    The kl110 device accidentally got the id kl10 instead of kl110. There it won't work because the code would correctly use the value kl110 and that value is also used to match the device with what is returned by the device itself.

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit f6a007f581fcd36615f47f7c6b4673fa55b3ca81
Author: Marcel <marcelrv@users.noreply.github.com>
Date:   Tue Jan 7 20:08:25 2020 +0100

    [max] Max always update channels & avoid config updates (#6692)

    * [max] always update channel
    * [max] avoid unnecessary Max device config updates

    Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

commit f8e6bf731865d63ed43768c9a71ac9921b49e43f
Author: Kiryl Bahdanau <kirbah@gmail.com>
Date:   Tue Jan 7 21:59:01 2020 +0300

    [samsungtv] Add new tested TV model and more examples (#6758)

    Signed-off-by: Kiryl Bahdanau <kirbah@gmail.com>

commit d8a0a8034d2356d143415acf94218d84d9d50d5b
Author: Markus Michels <markus7017@gmail.com>
Date:   Mon Jan 6 03:56:20 2020 -0500

    NullAnnotationsCheck added to DTO (#6728)

commit 2fe44af0e2610cb90bb12920e444c395bfc0b6c8
Author: ZzetT <6074452+ZzetT@users.noreply.github.com>
Date:   Tue Jan 7 10:21:19 2020 +0100

    [Telegram] Support data URI scheme for base64 encoded images (#6736)

    * support data URI scheme for base64 encoded images

    Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

commit 783a7154290ac6d83939c44145b52d632c8fac12
Author: LuggyLuke <45229887+LuggyLuke@users.noreply.github.com>
Date:   Mon Jan 6 23:15:51 2020 +0100

    Updated THings example (#6780)

    changed e.g channel="tesla:model3:myaccount:mycar::heading"} to channel="tesla:model3:myaccount:mycar:heading"}

commit 4baf19dd8eb32339d7829c798335e242ec8824f1
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Mon Jan 6 18:39:01 2020 +0100

    [skeleton] Fixed versions in create binding skeleton scripts (#6730)

    * Fixed versions in create binding skeleton scripts

    Co-Authored-By: Jan N. Klug <jan.n.klug@rub.de>
    Co-Authored-By: Hilbrand Bouwkamp <hilbrand@h72.nl>
    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 16f5be2557c7c2b779507a547224d76bcebd381e
Author: Florian <florian.schmidt.welzow@t-online.de>
Date:   Mon Jan 6 18:37:18 2020 +0100

    [opensprinkler] Show if a station is queued and allow to remove it from the queue (#6731)

    * Show if a station is queued and allow to remove it from the queue
    * Fix wrong indentation of thing-types xml

    Fixes #6727

    Signed-off-by: Florian <florian.schmidt.welzow@t-online.de>

commit 06815315cf8ddd3b941d137f297d4c45695957d6
Author: Jochen Klein <git@jochen.susca.de>
Date:   Mon Jan 6 15:33:19 2020 +0100

    [mqtt] Allow outgoing format (#6755)

    This should address #6566 (Use "%.0f" as format and not "%d")

    Signed-off-by: Jochen Klein <git@jochen.susca.de>

commit 2b34b8981298ecff96b684416bf7865f1aae6994
Author: Florian <florian.schmidt.welzow@t-online.de>
Date:   Mon Jan 6 15:11:36 2020 +0100

    [groheondus] Do not require users to configure timeframe for waterconsumption (#6760)

    This is totally unexpected and we can set a reasonable default here.
    This is done in this commit and the default is set to one day, the same
    timeframe the app is showing by default.

    Fixes #6297

    Signed-off-by: Florian <florian.schmidt.welzow@t-online.de>

commit 385ffffdb7fccc2c4fd1f77835ef092f5ed4630b
Author: lolodomo <lg.hc@free.fr>
Date:   Mon Jan 6 15:07:10 2020 +0100

    [sonos] Avoid resuming a wrong playlist after a notification (#6765)

    Signed-off-by: Laurent Garnier <lg.hc@free.fr>

commit bc092adf29388bf812f1242434e6ecbc4f86e118
Author: Kai Kreuzer <kai@openhab.org>
Date:   Mon Jan 6 15:04:22 2020 +0100

    [tesla] ignore unknown types and prevent NPE (#6768)

    Signed-off-by: Kai Kreuzer <kai@openhab.org>

commit bbad75322b8319f9258a255dcdee111e520b443a
Author: Wouter Born <github@maindrain.net>
Date:   Sun Jan 5 13:00:59 2020 +0100

    Update POM, documentation, NOTICE files and comments for renamed repository (#6757)

    Signed-off-by: Wouter Born <github@maindrain.net>

commit 6cb5ac1ea7778358f6accae27361b9d32459b3c7
Author: erhapp <erik@happaerts.be>
Date:   Sun Jan 5 10:55:35 2020 +0100

    [scale] fix example  (#6761)

commit 090279c0dc5df99b91f6212e7bc1a78d69cebcf3
Author: Robert Michalak <rbrt.michalak@gmail.com>
Date:   Thu Jan 2 18:30:30 2020 +0100

    [digiplex] Fix "Area Ready" channel definition (#6600) (#6605)

    Signed-off-by: Robert Michalak <rbrt.michalak@gmail.com>

commit 0b2ed5242f415215968a32d95171c942cef558cc
Author: Marek Hulán <ares@users.noreply.github.com>
Date:   Thu Jan 2 14:41:43 2020 +0100

    [opengarage] update documentation (#6607)

    [OpenGarage] Fix mistakes in README.txt for a new OpenGarage binding.

    The current README.txt for OpenGarage binding contains invalid type in sitemap and the last item quotes are missing around the label. Also the example is updated so that it matches paperUI configuration. Also an item definition type was incorrect. Please see https://www.openhab.org/addons/bindings/opengarage/ for the current version.

    Signed-off-by: Marek Hulan <ares@igloonet.cz>

commit b7c61fe8baa09358ce0133e89949a7d7598f3d67
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Thu Jan 2 12:31:32 2020 +0100

    [chromecast] Stop stream instead of throwing NPE (#6744)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 4bf5d0546378cf2cec3d509f71309a735201081f
Author: Jochen Klein <git@jochen.susca.de>
Date:   Thu Jan 2 12:29:38 2020 +0100

    [mqtt][homeassistant] complete switch (#6739)

    Signed-off-by: Jochen Klein <git@jochen.susca.de>

commit 127f05d7cbb865ae2f7a939c761707f0479d5143
Author: Wouter Born <github@maindrain.net>
Date:   Wed Jan 1 18:07:05 2020 +0100

    Update copyright headers to 2020 (#6735)

    Signed-off-by: Wouter Born <github@maindrain.net>

commit 4fdac6f3e2679528b51810e7b5490eac212928f6
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Wed Jan 1 17:21:15 2020 +0100

    [kodi] Fixed assignment of values for channels 'userrating' and 'rating' (#6627)

    - Fixed assignment of values for channels 'userrating' and 'rating'

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 8b0e74ad6b27603fb6287d03e1001600b2aaf2ba
Author: Schrott.Micha <Schrott.Micha@web.de>
Date:   Wed Jan 1 16:46:56 2020 +0100

    [homematic] add missing homematic-ip devices #6623 (#6720)

    * [homematic] add missing homematic-ip devices #6623

    add (some) missing HmIP items to extra-description files - English and German.

    Signed-off-by: Michael Roßner <Schrott.Micha@web.de>

commit ddebca0872510c94158533f3acf78a7e0578cb86
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Wed Jan 1 15:57:32 2020 +0100

    [innogysmarthome] Fix Dimmer / Rollershutter / Gen 1 devices and Pushbutton (#6721)

    * [innogysmarthome] Fix "updateAvailable" for Gen 1 devices

    Closes #6613

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

    * [innogysmarthome] Don't set state twice

    Both dimmer and rollershutter set first the state as ONOFF and then as PercentType. It should set only one time because the percentage is the value actual wanted.

    Closes #6610

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

    * [innogysmarthome] Improved handling pushbutton

    Not all devices send same push button events. Some send 2 (StateChanged and ButtonPressed) others only 1 (StateChanged).
    When ButtonPressed is send the StateChanged doesn't contain lastPressedButtonIndex. So in that case we ignore the StateChanged event.
    The previous implementation assumed type was also always present, but that is not the case so it can't be used as an check.

    Closes #6624

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit 22812f7b9fad727157a3db5ac89eae540620d68b
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Wed Jan 1 12:27:15 2020 +0100

    [mqtt] Fixed documentation of format pattern (#6586)

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 83e8d6969a4204590465fef49c9a6596dae27f9b
Author: lolodomo <lg.hc@free.fr>
Date:   Wed Jan 1 12:21:11 2020 +0100

    [sonos] Added discovery of Sonos One SL (#6705)

    * [sonos] Discovery of Sonos One SL

    Signed-off-by: Laurent Garnier <lg.hc@free.fr>

commit c231aed6d4216decf1dec5d5e4f892d65369fc1d
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Tue Dec 31 15:23:36 2019 +0100

    [deconz] Added support for ZHAFire sensors (#6716)

    * Added support for ZHAFire sensors

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 0d57d56000d49a58b4076701281dd84a69510367
Author: Jochen Klein <git@jochen.susca.de>
Date:   Tue Dec 31 14:08:26 2019 +0100

    [mqtt] Enable discovery timeout reset (#6704)

    * Enable discovery timeout reset.

    Signed-off-by: Jochen Klein <git@jochen.susca.de>

commit 6e5d7eb10d73c2eba61d3b9c90b223414936598c
Author: Schrott.Micha <Schrott.Micha@web.de>
Date:   Tue Dec 31 13:39:34 2019 +0100

    [mail-binding] correct README.md (#6719)

    use apostrophy correct

    Signed-off-by: Michael Roßner <Schrott.Micha@web.de>

commit 1437bc9fbcdaacaf7e1d850043bdd67c489cca9f
Author: Sami Salonen <ssalonen@gmail.com>
Date:   Tue Dec 31 10:03:33 2019 +0200

    [modbus] Rename local variable (#6667)

    Signed-off-by: Sami Salonen <ssalonen@gmail.com>

commit 7d1ffff3e40d29a11dd120be6aecd9024749b210
Author: Daniel Weber <25605184+fruggy83@users.noreply.github.com>
Date:   Tue Dec 31 08:53:34 2019 +0100

    [enocean] Replaced ChannelTypes by system ChannelTypes (#6517)

    * Replaced motionDetection and windspeed ChannelTypes by corresponding system ChannelTypes
     * Removed obsolete channel definitions
     * Added Unit Type to some more Items

    Fixes #6164

    Signed-off-by: Daniel Weber <uni@fruggy.de>

commit 93701031f86c4c17e26fffa67f8f7784f38d6fef
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Mon Dec 30 16:06:20 2019 +0100

    Fixed IAE when downloaded image is 'null' (#6711)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 4e68853f863e61257563438c7b4dea3441ced6bb
Author: Björn Brings <bjoernbrings@web.de>
Date:   Mon Dec 30 08:21:18 2019 +0100

    [valloxmv] Typo in folder name prevents binding from working correctly (#6709)

    Fixes #6652

    Signed-off-by: Björn Brings <bjoernbrings@web.de>

commit c3b104e0216c8e1cbb5f81d4736329558c391f2c
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Fri Dec 27 11:21:00 2019 +0100

    Changed path to Travis badge in README.md (#6689)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 114d5c896c4709363ad09895a9c722ddb2f5cd30
Author: Viktor Koop <viktor.koop@googlemail.com>
Date:   Sun Dec 22 23:38:33 2019 +0100

    [yeelight] Fix autodiscovery with multiple network interfaces. (#6643) (#6644)

    Signed-off-by: Viktor Koop <viktor.koop@gmail.com>

commit b22b0682f1984f11c3afb18568d9cb3e37b03138
Author: Florian <florian.schmidt.welzow@t-online.de>
Date:   Sun Dec 22 22:30:04 2019 +0100

    [opensprinkler] Adapt to breaking api changes of opensprinkler (#6650)

    OpenSprinkler now supports two rain sensors, including a breaking change
    in the http api by renaming rs to sn1 and sn2. Adapting to that in this
    commit, so that the rain sensor channel is working again.

    Signed-off-by: Florian <florian.schmidt.welzow@t-online.de>

commit 5755398f8d33d6cb5c697ee14830c2a3afb93aa6
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Sun Dec 22 18:17:18 2019 +0100

    Added dependency on commons-collections to marrytts; Bump version to 3.2.2; (#6657)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 752f7297fa7db91822440c49bf0cf41519fd2c7a
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Sun Dec 22 15:51:03 2019 +0100

    Removed dependency on 'org.apache.commons.collections' (#6656)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit d3a5939582134b2b628a8c9c5a21caef968443e7
Author: sharo1k <sharo1024@yahoo.com>
Date:   Sun Dec 22 10:47:12 2019 +0200

    [SNMP] Process enterprise OID in V1TRAP PDUs (#6511)

    Add processing of Enterprise OID for V1TRAP PDUs

    Signed-off-by: Vladimir Velev <sharo1024@yahoo.com>

commit 5194625d4f91caf766a5e0dccb91ad61ede21348
Author: Florian <florian.schmidt.welzow@t-online.de>
Date:   Sat Dec 21 19:23:22 2019 +0100

    [opensprinkler] Fix type cast exception (#6649)

    Fixes #6646

    Signed-off-by: Florian <florian.schmidt.welzow@t-online.de>

commit c92046a919988b23e003f222d5c6f8176c80cdce
Author: Schrott.Micha <Schrott.Micha@web.de>
Date:   Sat Dec 21 19:20:27 2019 +0100

    [mail] update smtp server name to have it consistent (#6648)

    make the example consistent with re-using the defined samplesmtp in mail.things

    Also-by: Michael Roßner <Schrott.Micha@web.de>
    Signed-off-by: Rosi2143 <Schrott.Micha@web.de>

commit 4cb84d7bc0fffdf8a621eb137ecc512383952332
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Sat Dec 21 19:01:56 2019 +0100

    Update README.md (#6651)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 88c489091862784167ce0880c4fbde2d8a0b6c0c
Author: Bernhard <48006183+furtber@users.noreply.github.com>
Date:   Fri Dec 20 13:18:37 2019 +0100

    [tesla] Fix Model X thing-type id (typo) (#6637) (#6638)

commit 505e1d3cbb23ceb8d30332fbadeb29d2ca7a015f
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Thu Dec 19 20:50:03 2019 +0100

    fix state/command values for switches (#6589)

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 1e196e5512013fedf493ca07795b92e02b7bfb7b
Author: Marcel <marcelrv@users.noreply.github.com>
Date:   Wed Dec 18 21:43:18 2019 +0100

    [miio] adding device strings (#6448)

    Added several devices

    Also includes required db updates to not overwrite manual readme fixes

    Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

commit b7b21b05d23929f42960e62e63c957c22a26e541
Author: Jürgen Baginski <opus42@gmx.de>
Date:   Wed Dec 18 18:29:44 2019 +0100

    [Tankerkoenig] Updated README  (#6606)

    Updated README to suggest the use of the ephemeris action for setting the holiday switch.

    Signed-off-by: Juergen Baginski opus42@gmx.de (github: JueBag)

commit 6dc5d5aa09bc8d1cfd04e147c2ae5f655de9360a
Author: Marcel <marcelrv@users.noreply.github.com>
Date:   Wed Dec 18 18:28:23 2019 +0100

    [miio] fix wrong channel for vacuum thing (#6615)

    fix invalid type

    Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

commit 44281c80dec1f984d013c1a1a6844fc3c41e6523
Author: mueller-ma <mueller-ma@users.noreply.github.com>
Date:   Wed Dec 18 08:19:40 2019 +0100

    [shelly] Fix typo in Readme (#6602)

commit 35c82f5e63789e0ac2c59af3add666a7fa3ddffd
Author: Daniel Weber <25605184+fruggy83@users.noreply.github.com>
Date:   Wed Dec 18 07:31:16 2019 +0100

    [enocean] Ignore messages with unknown RORG (#6519)

    Fixes #5997

    Ignore messages with unknown RORG

    Signed-off-by: Daniel Weber <uni@fruggy.de>

commit c064a6ce067516478bbb2dd4825b67cca4c85a45
Author: Scott Rushworth <openhab@5iver.com>
Date:   Wed Dec 18 01:28:31 2019 -0500

    [amazonechocontrol] Fixed typo in log (#6617)

    Signed-off-by: Scott Rushworth <openhab@5iver.com>

commit 688281aefdeedf6886ed1fca08ee70a9666053a5
Author: Scott Rushworth <openhab@5iver.com>
Date:   Wed Dec 18 01:27:54 2019 -0500

    [pioneeravr] Fixed typo in log (#6616)

    Signed-off-by: Scott Rushworth <openhab@5iver.com>

commit 435294d04737af9ba661923e5536cb4a9b016745
Author: Rosi2143 <Schrott.Micha@web.de>
Date:   Tue Dec 17 08:21:38 2019 +0100

    [homematic] make lookup table for device description case insensitive(#6525) (#6530)

    make all keys uppercase and also seach for uppercase keys only
    this way it does not matter if keys contain HmIP or HMIP strings.

    Signed-off-by: Michael Roßner <Schrott.Micha@web.de>

commit 7feaf9fa7caa6847f0a575793fa13148e11765b7
Author: Rosi2143 <Schrott.Micha@web.de>
Date:   Tue Dec 17 08:21:11 2019 +0100

    [homematic] correct SCA warnings - README.md (#6539)

    * [homematic] correct SCA warnings - README.md

    Also-by: Michael Roßner <Schrott.Micha@web.de>
    Signed-off-by: Rosi2143 <Schrott.Micha@web.de>

commit a4820097214853f8dad9c87a394315360baeeec9
Author: skvalex <skvalex@gmail.com>
Date:   Tue Dec 17 10:19:54 2019 +0300

    [miio] Add indicator light channel for Mi-Power plug (#6567)

    Signed-off-by: Alexander Skvortsov <skvalex@gmail.com>

commit b550a98dd2f065af645e7553269deedae195c140
Author: Dan Cunningham <dan@digitaldan.com>
Date:   Fri Dec 20 09:55:07 2019 -0800

    [harmonyhub] Harmony discovery fix (#6636)

    * Fix for other non Harmony Hub Logitech devices responding to a discovery query and preventing hubs from being found, minor discovery code cleanup, closes #6621

    Signed-off-by: digitaldan <dan@digitaldan.com>

commit 62c39c8fbe80f48cfd1d24e620118b6692f30586
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Fri Dec 20 00:30:44 2019 +0100

    Fix itest.bndrun version numbers (#6633)

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit 5fbb18018392cda1dfbe9aae2c26a1e03dc4c7e6
Author: Kai Kreuzer <kai@openhab.org>
Date:   Thu Dec 19 08:27:58 2019 +0100

    switched to SNAPSHOT version

    Signed-off-by: Kai Kreuzer <kai@openhab.org>

commit 69053245f18b7a6899ffc4622890580fa8b8c87c
Author: jenkins <jenkins@2e0d38b24e1d>
Date:   Sun Dec 15 17:21:48 2019 +0000

    Preparation for tag creation (Tag name: '2.5.0').

commit e6f22e182fc8d0fa31fb0236dd194237dd05e075
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Sun Dec 15 01:52:33 2019 +0100

    [hue] Prevent interminable loop when updating the configuration of the sensor thing handler (#6590)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit b4583f9847ee54ed9bd99791f36714f50f905f08
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Sat Dec 14 18:32:10 2019 +0100

    [mqtt][homeassistant] fix connection deserialization (#6587)

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 9fd1526092d7c5ca13f314e9ef840e876115e232
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Sat Dec 14 16:58:54 2019 +0100

    [mqtt][homie] fix homie test after refresh handling changed (#6588)

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 2bc1ea03dbacc262f47f4b5adeff68a48e9fc5ee
Author: Sebastian Prehn <2531264+sprehn@users.noreply.github.com>
Date:   Sat Dec 14 11:58:31 2019 +0100

    Fixed exception when launching apps, as sessionId is optional in the response. (#6585)

    Fixed various warnings on handling potential null values.

    Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>

commit bf248c25250fdb334654181359ba4f6ee1b661f0
Author: Markus Michels <markus7017@gmail.com>
Date:   Sat Dec 14 11:56:20 2019 +0100

    [shelly] Hardening for 2.5final (#6575)

    * Fix: input channel for relay; deregister from onEvent on dispose(); post
    LOW_BATTERY alarm for sensors
    * New channel button for relay; event channel removed except for roller;
    device event mapping adapted; moved device definition to device.xml;
    README updated
    * event decoding fixed; avoid NPE on event and uninitialized thing
    * button channel added for Dimmer
    * Renamed channel signal to wifiSignal (prevent old JSONDB data) and
    changed channel type to system.signal-strength
    * deregister disposed thing handler from deviceListeners from Handler
    Factory (ShellyListenerManager removed); README updated

    Signed-off-by: Markus Michels <markus7017@gmail.com>

commit 5c1c4244cc5160c2e615ef87b4642211a62d0e22
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Sat Dec 14 11:46:00 2019 +0100

    add missing logger parameters and  codestyle (#6581)

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 584c444236f9806d8b3d2d0b595b65066248a78a
Author: Mark Hilbush <mark@hilbush.com>
Date:   Fri Dec 13 17:57:16 2019 -0500

    [ambientweather] Attempt to reconnect to service (#6582)

    Signed-off-by: Mark Hilbush <mark@hilbush.com>

commit 05bb068e6917bbe8900a3ce0a4b9ebcbef1c67de
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Fri Dec 13 17:16:55 2019 +0100

    [hue] Decoupling of 'sensorRefreshInterval' and time gap for lastchange check (#6579)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 34b5027af5bc017873f070c045ec8d58d89ebf43
Author: Ondrej Pecta <opecta@gmail.com>
Date:   Fri Dec 13 15:32:14 2019 +0100

    [somfytahoma] Migrated to v2 Tahoma API (#6500)

    Signed-off-by: Ondrej Pecta <opecta@gmail.com>

commit 50ba842f0bb7056468b99f5f40c2cbc4f0630c00
Author: lolodomo <lg.hc@free.fr>
Date:   Fri Dec 13 15:14:30 2019 +0100

    [nuki] Clean handling of bridge/things (#5912)

    Fix #5859

    Signed-off-by: Laurent Garnier <lg.hc@free.fr>

commit c7dc00d177ffedeaf7d1608c6129152f91a59ccb
Author: gibnix <gibnix@vbcl.de>
Date:   Thu Dec 12 22:44:01 2019 +0100

    Fixed discover() function by adding DEFAULT_BROADCAST_PORT to DatagramSocket (#6565)

    Fixes #6557

    Signed-off-by: Kai Großhaus <kai.grosshaus@vbcl.de>

commit 746ecb7a8f856f8e21ca31b61b5edd4c6a65b5b4
Author: Kai Kreuzer <kai@openhab.org>
Date:   Mon Dec 9 21:22:39 2019 +0100

    [tradfri] removed explicit Californium dependency to avoid embedding (#6544)

    Signed-off-by: Kai Kreuzer <kai@openhab.org>

commit 3888a2f3000d2656bae54b52a3a6eea26714e9c2
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Mon Dec 9 20:31:27 2019 +0100

    [mqtt][homie] fix handleCommand with special characters (#6540)

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 395b6b5086d4a5eec6236a82134b726e1c6908a0
Author: Arne Seime <seime@users.noreply.github.com>
Date:   Mon Dec 9 16:56:30 2019 +0100

    [millheat] Millheat Binding initial contribution (#5077)

    Signed-off-by: Arne Seime <arne.seime@gmail.com>

commit 0e7d38143500584c160249006829892e86770636
Author: Martin Herbst <develop@mherbst.de>
Date:   Sun Dec 8 22:35:53 2019 +0100

    [homematic] Explicit create of numeric Objects is needed (#6546)

    Partial revert of #6531 because of conversion exceptions if numeric
    values are not wrapped as objects.

    Signed-off-by: Martin Herbst <develop@mherbst.de>

commit 6a7fcc0ba0951b523f056b62444fc2917cf01aa6
Author: Markus Michels <markus7017@gmail.com>
Date:   Sun Dec 8 22:30:56 2019 +0100

    [shelly] Shelly Binding initial contribution (#6320)

    Signed-off-by: Markus Michels <markus7017@gmail.com>

commit 516d6f46938f44234c9ada48e0eef048d58a0bfe
Author: Rosi2143 <Schrott.Micha@web.de>
Date:   Sun Dec 8 15:47:57 2019 +0100

    Update .gitignore (#6542)

    Add directory .history to .gitignore file to ignore VSCode auto-backup files

    Also-by: Michael Roßner <Schrott.Micha@web.de>
    Signed-off-by: Rosi2143 <Schrott.Micha@web.de>

commit a2a09b8e188204a3332735ade8f1ae8bca204dff
Author: Rosi2143 <Schrott.Micha@web.de>
Date:   Sun Dec 8 10:09:52 2019 +0100

    [homematic] correct warnings (#6531)

    Signed-off-by: Michael Roßner <Schrott.Micha@web.de>

commit a28e5f8b15652104746c533a2a62b283b1250af1
Author: Luca Calcaterra <calcaterra.luca@gmail.com>
Date:   Sun Dec 8 09:16:36 2019 +0100

    [melcloud] MELCloud Binding initial contribution (#6059)

    Also-by: Pauli Anttila <pauli.anttila@gmail.com>
    Also-by: Wietse van Buitenen <thewiep@gmail.com>
    Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>

commit 61f9752e8f01d92bd3b40e7e812935eced556e32
Author: fex01 <github@fexmail.de>
Date:   Sat Dec 7 21:27:10 2019 +0100

    [netatmo] Updated netatmo icon URLs (#6532)

    * Updated icon URLs
    * Updated icon URLs to https

    Seems like Netatmo updated their URLs for icons, the old ones are no longer valid.
    I updated the URLs posted on this page to avoid '404 - Not Found' errors.

commit 7e36e7e5cba597117f597db996ea9b083b0d6fc9
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Sat Dec 7 20:36:54 2019 +0100

    [innogysmarthome] Several improvements (#6508)

    * Reschedule after failure
    * Fixed update TwoWayMeter energy_day_euro channel

    When the connection is closed it should not schedule once, but schedule until a connection is made. Otherwise the binding will not come online anymore.

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit 835d47a046638557445ea4ce4a01994a500ad778
Author: Gert-jan Theunissen <gurtjun@users.noreply.github.com>
Date:   Sat Dec 7 19:30:04 2019 +0100

    Add RX-860 to compatible receivers (#6527)

commit 79eb08734c1a75b1aa5f99330bcc6dc88c124c63
Author: Markkuuss <10926460+Markkuuss@users.noreply.github.com>
Date:   Sat Dec 7 19:23:18 2019 +0100

    [miio] Add support for Roborock S5max (#6516)

    Signed-off-by: Markus Schraufstetter <markus.schraufstetter@gmail.com>

commit 918c47576e45dbe913970ece8b95caa9ad305ca3
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Sat Dec 7 18:46:32 2019 +0100

    [mqtt] fix discovery subscriptions on re-connection (#6505)

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit d6618031940f7d46e234c7dbd154ba100b8914b7
Author: Mark Hilbush <mark@hilbush.com>
Date:   Sat Dec 7 06:10:53 2019 -0500

    Fix handling of thing status (#6522)

    Signed-off-by: Mark Hilbush <mark@hilbush.com>

commit 4ee787ede8907c717e3ba2b127370e73512da359
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Fri Dec 6 15:14:04 2019 +0100

     Bump Californium to 2.0.0 (#6518)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 32512e1b29c704b1bc3c815304f548ab3d69dd10
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Thu Dec 5 23:42:23 2019 +0100

    [telegram] small fixes (#6514)

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 58181fa9f76046f4ee3f8fab5a26ab32d73c0774
Author: David Gräff <david.graeff@web.de>
Date:   Thu Dec 5 22:53:10 2019 +0100

    [HueEmulation] Fix status report page

    The page reported a wrong upnp announcement thread status

    Signed-off-by: David Gräff <david.graeff@web.de>

commit 5784917b9846b165b59e194b6abb33e3b255ca74
Author: Nicolai Grødum <grodum@gmail.com>
Date:   Thu Dec 5 21:25:27 2019 +0100

    Added the tag "Huelight" which allows Group items to be exposed as a device. (#6510)

    Signed-off-by: Nicolai Grødum <git@grodum.org>

commit ddcff023444f34e2b18e5567a4c2313fda13dbbd
Author: Mark Hilbush <mark@hilbush.com>
Date:   Thu Dec 5 08:08:05 2019 -0500

    [weathercompany] Weather Company Binding initial contribution (#5780)

    Signed-off-by: Mark Hilbush <mark@hilbush.com>

commit 92548423954f7d3f0b43f31783122c8e764f1fae
Author: Wouter Born <github@maindrain.net>
Date:   Thu Dec 5 08:12:08 2019 +0100

    [lifx] Fix NPE when things don't have properties (#6509)

    Signed-off-by: Wouter Born <github@maindrain.net>

commit abcadcbd03c7929c207399c999f1ba90666e3831
Author: Nicolai Grødum <grodum@gmail.com>
Date:   Thu Dec 5 08:10:55 2019 +0100

    Added C/WS as a hint for detecting Ikea Tradfri color bulbs. (#6506)

    Signed-off-by: Nicolai Grødum <git@grodum.org>

commit a316befe8f37139788325f823aa348a6ac8db0d0
Author: Mike Major <mike_j_major@hotmail.com>
Date:   Tue Dec 3 14:44:59 2019 +0000

    [dlinksmarthome] Changed to openHAB Core feature of JAX-WS (#6439) (#6478)

    Signed-off-by: Mike Major <mike_j_major@hotmail.com>

commit 74d0fb337f2ad8606ebe2476ab9a49b2b50ec440
Author: Kai Kreuzer <kai@openhab.org>
Date:   Tue Dec 3 12:38:33 2019 +0100

    [mail] added dependency to javax.mail (#6494)

    * added dependency to javax.mail
    * added some other small fixes

    Signed-off-by: Kai Kreuzer <kai@openhab.org>

commit 3ae6a41625f3c78f29eed244be653843d96a5814
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Mon Dec 2 22:40:27 2019 +0100

    [mqtt] Fix several issues after loss of connection (#6485)

    * fix wrong future handling in handleCommand

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 194551db7519172b0f4f0003b0b4b51a8298e1d5
Author: Wouter Born <github@maindrain.net>
Date:   Mon Dec 2 19:15:02 2019 +0100

    [marytts] Upgrade to MaryTTS 5.2 and use Maven dependencies (#6482)

    * Upgrades MaryTTS to the official 5.2 release
    * Uses Maven dependencies instead of JARs which:
      - cleans up the repository
      - speeds up builds (due to local Maven repo artifact caching)
      - makes the openHAB https://bintray.com/openhab/3rd/marytts repository obsolete
    * Fixes debug logging being printed during speech synthesis

    I've removed as much unused dependencies as possible but this new version has ICU4J as required dependency which adds 8.8 MB.

    Signed-off-by: Wouter Born <github@maindrain.net>

commit 461d2bb6c5d39f83ee6083f53891a9333921640d
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Mon Dec 2 15:23:42 2019 +0100

    [innogysmarthome] Fix loop bug (#6490)

    Apparently some refactoring after review went wrong and instead of calling the correct method, the method ended up calling itself, resulting in crashing the system.

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit 3225c72c4cf366df6d1ab57fab1c9e66da0d000c
Author: Flole998 <Flole998@users.noreply.github.com>
Date:   Mon Dec 2 12:49:13 2019 +0100

    [homematic] Add Max! Basic Thermostat Descriptions (#6480)

    Signed-off-by: Flole <flole@flole.de>

commit d43f04d3a7f37b64861ad4bede1afd6be81ff072
Author: Kai Kreuzer <kai@openhab.org>
Date:   Mon Dec 2 12:43:14 2019 +0100

    [ipp] added simple-xml dependency (#6481)

    * added simple-xml dependency
    * also added xmlpull dependency
    * cleaned up dependencies
    * removed dependencies from feature as the appropriate ones are now embedded

    Signed-off-by: Kai Kreuzer <kai@openhab.org>

commit e5f16be70fb1bb171a33f5cc428f72997cb463dc
Author: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
Date:   Sun Dec 1 18:59:47 2019 +0100

    [wemo] DimmerHandler - reduced one logger from info to debug (#6486)

    Signed-off-by: Hans-Jörg Merk hans-joerg.merk@t-online.de

commit 476580195e752e467fda7e2975a504461f6e3aad
Author: Bob A <bobadair@users.noreply.github.com>
Date:   Sat Nov 30 16:52:49 2019 -0500

    [lutron] Doc update (#6456)

    Signed-off-by: Bob Adair <bob.github@att.net>

commit 1cfcde536a5f60b08125184a1a38b6b51a7258e9
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Sat Nov 30 17:43:05 2019 +0100

    Removed dependency on 'org.apache.commons.collections' (#6434)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 55b6dd4bcc94d6c320f099d50c41c466c73e0bb8
Author: Nicolai Grødum <grodum@gmail.com>
Date:   Sat Nov 30 00:15:23 2019 +0100

    [hueemulation] Fix ipv4 or ipv6 only environment (#6403)

    * Hue emulation did not work for me in a non-ipv6 environment. To me it seems the code would try to bind to ipv6 if only ipv4 was enabled.
    * Hue emulation did not work for me in a non-ipv6 environment. If it could not bind to ipv6, the channel.open would throw, taking ipv4 with it.

    Signed-off-by: Nicolai Grødum <git@grodum.org>

commit 38c654e3ef42c955d09d0d8c9e9a7a6714fd25da
Author: Montinew <38977339+Montinew@users.noreply.github.com>
Date:   Fri Nov 29 22:49:41 2019 +0100

    Update README.md (#6474)

    Added Silvercrest SIRD 14 D1

commit b928ada38835727c376a8e19a9d01771328365fa
Author: Kai Kreuzer <kai@openhab.org>
Date:   Fri Nov 29 22:48:35 2019 +0100

    fixes NPE if get method returns null (#6473)

    Signed-off-by: Kai Kreuzer <kai@openhab.org>

commit f156a05f3db42c639f53e6ee545d8cb0485ff5b3
Author: Kai Kreuzer <kai@openhab.org>
Date:   Thu Nov 28 22:49:34 2019 +0100

    fixed XML formatting (#6470)

    Signed-off-by: Kai Kreuzer <kai@openhab.org>

commit 63c4be0eab420ff86d3d2f0e34870e4d0e871ac8
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Thu Nov 28 22:03:56 2019 +0100

    [kodi] Added German translations for 'shownotification' channel configuration (#6468)

    * Added German translations for 'shownotification' channel

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit fb216e99549b221904c870aabe7915d0dbb2cb70
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Thu Nov 28 16:04:54 2019 +0100

    Removed dependency on 'org.apache.commons.collections' (#6467)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit f81603219eb46dad5f1baa40fa806f5b4588b2ad
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Thu Nov 28 12:52:50 2019 +0100

    [innogysmarthome] New version for innogy-API 1.1 (#6389)

    Refactored to use openHAB OAuth2 and Http
    Added BT-PSS (Bluetooth Pluggable Smart Switch)
    Fix RST, Button-Issue and Channel-Trigger Event
    General code improvements reported by SAT

    Also-by: Oliver Kuhl <oliver.kuhl@gmail.com> (github: ollie-dev)
    Also-by: Nicholas Prinz <github@prinzenweb.de>
    Also-by: Ralph Sester <ralph.sester@sester-edv.de>
    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit 09231cca8c9c59dd310ace9b9af041cc9af10752
Author: Mark Hilbush <mark@hilbush.com>
Date:   Thu Nov 28 01:49:50 2019 -0500

    [bigassfan] README updates (#6462)

    * README updates

    Signed-off-by: Mark Hilbush <mark@hilbush.com>

commit cc341f6df61e3dee27187768f250278ff2b5f4a5
Author: Mark Hilbush <mark@hilbush.com>
Date:   Thu Nov 28 01:48:35 2019 -0500

    README updates (#6464)

    Signed-off-by: Mark Hilbush <mark@hilbush.com>

commit 63114233c7f7002d1fbfaee707a122e14bc254c0
Author: Martin van Wingerden <martin@martinvw.nl>
Date:   Wed Nov 27 22:19:41 2019 +0100

    Some small improvements (#6463)

    While setting up my new dev-environment I noted some errors malformattings

    Signed-off-by: Martin van Wingerden <martin@martinvw.nl>

commit e5d34493d4a83be01a70f0e1fc3355ec95675923
Author: Mark Hilbush <mark@hilbush.com>
Date:   Wed Nov 27 14:39:54 2019 -0500

    [ambientweather] Minor documentation updates (#6460)

    Signed-off-by: Mark Hilbush <mark@hilbush.com>

commit f8231cdc70abb46587c1bb92273dacc28e2d901f
Author: Sebastian Prehn <2531264+sprehn@users.noreply.github.com>
Date:   Tue Nov 26 13:46:56 2019 +0100

    [lgwebos] README updated (#6443)

    README updated to reflect that connectsdk library was removed

    Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>

commit eb3e3d4a80e2b258f5c0d2bb5c5c64364feb7e81
Author: Dan Cunningham <dan@digitaldan.com>
Date:   Tue Nov 26 06:43:31 2019 -0600

    [iaqualink] Checks for "error" status of returned home message (#6449)

    Signed-off-by: digitaldan <dan@digitaldan.com>

commit 20205cc1fb004ab8b3563283fb682091a54986f8
Author: Daniel Weber <25605184+fruggy83@users.noreply.github.com>
Date:   Mon Nov 25 22:29:13 2019 +0100

    [enocean] Implement EEP A5-13 for environmental sensors (#5741)

    fixed formatting issues and added class descriptions

    Fixes #5740

    Signed-off-by: Daniel Weber <uni@fruggy.de>

commit d21dc113038daa502a2e566e64bdcbe37f20bd63
Author: Fredrik Ahlström <fredrikahlstrom75@gmail.com>
Date:   Mon Nov 25 22:28:22 2019 +0100

    [lghombot] LG HomBot Binding initial contribution (#4181)

    Signed-off-by: Fredrik Ahlström <fredrikahlstrom75@gmail.com>

commit dcc7b5dc1531bff8ff66fc44ba1037db2f02ce6f
Author: Kai Kreuzer <kai@openhab.org>
Date:   Sun Nov 24 17:42:05 2019 +0100

    Refactored Tesla binding to use an account, added support for Model X, 3 and Y, added discovery and unit support (#6342)

    Also-by: Dan Cunningham <dan@digitaldan.com>
    Signed-off-by: Kai Kreuzer <kai@openhab.org>

commit d197a07c182e1f410fb6a435d7bd9302791a4efc
Author: Jerome Luckenbach <github@luckenba.ch>
Date:   Sun Nov 24 13:40:22 2019 +0100

    [pixometer] Pixometer Binding initial contribution (#4162)

    Signed-off-by: Jerome Luckenbach <github@luckenba.ch>

commit 8b6c44f76baffa2563632fc890ea0f194eefc598
Author: Dan Cunningham <dan@digitaldan.com>
Date:   Sat Nov 23 13:30:42 2019 -0600

    [hydrawise] Hydrawise Binding initial contribution (#5877)

    Signed-off-by: digitaldan <dan@digitaldan.com>

commit a28115a42e5416188352c8ba2c1d6ba29832fec5
Author: Sebastian Prehn <2531264+sprehn@users.noreply.github.com>
Date:   Sat Nov 23 11:26:13 2019 +0100

    [lgwebos] README update for to new new binding version (#6436)

    Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>

commit f1b224a50c2326ae73781d79533216fa85afe80c
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Fri Nov 22 22:51:54 2019 +0100

    [kodi] Updated pattern for rating channel (#6437)

    The rating is a decimal number so we should better support on decimal place in the pattern.

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 664fe98b7dc1dfbbb093149f3bd7e458522ee118
Author: klocsson <46620175+klocsson@users.noreply.github.com>
Date:   Thu Nov 21 22:45:12 2019 +0100

    [enturno] Documentation update (#6382)

    * Update link
    * Update configuration example
    This is to suit widget that will be released

    Signed-off-by: Michal Kloc <mkloc.developer@gmail.com>

commit 229d484a68cfa1262db66d4a21d285f8f6c06ae7
Author: ZzetT <6074452+ZzetT@users.noreply.github.com>
Date:   Thu Nov 21 21:54:18 2019 +0100

    sending pictures via http/https is now possible if the address is only reachable from the local network + support for basic authentication  (similar to the old binding) (#6419)

    Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

commit 352011f7a56058301fb0d855add54476b71dd5b7
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Thu Nov 21 21:06:00 2019 +0100

    Fixes NPE if no profile is returned in response (#6432)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit e1b14edd146c9bfe93e5200ba0368929f55bb3ba
Author: Sebastian Prehn <2531264+sprehn@users.noreply.github.com>
Date:   Thu Nov 21 21:02:12 2019 +0100

    Subscribe also to volume changes when external speakers are only attached in addition to the internal ones. (#6411)

    Added additional comments in code to document the various scenarios.

    Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>

commit 6e4cd917df5d37a24452f76682a5bb061657346d
Author: lolodomo <lg.hc@free.fr>
Date:   Wed Nov 20 12:22:58 2019 +0100

    [rotel] Fix handling of freq value (#6424)

    Fix #6417

    Signed-off-by: Laurent Garnier <lg.hc@free.fr>

commit 631dde882219726a6a7c563b00f0c2b3e2c42a86
Author: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
Date:   Wed Nov 20 10:17:07 2019 +0100

    [wemo] Improvements and corrections in README (#6427)

commit 442ab2ce0f77f80b5d77523c0e2a3ce78e5eb1e6
Author: Wouter Born <github@maindrain.net>
Date:   Wed Nov 20 01:26:31 2019 +0100

    Fix build (#6425)

    Signed-off-by: Wouter Born <github@maindrain.net>

commit 694fcfb3f9f036964b1e80776d155e7734f0acfc
Author: Alexander Falkenstern <falkena@users.noreply.github.com>
Date:   Wed Nov 20 00:40:45 2019 +0100

    [systeminfo] Upgrade jna/oshi due to "Failed to read process file" spam on raspberry. (#6422)

    Signed-off-by: Alexander Falkenstern <alexander.falkenstern@gmail.com>

commit b795ef250c089886b82c1a821a7d7f20fb11f05d
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Tue Nov 19 19:01:14 2019 +0100

    upgrade hap to 1.2.0 (#6223)

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 15dd37844cef0478fce6e5862ff19084e687cab3
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Tue Nov 19 18:59:20 2019 +0100

    [mqtt] add QoS to channel config (#6246)

    * add QoS to channel config

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 0f658f09126e04702a0b0b24dbeebac87c5b7c02
Author: Nicolai Grødum <grodum@gmail.com>
Date:   Tue Nov 19 18:52:12 2019 +0100

    [hueemulation] Fix Amazon Echo device discovery (#6402)

    * Hueemulation does not work with Echo devices that now send "Content-Type" header in GET requests. Jetty simply returns 415 instead of ignoring the superfluous header. This is a simple workaround - a filter that removes it.

    Signed-off-by: Nicolai Grødum <git@grodum.org>

commit dafb4ad0a1dd8ddf07b4fd9ee7e862760b986844
Author: Noppes123 <justClouds@users.noreply.github.com>
Date:   Tue Nov 19 17:32:41 2019 +0100

    [daikin] Log non-handled commands as debug message #6413 (#6415)

    * Log non-handled commands as debug message

    Signed-off-by: Ron Moerman <ron@crazyelectron.io>

commit f43d1e79ac933ef0e1106cf51cd5299ea6ccdd1d
Author: Pascal Larin <plarin@gmail.com>
Date:   Tue Nov 19 11:29:20 2019 -0500

    Both Gateway and Thermostat handlers could stay uninitialized. (#6420)

    Signed-off-by: chaton78 <plarin@gmail.com>

commit bfb60a13146e2b9decc5d7cb098a6a7326e135d4
Author: Hans-Jörg Merk <hans-joerg.merk@t-online.de>
Date:   Tue Nov 19 17:28:30 2019 +0100

    [wemo] Add DimmerSwitch support and update README (#6304)

    Signed-off-by: Hans-Jörg Merk <hans-joerg.merk@t-online.de>

commit 5dc1db799f8255fc067eb351caa9ee1efc0b11ca
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Mon Nov 18 16:43:22 2019 +0100

    [mqtt] make rollershutter symmetric (#6244)

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 25add3cf1a289c80cc0748a5b3df1b04e8064427
Author: flo-02-mu <46089838+flo-02-mu@users.noreply.github.com>
Date:   Mon Nov 18 07:50:31 2019 +0100

    [tradfri] Update Californium to 2.0.0-RC1 (#6405)

    Signed-off-by: flo_02_mu <f.l.o.mueller@web.de>

commit 01901db77b624f4b3585c57fdf08baa731e9e4f5
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Sun Nov 17 21:43:09 2019 +0100

    Remodel discovery services as 'ThingHandlerService' (#6396)

    * Remodel discovery services as 'ThingHandlerService' instead of registration via 'HandlerFactory'

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit cb068700f1259c8baa20803f07ff6a51c50ebf0b
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Sun Nov 17 15:34:43 2019 +0100

    Added more details and example of configuration for 'shownotifiation' channel (#6409)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 0cb6ab762f1328411725f0d731f438a3de0cde20
Author: Wouter Born <github@maindrain.net>
Date:   Sun Nov 17 15:23:58 2019 +0100

    Resolve itests runbundles (#6407)

    Related to openhab/openhab-core#1218

    Signed-off-by: Wouter Born <github@maindrain.net>

commit 99e8cbb39c313719a7aef04bddbf46a371611b29
Author: Tobias Meyer <tobiuhg@gmail.com>
Date:   Sat Nov 16 21:29:09 2019 +0100

    suggested fix for #6279 , using the right unscaled values for EEP A5-02-20 and A5-02-30 (#6363)

    Signed-off-by: tobiwan88 <tobiuhg@gmail.com>

commit 223c14768cdb7a6990b1e40da6ce1e3eb29e65de
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Sat Nov 16 17:33:51 2019 +0100

    Fix ServiceLoader (#6404)

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 20f4e5deb3d31f92ac9c695d5b5206ad8c33c00f
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Sat Nov 16 15:54:11 2019 +0100

    Removed use of 'bundleContext' from 'BaseThingHandler' as it is deprecated (#6395)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 1dd03237a3939ce1c98bb72744f70d6178039b0a
Author: Michael Geramb <mail@michael-geramb.at>
Date:   Sat Nov 16 15:09:20 2019 +0100

    [amazonechocontrol] Announcement volume (#6097)

    Signed-off-by: Michael Geramb <mail@michael-geramb.at> (github: mgeramb)

commit 56b882ba93d126623f7840e8c1b2925242c6738b
Author: Bob A <bobadair@users.noreply.github.com>
Date:   Fri Nov 15 16:12:55 2019 -0500

    [lutron] Add support for QS Wallbox Closure Interface (#6393)

    * Add discovery for LQSE-4M-D motor controller

    Signed-off-by: Bob Adair <bob.github@att.net>

commit 37617c0b73c0ef49d60b1aca16910c7ca5660f4e
Author: Wouter Born <github@maindrain.net>
Date:   Fri Nov 15 17:02:32 2019 +0100

    Parameterized logging fixes (#6394)

    Make sure Throwables are not be substituted into log messages so they can be formatted according to the logging configuration.

    Signed-off-by: Wouter Born <github@maindrain.net>

commit 12b2190d1e31b67e8f23c03e8b9cecd0f571f326
Author: Martin van Wingerden <martin@martinvw.nl>
Date:   Thu Nov 14 10:52:58 2019 +0100

    [rfxcom] Resolved #6285, following suggestions of @mjagdis (#6366)

    Signed-off-by: Martin van Wingerden <martin@martinvw.nl>

commit ecbb4e583b59167e328e7029db2ea94d766d207e
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Thu Nov 14 10:52:18 2019 +0100

    Fixed wrong port ranges (#6383)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 6af1c5aa038b6f2208d6705969f0f2bc4683c17d
Author: Martin van Wingerden <martin@martinvw.nl>
Date:   Thu Nov 14 10:50:02 2019 +0100

    [rfxcom] Support for RFXSensor (#2980)

    * Added a device-state to allow doing calculations given earlier messages received by the same device
    * Worked on SAT findings
    * Corrected non-standard new-lines after params in the docblocks
    * correct type id for lucci fan

    Signed-off-by: Martin van Wingerden <martin@martinvw.nl>

commit 2c8072cfa8737e5d4fdb66150a48ba45ed3e7d2d
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Thu Nov 14 09:11:34 2019 +0100

    Fixed failing build related to openhab/openhab-core#1209 (#6392)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 188e19d962e771b6c9b20396e7d36576c5a4e4db
Author: Bob A <bobadair@users.noreply.github.com>
Date:   Thu Nov 14 03:07:44 2019 -0500

    [lutron] Add support for Palladiom keypads (#6324)

    Signed-off-by: Bob Adair <bob.github@att.net>

commit 5d048ac62fafa75197a1f8ae59478a405f8e3803
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Wed Nov 13 23:57:30 2019 +0100

    [yamahareceiver] There is no unit dB (#6390)

    Bug due to changes in #6356

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit adae63a45d7db902accab66c40529129922f85bd
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Wed Nov 13 16:09:09 2019 +0100

    Improved ESH-INF labels to comply with casing rules (#6356)

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit 74a0583fda9e11620ae5e9e0595efde897bbd3d5
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Wed Nov 13 13:21:42 2019 +0100

    [spotify] Improve performance of handling data (#6355)

    When Spotify returns a 204. It means it doesn't return any data. This can happen after a certain time of inactivity.
    When this is returned it doesn't make sense to update the states or poll for playlists either unless the status is unknown.
    For devices update only if has data or if any device has state unknown.
    Also let playlist refresh only once per hour or when an explicit refresh of the channel is given will it update on the next poll.

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit d2f521be1fce5c7c3dd82beb997c23fdf054d30f
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Wed Nov 13 12:17:57 2019 +0100

    [networkupstools] Fix typo and misc log (#6381)

    - Constant MAX_RETRIES contained a unintended space.
    - Improved logging to log only when relevant.

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit a8838781db189994ef8779d85bf8f33c9ae4532c
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Wed Nov 13 12:17:00 2019 +0100

    [infrastructure] move /lib to remote (#6183)

    * leap motion
    * netatmo
    * orvibo
    * tado
    * tellstick
    * zoneminder
    * zway
    * homekit

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 197eae5584d189ec01f72cc5545c628b7b30edc4
Author: Paul Smedley <paul@smedley.id.au>
Date:   Wed Nov 13 20:08:59 2019 +1030

    [daikin] Remove 'advanced=true' for fan speed and swing (#6385)

    Signed-off-by: Paul Smedley <paul@smedley.id.au>

commit d15538c6a071c03c32781c85afb2ca06f8e6a913
Author: Wouter Born <github@maindrain.net>
Date:   Wed Nov 13 08:56:37 2019 +0100

    [lifx] Add support for LIFX Candle (#6384)

    Adds the LIFX Candle to the Product enum so it can be discovered and the binding can enable the supported features.

    Signed-off-by: Wouter Born <github@maindrain.net>

commit 579f3b29a262f0e88e52dd5dd3d63e59f623d3e8
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Wed Nov 13 01:36:59 2019 +0100

    [mqtt] fix refresh/restoreOnStartup (#6203)

    * fix refresh

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 414431c1b14b6359000ef0d880c0d360d65a6875
Author: Pawel Pieczul <pieczul@gmail.com>
Date:   Tue Nov 12 22:15:59 2019 +0100

    [lifx] Added support for LIFX Tile and Tile Effects (#6180)

    Signed-off-by: Pawel Pieczul <pieczul@gmail.com>

commit 4f784a1cdb3cf29e01b140f4fbda718f663df815
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date:   Tue Nov 12 12:25:28 2019 +0100

    Updated binding xml schema locations to openhab (#6376)

    Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

commit 6bd7b3720d84f66abd25ca30c56d38ddbdb05c31
Author: ZzetT <6074452+ZzetT@users.noreply.github.com>
Date:   Tue Nov 12 10:22:53 2019 +0100

    use the username of the user who replied to the query and not the one who sent the query (#6379)

    Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

commit 420140877618dfa05f12ac5530b4923e19285af4
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date:   Mon Nov 11 22:21:38 2019 +0100

    [dsmr] integer parsing errors should be catched (#6378)

    When parsing integer values these should be catched for errors and re-thrown.
    Because the re-thrown ParseException is correctly handled and doesn't pollute the log.
    This catching was missing from the CosemHexString.

    Errors can occur due to garbled data. These are simply ignored and should not pollute the log.

    Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>

commit 489e40346fd4cbadfe87d13ab7899fbb1ab9a639
Author: Wouter Born <github@maindrain.net>
Date:   Mon Nov 11 20:01:58 2019 +0100

    Upgrade bnd to 4.3.0 (#6372)

    For bnd 4.3.0 release notes, see:

    https://github.com/bndtools/bnd/wiki/Changes-in-4.3.0

    Also note:

        The Bnd Maven plugins are now marked thread safe and can be used with -T.

    It seems to work well so far as long as the features are build after the bundles so I've added the bundles BOM as dependency to the features POM.
    We still need to make SAT thread safe (openhab/static-code-analysis#200).

    When disabling SAT you can build using one thread per processor core by executing:

        mvn clean install -DskipChecks -T 1C

    This significantly speeds up Maven builds and puts all your processor cores to good use. :-)

    Signed-off-by: Wouter Born <github@maindrain.net>

commit 401c523f24d84f9bb5b9e7e60c8047c47dfcc74b
Author: Konstantin Polihronov <polychronov@gmail.com>
Date:   Mon Nov 11 20:30:07 2019 +0200

    Fix quotes in code snippets of README.MD (#6375)

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>

commit 765af91432828d20a7c5894124eecc6420f6dc82
Author: pdcemulator <20071350+pdcemulator@users.noreply.github.com>
Date:   Mon Nov 11 14:56:19 2019 +0100

    [sonos] improve docs, commands for control channel (#6370)

    * Fixed Sonos control channel commands

    Signed-off-by: Fabian Woelk <fawel@gmx.de>

commit eb6d591d1a348bc6c7ab6fe23f2072e847d11aab
Author: Wouter Born <github@maindrain.net>
Date:   Sun Nov 10 22:15:50 2019 +0100

    [chromecast] Update API lib to 0.11.2 (#6367)

    Fixes the following exceptions:

    ```
    org.codehaus.jackson.map.JsonMappingException: Could not resolve type id 'MULTIZONE_STATUS' into a subtype of [simple type, class su.litvak.chromecast.api.v2.StandardResponse]
    ```

    Signed-off-by: Wouter Born <github@maindrain.net>

commit 0542a750cd7589c63610536958e047dd99131a3a
Author: Wouter Born <github@maindrain.net>
Date:   Sun Nov 10 17:04:38 2019 +0100

    Upgrade to Karaf 4.2.7 (#6368)

    For Karaf 4.2.7 release notes, see:

    https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12345539

    Also updates dependencies:

    * Jetty 9.4.20.v20190813
    * JNA 5.4.0 (used by most add-ons)

    Signed-off-by: Wouter Born <github@maindrain.net>

commit 4d28bb5c9130bcd154d01c8377a3b6fcb16f3fb4
Author: J-N-K <J-N-K@users.noreply.github.com>
Date:   Sun Nov 10 16:59:49 2019 +0100

    fix crappy bluez implementation (#6369)

    Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

commit 015b482fe9268624dde46a616d3018573a74b04e
Author: Wouter Born <github@maindrain.net>
Date:   Sun Nov 10 02:27:01 2019 +0100

    [plugwise] Use constructor injection (#6365)

    Signed-off-by: Wouter Born <github@maindrain.net>

commit abeee78557bbd951da018b34b6bc2d63128bc300
Author: Wouter Born <github@maindrain.net>
Date:   Sat Nov 9 09:38:58 2019 +0100

    Resolve itest.bndrun for Jollyday downgrade (#6359)

    * Resolve itest.bndrun for Jollyday downgrade

    Signed-off-by: Wouter Born <github@maindrain.net>

commit d4a4f494c73c33dfbf4ad25e83a5c37afcc68ac4
Author: Michael Weisendorf <michael@familie-martens.de>
Date:   Fri Nov 8 18:07:40 2019 +0100

    Update README.md (#6225)

    Brought in a hint for a larger buffersize as I ran into crashed after only 7 remotes and 47 commands.
    The led parameter needed some explanations, as "I" for internal might be the better default.

    Signed-off-by:  Michael Martens <Michael@familie-martens.de>

commit 086c02227de1c5d4402d1a275b6d2f0dab3b18ab
Author: Sebastian Prehn <2531264+sprehn@users.noreply.github.com>
Date:   Fri Nov 8 13:01:43 2019 +0100

    Fix TV stuck in Connecting state. (#6358)

    This fixes an issue with the bindi…
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Jan 20, 2020
@vkoop @DaanMeijer
[yeelight] Fix autodiscovery with multiple network interfaces. (openh…
215d903 
…ab#6643) (openhab#6644)

Signed-off-by: Viktor Koop <viktor.koop@gmail.com>
tmrobert8 pushed a commit to tmrobert8/openhab-addons that referenced this pull request Jan 21, 2020
@vkoop @tmrobert8
[yeelight] Fix autodiscovery with multiple network interfaces. (openh…
4b51f14 
…ab#6643) (openhab#6644)

Signed-off-by: Viktor Koop <viktor.koop@gmail.com>
Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
leluna pushed a commit to leluna/openhab2-addons that referenced this pull request Mar 21, 2020
@vkoop @leluna
[yeelight] Fix autodiscovery with multiple network interfaces. (openh…
10606c9 
…ab#6643) (openhab#6644)

Signed-off-by: Viktor Koop <viktor.koop@gmail.com>
Signed-off-by: leluna <hengrui.jiang@googlemail.com>
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
@vkoop @Hans-Reiner
[yeelight] Fix autodiscovery with multiple network interfaces. (openh…
00f9124 
…ab#6643) (openhab#6644)

Signed-off-by: Viktor Koop <viktor.koop@gmail.com>
Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
ramack pushed a commit to ramack/openhab-addons that referenced this pull request May 31, 2020
@vkoop @ramack
[yeelight] Fix autodiscovery with multiple network interfaces. (openh…
04c746a 
…ab#6643) (openhab#6644)

Signed-off-by: Viktor Koop <viktor.koop@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claell claell Awaiting requested review from claell

@Hilbrand Hilbrand Awaiting requested review from Hilbrand

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vkoop @TravisBuddy @darkcheater @Hilbrand @kaikreuzer