[systeminfo] Make getSwap* methods able to return 0 #7168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the null returns for getSwapTotal(), getSwapAvailable() and getSwapUsed(). This makes it obey the specifications in the SysteminfoInterface JavaDoc. Also changes getSwapAvailablePercent() and getSwapUsedPercent() to make variable naming more consistent. Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
Travis tests have failedHey @pacive, 1st BuildExpand here### 2nd Build Expand here |
Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
Travis tests were successfulHey @pacive, |
wborn
approved these changes
Mar 15, 2020
|
I might continue to make some small updates this binding in order to learn some more. I noticed that it uses some deprecated methods in OSHI that I could update (a lot of warnings when compiling). Should I open an issue for that first, or can I just make a new PR? |
|
Fixing the deprecations would also be appreciated! You can submit PRs directly though creating issues for this is always helpful if you won't create the PR soon. It may prevent multiple PRs that solve the same issue if you also mention in the issue that you're working on it. So it may save yourself/others wasting their time causing frustration. |
kaikreuzer
added
the
bug
leluna
pushed a commit
to leluna/openhab2-addons
that referenced
this pull request
Mar 21, 2020
Make getSwap* methods able to return 0 Remove the null returns for getSwapTotal(), getSwapAvailable() and getSwapUsed(). This makes it obey the specifications in the SysteminfoInterface JavaDoc. Also changes getSwapAvailablePercent() and getSwapUsedPercent() to make variable naming more consistent. Signed-off-by: Anders Alfredsson <andersb86@gmail.com> Signed-off-by: leluna <hengrui.jiang@googlemail.com>
Hans-Reiner
pushed a commit
to Hans-Reiner/openhab2-addons
that referenced
this pull request
Apr 11, 2020
Make getSwap* methods able to return 0 Remove the null returns for getSwapTotal(), getSwapAvailable() and getSwapUsed(). This makes it obey the specifications in the SysteminfoInterface JavaDoc. Also changes getSwapAvailablePercent() and getSwapUsedPercent() to make variable naming more consistent. Signed-off-by: Anders Alfredsson <andersb86@gmail.com> Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
May 29, 2020
Make getSwap* methods able to return 0 Remove the null returns for getSwapTotal(), getSwapAvailable() and getSwapUsed(). This makes it obey the specifications in the SysteminfoInterface JavaDoc. Also changes getSwapAvailablePercent() and getSwapUsedPercent() to make variable naming more consistent. Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
Make getSwap* methods able to return 0 Remove the null returns for getSwapTotal(), getSwapAvailable() and getSwapUsed(). This makes it obey the specifications in the SysteminfoInterface JavaDoc. Also changes getSwapAvailablePercent() and getSwapUsedPercent() to make variable naming more consistent. Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
Make getSwap* methods able to return 0 Remove the null returns for getSwapTotal(), getSwapAvailable() and getSwapUsed(). This makes it obey the specifications in the SysteminfoInterface JavaDoc. Also changes getSwapAvailablePercent() and getSwapUsedPercent() to make variable naming more consistent. Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Make getSwap* methods able to return 0 Remove the null returns for getSwapTotal(), getSwapAvailable() and getSwapUsed(). This makes it obey the specifications in the SysteminfoInterface JavaDoc. Also changes getSwapAvailablePercent() and getSwapUsedPercent() to make variable naming more consistent. Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Make getSwap* methods able to return 0 Remove the null returns for getSwapTotal(), getSwapAvailable() and getSwapUsed(). This makes it obey the specifications in the SysteminfoInterface JavaDoc. Also changes getSwapAvailablePercent() and getSwapUsedPercent() to make variable naming more consistent. Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Make getSwap* methods able to return 0 Remove the null returns for getSwapTotal(), getSwapAvailable() and getSwapUsed(). This makes it obey the specifications in the SysteminfoInterface JavaDoc. Also changes getSwapAvailablePercent() and getSwapUsedPercent() to make variable naming more consistent. Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Make getSwap* methods able to return 0 Remove the null returns for getSwapTotal(), getSwapAvailable() and getSwapUsed(). This makes it obey the specifications in the SysteminfoInterface JavaDoc. Also changes getSwapAvailablePercent() and getSwapUsedPercent() to make variable naming more consistent. Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
Make getSwap* methods able to return 0 Remove the null returns for getSwapTotal(), getSwapAvailable() and getSwapUsed(). This makes it obey the specifications in the SysteminfoInterface JavaDoc. Also changes getSwapAvailablePercent() and getSwapUsedPercent() to make variable naming more consistent. Signed-off-by: Anders Alfredsson <andersb86@gmail.com> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Make getSwap* methods able to return 0 Remove the null returns for getSwapTotal(), getSwapAvailable() and getSwapUsed(). This makes it obey the specifications in the SysteminfoInterface JavaDoc. Also changes getSwapAvailablePercent() and getSwapUsedPercent() to make variable naming more consistent. Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the null returns for getSwapTotal(), getSwapAvailable() and getSwapUsed(). This makes it obey the specifications in the SysteminfoInterface JavaDoc. Also changes getSwapAvailablePercent() and getSwapUsedPercent() to make variable naming more consistent.
Fixes #6983
When the getSwap* methods return null the channel and connected Item gets set to UNDEF. This fix makes it able to be set to 0 e.g. shortly after a system reboot, when no pages have been swapped yet.
Signed-off-by: Anders Alfredsson andersb86@gmail.com