Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tellstick] Fix auto-detect handling for Rain and Wind devices #7172

Merged
merged 3 commits into from Mar 17, 2020

Conversation

jannegpriv
Copy link
Contributor

@jannegpriv jannegpriv commented Mar 15, 2020

This PR implements a correct auto-detect handling for Rain and Wind devices.
It also uses the correct measurement types for the different channel types.

README has been updated.

Fixes #7171

I've tested this jar-file successfully in my own production environment.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
@TravisBuddy
Copy link

Travis tests were successful

Hey @jannegpriv,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

</channel-type>

<channel-type id="raintotal">
<item-type>Number</item-type>
<label>Total Rain</label>
<description>Total rain</description>
<state pattern="%d" readOnly="true">
<state pattern="%d mm" readOnly="true">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are going to use units I would suggest using UoM for this as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I will fix that too.

…state to use %unit%.

 Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
@TravisBuddy
Copy link

Travis tests were successful

Hey @jannegpriv,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

| Channel Type ID | Item Type | Description |
|-----------------|--------------|------------------------------|
| windgust | Number:Speed | The current peak wind gust. |
| winddirection | Number | The current wind direction. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| winddirection | Number | The current wind direction. |
| winddirection | Number:Angle | The current wind direction. |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated README with correct measurment units.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
@TravisBuddy
Copy link

Travis tests were successful

Hey @jannegpriv,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@cpmeister
Copy link
Contributor

@jannegpriv Can you give me a signoff so I can merge this?

@jannegpriv
Copy link
Contributor Author

@jannegpriv Can you give me a signoff so I can merge this?

I'm kind of new to this, I've signed off my commits but is there somewhere else I should signoff?

@cpmeister
Copy link
Contributor

Nvm, I'm still new to this as well. Couldn't see your signoff in your commit messages but just found them. What you did is just fine.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually verified signoff

@cpmeister cpmeister merged commit bfff3d4 into openhab:2.5.x Mar 17, 2020
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of an add-on label Mar 18, 2020
@kaikreuzer kaikreuzer added this to the 2.5.3 milestone Mar 18, 2020
leluna pushed a commit to leluna/openhab2-addons that referenced this pull request Mar 21, 2020
…ab#7172)

* Fixes openhab#7171.
Updated humidity and rain channels to use measurement units, changed state to use %unit%.
Updated README with correct measurement units.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Signed-off-by: leluna <hengrui.jiang@googlemail.com>
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
…ab#7172)

* Fixes openhab#7171.
Updated humidity and rain channels to use measurement units, changed state to use %unit%.
Updated README with correct measurement units.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
…ab#7172)

* Fixes openhab#7171.
Updated humidity and rain channels to use measurement units, changed state to use %unit%.
Updated README with correct measurement units.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
…ab#7172)

* Fixes openhab#7171.
Updated humidity and rain channels to use measurement units, changed state to use %unit%.
Updated README with correct measurement units.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
…ab#7172)

* Fixes openhab#7171.
Updated humidity and rain channels to use measurement units, changed state to use %unit%.
Updated README with correct measurement units.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
…ab#7172)

* Fixes openhab#7171.
Updated humidity and rain channels to use measurement units, changed state to use %unit%.
Updated README with correct measurement units.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…ab#7172)

* Fixes openhab#7171.
Updated humidity and rain channels to use measurement units, changed state to use %unit%.
Updated README with correct measurement units.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…ab#7172)

* Fixes openhab#7171.
Updated humidity and rain channels to use measurement units, changed state to use %unit%.
Updated README with correct measurement units.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…ab#7172)

* Fixes openhab#7171.
Updated humidity and rain channels to use measurement units, changed state to use %unit%.
Updated README with correct measurement units.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…ab#7172)

* Fixes openhab#7171.
Updated humidity and rain channels to use measurement units, changed state to use %unit%.
Updated README with correct measurement units.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
…ab#7172)

* Fixes openhab#7171.
Updated humidity and rain channels to use measurement units, changed state to use %unit%.
Updated README with correct measurement units.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
…ab#7172)

* Fixes openhab#7171.
Updated humidity and rain channels to use measurement units, changed state to use %unit%.
Updated README with correct measurement units.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tellstick] Binding cannot handle Wind nor Rain detectors
4 participants