New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tellstick] Fix auto-detect handling for Rain and Wind devices #7172
Conversation
Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Travis tests were successfulHey @jannegpriv, |
</channel-type> | ||
|
||
<channel-type id="raintotal"> | ||
<item-type>Number</item-type> | ||
<label>Total Rain</label> | ||
<description>Total rain</description> | ||
<state pattern="%d" readOnly="true"> | ||
<state pattern="%d mm" readOnly="true"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are going to use units I would suggest using UoM for this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I will fix that too.
…state to use %unit%. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Travis tests were successfulHey @jannegpriv, |
| Channel Type ID | Item Type | Description | | ||
|-----------------|--------------|------------------------------| | ||
| windgust | Number:Speed | The current peak wind gust. | | ||
| winddirection | Number | The current wind direction. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| winddirection | Number | The current wind direction. | | |
| winddirection | Number:Angle | The current wind direction. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated README with correct measurment units.
Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Travis tests were successfulHey @jannegpriv, |
@jannegpriv Can you give me a signoff so I can merge this? |
I'm kind of new to this, I've signed off my commits but is there somewhere else I should signoff? |
Nvm, I'm still new to this as well. Couldn't see your signoff in your commit messages but just found them. What you did is just fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually verified signoff
…ab#7172) * Fixes openhab#7171. Updated humidity and rain channels to use measurement units, changed state to use %unit%. Updated README with correct measurement units. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> Signed-off-by: leluna <hengrui.jiang@googlemail.com>
…ab#7172) * Fixes openhab#7171. Updated humidity and rain channels to use measurement units, changed state to use %unit%. Updated README with correct measurement units. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
…ab#7172) * Fixes openhab#7171. Updated humidity and rain channels to use measurement units, changed state to use %unit%. Updated README with correct measurement units. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> Signed-off-by: Eugen Freiter <freiter@gmx.de>
…ab#7172) * Fixes openhab#7171. Updated humidity and rain channels to use measurement units, changed state to use %unit%. Updated README with correct measurement units. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
…ab#7172) * Fixes openhab#7171. Updated humidity and rain channels to use measurement units, changed state to use %unit%. Updated README with correct measurement units. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
…ab#7172) * Fixes openhab#7171. Updated humidity and rain channels to use measurement units, changed state to use %unit%. Updated README with correct measurement units. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
…ab#7172) * Fixes openhab#7171. Updated humidity and rain channels to use measurement units, changed state to use %unit%. Updated README with correct measurement units. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
…ab#7172) * Fixes openhab#7171. Updated humidity and rain channels to use measurement units, changed state to use %unit%. Updated README with correct measurement units. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
…ab#7172) * Fixes openhab#7171. Updated humidity and rain channels to use measurement units, changed state to use %unit%. Updated README with correct measurement units. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
…ab#7172) * Fixes openhab#7171. Updated humidity and rain channels to use measurement units, changed state to use %unit%. Updated README with correct measurement units. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
…ab#7172) * Fixes openhab#7171. Updated humidity and rain channels to use measurement units, changed state to use %unit%. Updated README with correct measurement units. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
…ab#7172) * Fixes openhab#7171. Updated humidity and rain channels to use measurement units, changed state to use %unit%. Updated README with correct measurement units. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
This PR implements a correct auto-detect handling for Rain and Wind devices.
It also uses the correct measurement types for the different channel types.
README has been updated.
Fixes #7171
I've tested this jar-file successfully in my own production environment.