Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[miio] jsonify command handling #7361

Merged
merged 1 commit into from Apr 13, 2020
Merged

[miio] jsonify command handling #7361

merged 1 commit into from Apr 13, 2020

Conversation

marcelrv
Copy link
Contributor

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

@marcelrv
[miio] jsonify command handling
cd92a25 
* Allow for more flexible parameters setting.
* Prep to use gson to write database files (for future unsupported
handler)
* Apply eclipse formatter to all json db files
* Lower log level during initiation
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1380

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv requested a review from cpmeister April 13, 2020 20:45
@TravisBuddy
Copy link

Travis tests were successful

Hey @marcelrv,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister
cpmeister approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 18851c5 into openhab:2.5.x Apr 13, 2020
@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Apr 13, 2020
@cpmeister cpmeister added this to the 2.5.4 milestone Apr 13, 2020
@marcelrv marcelrv deleted the miio-jsonify_update branch April 14, 2020 07:05
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
@marcelrv
[miio] jsonify command handling (openhab#7361)
f2effe4 
* Allow for more flexible parameters setting.
* Prep to use gson to write database files (for future unsupported
handler)
* Apply eclipse formatter to all json db files
* Lower log level during initiation
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1380

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
@marcelrv @markus7017
[miio] jsonify command handling (openhab#7361)
13a6cef 
* Allow for more flexible parameters setting.
* Prep to use gson to write database files (for future unsupported
handler)
* Apply eclipse formatter to all json db files
* Lower log level during initiation
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1380

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@marcelrv @LoungeFlyZ
[miio] jsonify command handling (openhab#7361)
706258e 
* Allow for more flexible parameters setting.
* Prep to use gson to write database files (for future unsupported
handler)
* Apply eclipse formatter to all json db files
* Lower log level during initiation
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1380

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@marcelrv @J-N-K
[miio] jsonify command handling (openhab#7361)
6f1d875 
* Allow for more flexible parameters setting.
* Prep to use gson to write database files (for future unsupported
handler)
* Apply eclipse formatter to all json db files
* Lower log level during initiation
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1380

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@marcelrv @CSchlipp
[miio] jsonify command handling (openhab#7361)
39ac507 
* Allow for more flexible parameters setting.
* Prep to use gson to write database files (for future unsupported
handler)
* Apply eclipse formatter to all json db files
* Lower log level during initiation
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1380

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@marcelrv @andrewfg
[miio] jsonify command handling (openhab#7361)
c5cfd31 
* Allow for more flexible parameters setting.
* Prep to use gson to write database files (for future unsupported
handler)
* Apply eclipse formatter to all json db files
* Lower log level during initiation
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1380

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@marcelrv @andrewfg
[miio] jsonify command handling (openhab#7361)
389d716 
* Allow for more flexible parameters setting.
* Prep to use gson to write database files (for future unsupported
handler)
* Apply eclipse formatter to all json db files
* Lower log level during initiation
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1380

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@marcelrv @andrewfg
[miio] jsonify command handling (openhab#7361)
f93a330 
* Allow for more flexible parameters setting.
* Prep to use gson to write database files (for future unsupported
handler)
* Apply eclipse formatter to all json db files
* Lower log level during initiation
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1380

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@marcelrv @andrewfg
[miio] jsonify command handling (openhab#7361)
453db80 
* Allow for more flexible parameters setting.
* Prep to use gson to write database files (for future unsupported
handler)
* Apply eclipse formatter to all json db files
* Lower log level during initiation
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1380

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@marcelrv @DaanMeijer
[miio] jsonify command handling (openhab#7361)
39bdebe 
* Allow for more flexible parameters setting.
* Prep to use gson to write database files (for future unsupported
handler)
* Apply eclipse formatter to all json db files
* Lower log level during initiation
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1380

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@marcelrv @markus7017
[miio] jsonify command handling (openhab#7361)
f53983f 
* Allow for more flexible parameters setting.
* Prep to use gson to write database files (for future unsupported
handler)
* Apply eclipse formatter to all json db files
* Lower log level during initiation
https://community.openhab.org/t/xiaomi-robot-vacuum-binding/31317/1380

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcelrv @TravisBuddy @cpmeister