Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[somfytahoma] Add support for the dimmer light #8323

Merged
merged 3 commits into from Aug 22, 2020
Merged

[somfytahoma] Add support for the dimmer light #8323

merged 3 commits into from Aug 22, 2020

Conversation

octa22
Copy link
Contributor

@octa22 octa22 commented Aug 20, 2020 •
edited

This PR adds support for the dimmer light thing, and exterior heating system
The functionality has been confirmed by community -
https://community.openhab.org/t/tahoma-binding-setting-to-dim-leds/103825/15
closes
#8313

@octa22 octa22 added the enhancement An enhancement or new feature for an existing add-on label Aug 20, 2020
@octa22 octa22 changed the title [somfytahoma] Add support for the dimmer light [somfytahoma] Adds support for the dimmer light Aug 20, 2020
@octa22 octa22 changed the title [somfytahoma] Adds support for the dimmer light [somfytahoma] Add support for the dimmer light Aug 20, 2020
@octa22
[somfytahoma] Add support for the dimmer light
176a413 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
@TravisBuddy
Copy link

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@octa22
[somfytahoma] add support for the exterior heating system thing
b901a98 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
@TravisBuddy
Copy link

Travis tests have failed

Hey @octa22,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

fwolter
fwolter requested changes Aug 21, 2020
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some formatting issues. You can view them with mvn spotless:check -Dspotless.check.skip=false and fix them with mvn spotless:apply.

bundles/org.openhab.binding.somfytahoma/src/main/resources/ESH-INF/thing/channels.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.somfytahoma/src/main/resources/ESH-INF/thing/dimmerlight.xml Outdated Show resolved Hide resolved
@octa22
[somfytahoma] fixes based on the PR code review
f124c26 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
@TravisBuddy
Copy link

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@fwolter fwolter merged commit 986941d into openhab:2.5.x Aug 22, 2020
@fwolter fwolter added this to the 2.5.8 milestone Aug 22, 2020
taboneclayton pushed a commit to taboneclayton/openhab-addons that referenced this pull request Aug 23, 2020
@octa22 @taboneclayton
[somfytahoma] Add support for the dimmer light (openhab#8323)
7f237d5 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
Signed-off-by: Clayton Tabone <taboneclayton@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@octa22 @andrewfg
[somfytahoma] Add support for the dimmer light (openhab#8323)
ad9b584 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@octa22 @andrewfg
[somfytahoma] Add support for the dimmer light (openhab#8323)
7bca4d3 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@octa22 @andrewfg
[somfytahoma] Add support for the dimmer light (openhab#8323)
39fe2e6 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@octa22 @andrewfg
[somfytahoma] Add support for the dimmer light (openhab#8323)
7d3ebe7 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@octa22 @DaanMeijer
[somfytahoma] Add support for the dimmer light (openhab#8323)
e9e82be 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@octa22 @CSchlipp
[somfytahoma] Add support for the dimmer light (openhab#8323)
45d2c6f 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@octa22 @markus7017
[somfytahoma] Add support for the dimmer light (openhab#8323)
8b16a54 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@octa22 @TravisBuddy @fwolter