-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions of the voice services (KS, STT, TTS) #1063
Comments
I could also extend the Text-To-Speak service with a property "audioSinkEmbedded". |
If I implement a specific dialog processing in the Snips binding, I can avoid all these changes. So I think there are not a requirement for Snips integration. |
One alternative would be keep untouched STTService and TTSService and define new services. |
This reminds me of a similar proposal (eclipse-archived/smarthome#1081 (comment)) from 3.5 years ago distinguishing "external" and "local" STT services, i.e. handling the audio part externally or locally. Never actually pursued it (I abandoned the idea) but referring to it since it's related to this issue. |
Yes, we are clearly on the same subject, even if your focus was on the TTS service. |
I close the subject, finally I don't need any of these changes to integrate Snips in a binding. |
* Update events.md * Update events.md Fix typo.
The current Key Spotting service and Speak-To-Text service are requiring an openHAB audio source as input. Snips API give the opportunity to create a KS service and a STT service but the audio source is "hidden" and audio files cannot be retrieved.
So I would like to extend the current KS and STT services to add a property we could named "audioSourceEmbedded".
In case a KS or STT service defines this property to true, the openHAB dialog processor will call these services without considering any audio source.
Of course, it requires a breaking change of the current voice API. But as we have until now no STT or KS services included in the openHAB distribution, I don't think it is a problem. It also requires a little change in the openHAB dialog processor which is a feature implemented but not used in the openHAB distribution.
This change is a requirement to integrate Snips ASR as a KS and STT service in openHAB.
Is there any objection ?
The text was updated successfully, but these errors were encountered: