Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove state description when loading an item with a removed pattern #4068

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Remove state description when loading an item with a removed pattern #4068

merged 2 commits into from
Jan 27, 2024

Conversation

lolodomo
Copy link
Contributor

Fix openhab/openhab-webui#2251

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo requested a review from a team as a code owner January 27, 2024 13:59
@J-N-K
Copy link
Member

J-N-K commented Jan 27, 2024

LGTM, can you add a test for that?

@lolodomo
Copy link
Contributor Author

can you add a test for that?

I see already existing tests, so yes I should be able to add one.

@lolodomo
Extended integration test testSquareBracketsInFormat
ba72549 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Copy link
Contributor Author

Integration test extended.

J-N-K
J-N-K approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Jan 27, 2024
@J-N-K J-N-K added this to the 4.2 milestone Jan 27, 2024
@J-N-K J-N-K merged commit a957122 into openhab:main Jan 27, 2024
3 checks passed
@lolodomo lolodomo deleted the fix_remove_state_descr branch January 27, 2024 17:13
@dilyanpalauzov dilyanpalauzov mentioned this pull request Jan 27, 2024
Closed
5 tasks
@lolodomo
Copy link
Contributor Author

I would suggest to cherry pick this fix in 4.1.x branch.

J-N-K added a commit that referenced this pull request Jan 27, 2024
@J-N-K
Remove state description when loading an item with a removed pattern (#…
28ed671 
…4068)

* Remove state description when loading an item with a removed pattern

Fix openhab/openhab-webui#2251

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

* Extended integration test testSquareBracketsInFormat

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

---------

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
(cherry picked from commit a957122)
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the patch A PR that has been cherry-picked to a patch release branch label Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.2
2 participants
@lolodomo @J-N-K