prevent System.exit() calls #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
wborn
approved these changes
Oct 1, 2018
wborn
added a commit
to wborn/openhab-core
that referenced
this pull request
Apr 17, 2019
Xtext 2.17 allows for configuring the LanguageServer exit behavior so the SecurityManager workaround can be removed. Fixes: eclipse-archived/smarthome#6291 Undos: openhab#409 See also: * "Configurable Server Exit Behavior" in the Xtext 2.16.0 release notes: https://www.eclipse.org/Xtext/releasenotes.html#/releasenotes/2018/12/04/version-2-16-0 * eclipse/xtext-core#885 Signed-off-by: Wouter Born <github@maindrain.net>
maggu2810
pushed a commit
that referenced
this pull request
Apr 17, 2019
Xtext 2.17 allows for configuring the LanguageServer exit behavior so the SecurityManager workaround can be removed. Fixes: eclipse-archived/smarthome#6291 Undos: #409 See also: * "Configurable Server Exit Behavior" in the Xtext 2.16.0 release notes: https://www.eclipse.org/Xtext/releasenotes.html#/releasenotes/2018/12/04/version-2-16-0 * eclipse/xtext-core#885 Signed-off-by: Wouter Born <github@maindrain.net>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Kai Kreuzer <kai@openhab.org> GitOrigin-RevId: d3ffb2d
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
Xtext 2.17 allows for configuring the LanguageServer exit behavior so the SecurityManager workaround can be removed. Fixes: eclipse-archived/smarthome#6291 Undos: openhab#409 See also: * "Configurable Server Exit Behavior" in the Xtext 2.16.0 release notes: https://www.eclipse.org/Xtext/releasenotes.html#/releasenotes/2018/12/04/version-2-16-0 * eclipse/xtext-core#885 Signed-off-by: Wouter Born <github@maindrain.net> GitOrigin-RevId: fb972f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents openHAB from being shut down by
System.exit()calls as long as the core bundle is started (we obviously do not want to prevent the container from ever shutting down).This is specifically meant as a workaround for eclipse-archived/smarthome#6291, but
makes the server in general more robust wrt malicious third party code.
Signed-off-by: Kai Kreuzer kai@openhab.org