Support press and release buttons in sitemap generator #4204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
This was referenced Apr 30, 2024
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
mherwege
changed the title
|
Looks good but you will have to reinject the code for splitting press and release commands as I removed it from #4183 |
|
@lolodomo I don't know what happened, but the push of my commit seems to have been incomplete. I was sure I did the code for it. Should be OK now. |
J-N-K
added
rebuild
florian-h05
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
May 7, 2024
Related to openhab/openhab-core#4183. Depends on openhab/openhab-core#4204. This PR implements press/release button support. Refactor code to allow proper quoting of arguments in mappings and conditions. Quotes are now preserved, and therefore they need to be removed in core at usage (openhab/openhab-core#4204). --------- Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #4183
This PR adds support for press and release buttons in the sitemap generator.
It will required further testing after merging Depends on: #4183
The sitemap generator in the UI so far was stripping quotes from arguments in mappings and conditions sent to core.
As more functionality is added to the sitemap syntax, this is leading to problems to correctly interpret the arguments containing complex syntax:
To get over this limit, quote stripping should be removed on the UI side, but that means it needs to be done in core when creating the widget from the UIComponent.
Related to: openhab/openhab-webui#2553