[sitemap] Do not try to convert item state into OnOffType for Switch widget if item has options #4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…widget if item has options When the Switch widget has mappings or when the item has a state description with options, the Switch widget is rendered by UIs with buttons. There was no state conversion into OnOffType when the switch widget has mappings. But when the item has a state description with options, it was wrongly converted into OnOffType. See this community discussion for an example: https://community.openhab.org/t/item-statedescription-and-sitemaps/155935 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/item-statedescription-and-sitemaps/155935/9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Switch widget has mappings or when the item has a state description with options, the Switch widget is rendered by UIs with buttons. There was no state conversion into OnOffType when the switch widget has mappings. But when the item has a state description with options, it was wrongly converted into OnOffType.
See this community discussion for an example:
https://community.openhab.org/t/item-statedescription-and-sitemaps/155935
Signed-off-by: Laurent Garnier lg.hc@free.fr