Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception in WindowsUsbSerialDiscovery #4235

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix exception in WindowsUsbSerialDiscovery #4235

merged 1 commit into from
May 20, 2024

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented May 20, 2024 •
edited
Loading

@mherwege
fix deactivate error
3fb24b5 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner May 20, 2024 07:47
@mherwege mherwege mentioned this pull request May 20, 2024
Merged
J-N-K
J-N-K approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@J-N-K J-N-K changed the title usbserial windows fix deactivate error Fix exception in WindowsUsbSerialDiscovery May 20, 2024
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label May 20, 2024
@J-N-K J-N-K added this to the 4.2 milestone May 20, 2024
@J-N-K J-N-K merged commit c40b82f into openhab:main May 20, 2024
5 checks passed
@lolodomo
Copy link
Contributor

Thank you @mherwege
Did you check we don't have the same issue in the other UsbSerialDiscovery ?

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-2-milestone-discussion/154316/130

@mherwege
Copy link
Contributor Author

Thank you @mherwege
Did you check we don't have the same issue in the other UsbSerialDiscovery ?

No, I didn't.

@lolodomo
Copy link
Contributor

I found Ser2NetUsbSerialDiscovery: no bug because the deactivate method is missing. Should probably be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@mherwege @lolodomo @openhab-bot @J-N-K