Ensure the PoolBasedSequentialScheduledExecutorService does keep a minimum size #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nimum size Signed-off-by: Jörg Sautter <joerg.sautter@gmx.net>
joerg1985
force-pushed
the
keep-minimum-size
branch
from
4c35e97
to
a396475
Compare
|
@holgerfriedrich The issue is still present, now i have updated the timeout to see if this helps. |
holgerfriedrich
added
rebuild
wborn
added
rebuild
holgerfriedrich
added
bug
|
The CI seems to work better with the change - so far I could tell based on the few rebuilds I triggered. Jenkins fails seem to be unrelated. |
|
@holgerfriedrich i could split this into the timeout change of the unit test and the other change. This would take the pressure out of the review. What do you think? |
kaikreuzer
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will ensure the
PoolBasedSequentialScheduledExecutorServicedoes keep the configured minimum size.The unit test does now only need to spawn 10 new threads instead of up to 20, this should fix the latency issue.
@holgerfriedrich could you please run the CI multiple times for this PR to see if it does fix the issue?
Signed-off-by: Jörg Sautter joerg.sautter@gmx.net