Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Revert ThingImpl and BridgeImpl changes as the storage uses those implementations #719

Merged
merged 1 commit into from Apr 14, 2019

Conversation

Projects
None yet
5 participants
@cweitkamp
Copy link
Contributor

commented Apr 14, 2019

  • Partially revert #693

Closes #717 - But did not solve the root cause

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Revert ThingImpl and BridgeImpl changes as the storage uses those imp…
…lementations

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@openhab-bot

This comment has been minimized.

Copy link
Collaborator

commented Apr 14, 2019

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/snapshots-starting-with-2-5-0-s1568-1-broke-jsondb-parsing/72401/14

@maggu2810 maggu2810 merged commit 0aa7661 into openhab:master Apr 14, 2019

2 of 3 checks passed

PR-openHAB-Core Jenkins queued the run (PR opened)
Details
DCO DCO
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

maggu2810 added a commit to maggu2810/openhab-core that referenced this pull request Apr 15, 2019

Revert ThingImpl and BridgeImpl changes as the storage uses those imp…
…lementations (openhab#719)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>

@cweitkamp cweitkamp deleted the cweitkamp:bugfix-717-revert-thing-changes branch Apr 15, 2019

@cweitkamp

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

@kaikreuzer @wborn May I ask you to start a snapshot build?

@kaikreuzer

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Started!

@MattL0

This comment has been minimized.

Copy link

commented Apr 16, 2019

Works perfect . Thanks

@cweitkamp

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Started!

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.