Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatted the demo / example files #593

Merged
merged 1 commit into from Dec 3, 2017

Conversation

Projects
None yet
4 participants
@martinvw
Copy link
Member

commented Dec 1, 2017

Closes #590

Signed-off-by: Martin van Wingerden martinvw@mtin.nl

@martinvw martinvw requested review from kubawolanin and ThomDietrich Dec 1, 2017

@martinvw martinvw force-pushed the martinvw:feature/format-demo-files branch from 4a87481 to 40e6c3d Dec 1, 2017

@kubawolanin
Copy link

left a comment

LGTM!

@martinvw

This comment has been minimized.

Copy link
Member Author

commented Dec 1, 2017

I hope my commit did not break this...

14:34:48.290  |  [ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.1.3:kar (default-kar) on project openhab-addons: Failed to create archive: Could not transfer artifact org.openhab.binding:org.openhab.binding.lgwebos:jar:2.2.0-SNAPSHOT from/to p2-smarthome (https://openhab.jfrog.io/openhab/eclipse-smarthome-stable): Cannot access https://openhab.jfrog.io/openhab/eclipse-smarthome-stable with type p2 using the available connector factories: BasicRepositoryConnectorFactory
14:34:48.290  |  [ERROR] org.openhab.binding:org.openhab.binding.lgwebos:jar:2.2.0-SNAPSHOT
14:34:48.290  |  [ERROR] 
14:34:48.290  |  [ERROR] from the specified remote repositories:
14:34:48.290  |  [ERROR] central (http://repo1.maven.org/maven2, releases=true, snapshots=false),
14:34:48.290  |  [ERROR] jcenter (https://jcenter.bintray.com/, releases=true, snapshots=false),
14:34:48.291  |  [ERROR] openhab-artifactory-release (https://openhab.jfrog.io/openhab/libs-release, releases=true, snapshots=false),
14:34:48.291  |  [ERROR] openhab-artifactory-snapshot (https://openhab.jfrog.io/openhab/libs-snapshot, releases=false, snapshots=true),
14:34:48.291  |  [ERROR] p2-smarthome (https://openhab.jfrog.io/openhab/eclipse-smarthome-stable, releases=true, snapshots=true),
14:34:48.291  |  [ERROR] p2-openhab-deps-repo (https://dl.bintray.com/openhab/p2/openhab-deps-repo/1.0.19, releases=true, snapshots=true): Cannot access https://openhab.jfrog.io/openhab/eclipse-smarthome-stable with type p2 using the available layout factories: Maven2RepositoryLayoutFactory: Unsupported repository layout p2
14:34:48.291  |  [ERROR] -> [Help 1]
14:34:48.291  |  [ERROR] 
14:34:48.291  |  [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
14:34:48.291  |  [ERROR] Re-run Maven using the -X switch to enable full debug logging.
14:34:48.292  |  [ERROR] 
14:34:48.292  |  [ERROR] For more information about the errors and possible solutions, please read the following articles:
14:34:48.292  |  [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
14:34:48.292  |  [ERROR] 
14:34:48.292  |  [ERROR] After correcting the problems, you can resume the build with the command
14:34:48.292  |  [ERROR]   mvn <goals> -rf :openhab-addons
@ThomDietrich

This comment has been minimized.

Copy link
Member

commented Dec 1, 2017

Hey Martin,
looks way better now! Thanks!

  1. There is one exception with 2-space indention here
  2. The persistence file is imho a horrible example! 😅 not directly related to the PR but if you (or @kubawolanin ) agree I'll open a new PR to uncrapify it.
Formatted the demo / example files
Closes #590

Signed-off-by: Martin van Wingerden <martinvw@mtin.nl>

@martinvw martinvw force-pushed the martinvw:feature/format-demo-files branch from 40e6c3d to 32b4390 Dec 3, 2017

@martinvw

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2017

@ThomDietrich I fixed that last rule.

@kaikreuzer wdyt?

@kaikreuzer
Copy link
Member

left a comment

looks good, thanks!

@kaikreuzer kaikreuzer merged commit a450b6a into openhab:master Dec 3, 2017

1 check passed

Jenkins This pull request looks good
Details

@kaikreuzer kaikreuzer added this to the 2.2.0 milestone Dec 15, 2017

@kaikreuzer kaikreuzer modified the milestone: 2.2 Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.