New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarified JRE recommendations in installation index page #287
Conversation
-Updated language in JRE support statement for clarity -Added JRE comparison table -Updated 32-bit JRE statement to indicate it applies to ARM systems Signed-off-by: Stephen Bonar <contactme@stephenbonar.com> (github: stephenbonar)
installation/index.md
Outdated
Make sure that you have an up to date version of the [Oracle Java Runtime Environment](https://java.com/en/download/manual.jsp) on your host system installed. | ||
A famous choice is OpenJDK, however, Oracle Java Version 8 is recommended for openHAB. | ||
openHAB may be unstable and slower executed by OpenJDK. | ||
Make sure that you have an up to date Java Runtime Environment (JRE) installed on your host system. The [Oracle JRE](https://java.com/en/download/manual.jsp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would actually by now change the recommendation to Zulu. The main reason is that there are "no license fees or field of use restrictions".
Oracle JDK is (at lease on embedded systems) always subject to certain restrictions. You are actually only allowed to use it for development, but not for production. And a "pure" openHAB user probably does not really qualify as doing active development work. See https://blog.takipi.com/running-java-on-docker-youre-breaking-the-law/. Interesting is also that Oracle does not even seem to care to comment such concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The PINE64 image is already using Zulu Embedded now, so are our docker containers. I hope we will soon see an apt repo for Zulu Embedded, then we should also have openHABian use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even without an apt-repo, it should be fairly simple to install Zulu embedded as part of openHABian initial scripts.
wget http://cdn.azul.com/zulu-embedded/bin/ezdk-1.8.0_112-8.19.0.31-eval-linux_aarch32hf.tar.gz
sudo mkdir /var/lib/zulu
sudo tar xvfpz ezdk-1.8.0_112-8.19.0.31-eval-linux_aarch32hf.tar.gz -C /var/lib/zulu
sudo update-alternatives --install /usr/bin/java java /var/lib/zulu/ezdk-1.8.0_112-8.19.0.31-eval-linux_aarch32hf/bin/java 100
sudo update-alternatives --install /usr/bin/javac javac /var/lib/zulu/ezdk-1.8.0_112-8.19.0.31-eval-linux_aarch32hf/bin/javac 100
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BClark09 It's fairly easy for sure. The repository will be available soon and Oracle Java is doing the job just fine for now. I'd say it's not wrong to wait ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @kaikreuzer, let's make Zulu the recommended version.
For now I would however also point to Oracle Java as an equal option, if already installed for example.
@stephenbonar maybe you can come up with a nice statement
Also (others will laugh) please make sure your new paragraphs are one line per sentence, just like the existing text. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repository will be available soon
I actually just pinged them to ask for the status. 3 weeks ago it was just a few days away ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaikreuzer any news?
After messing around in the code and testing a few openHABian installations, I realized, that Oracle Java in the current way of installation is the cause for a few inpatient people thinking their installation was not successful... Nothing critical but I could just switch over to Zulu and be done with that. This will also pave the way for the pine and its 32bit problem.
Did anyone already do a performance comparison?
So I would do the manual installation from tar for now and sneak in the repository whenever it is available. How does that sound for you? 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaikreuzer any news?
Unfortunately not yet.
So I would do the manual installation from tar for now and sneak in the repository whenever it is available. How does that sound for you?
If the tar installation is straight forward, this sounds like a plan 👍
installation/index.md
Outdated
| --- | --- | --- | | ||
| Oracle | Full openHAB support on all platforms | Not supported by some Linux distributions (packages may not be available, requiring manual installation) | | ||
| OpenJDK | Supported by most Linux distributions (packages typically available) | Performance issues on ARM platforms, compatibiltiy issues with certain bindings and certificates | | ||
| Zulu Embedded | Optimized for ARM platforms, fully compliant with Java SE standard | Not available on all operating systems | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @stephenbonar,
great you reacted on the discussion we had on the forum ;) I like the table in general but please add a few links to the mix. Every name should be linked to it's official website and things like "Performance issues" need proof, as discussed in the forum.
I'm also not sure if you should talk about "JRE" as many will be confused by the JRE vs. JDK question. I'm not sure if "Java platform" or "JVM" is the better term to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a new commit which should address your comments. I pushed the commit to the feature branch of my fork; according to the contribution guidelines, this should be added to the pull request automatically - but let me know if they don't show up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I can see the new commit now. Let me know if you think I should change anything else.
installation/index.md
Outdated
|
||
Also make sure to use the 32-bit version of the JVM, even on 64-bit operating systems. Serial connections won't work with a 64-bit JVM, so bindings like Z-Wave won't be working with it. | ||
> Make sure to use the 32-bit version of the JVM for ARM platforms, even on 64-bit operating systems. Serial connections won't work with a 64-bit JVM, so bindings like Z-Wave won't be working with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the double "work" ? Thanks
installation/index.md
Outdated
Make sure that you have an up to date version of the [Oracle Java Runtime Environment](https://java.com/en/download/manual.jsp) on your host system installed. | ||
A famous choice is OpenJDK, however, Oracle Java Version 8 is recommended for openHAB. | ||
openHAB may be unstable and slower executed by OpenJDK. | ||
Make sure that you have an up to date Java Runtime Environment (JRE) installed on your host system. The [Oracle JRE](https://java.com/en/download/manual.jsp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @kaikreuzer, let's make Zulu the recommended version.
For now I would however also point to Oracle Java as an equal option, if already installed for example.
@stephenbonar maybe you can come up with a nice statement
Also (others will laugh) please make sure your new paragraphs are one line per sentence, just like the existing text. Thanks!
-Put all sentences in each paragraph on their own line -Added links to supporting information -Removed redunant language -Removed references to JRE Signed-off-by: Stephen Bonar <contactme@stephenbonar.com> (github: stephenbonar)
installation/index.md
Outdated
| --- | --- | --- | | ||
| [Zulu](http://www.azul.com/downloads/zulu/) | Completely open source, [fully certified](https://www.azul.com/products/zulu/) Java SE compliant build of OpenJDK, embedded version optimized for ARM devices [available here](http://www.azul.com/downloads/zulu-embedded/) | Not available in most default distribution package repositories | | ||
| [Oracle Java](https://java.com/en/download/manual.jsp) | Full openHAB support on all platforms | [Licensing restrictions](https://blog.takipi.com/running-java-on-docker-youre-breaking-the-law/), manual installation required on many Linux systems: [Ubuntu](https://help.ubuntu.com/community/Java), [Mint](https://community.linuxmint.com/tutorial/view/1091), and [Debian](https://wiki.debian.org/Java/Sun) are some examples | | ||
| [OpenJDK](http://openjdk.java.net/install/index.html) | Supported by many Linux distributions, packages typically available | [Performance issues](https://github.com/openhab/openhab-distro/issues/10#issuecomment-223786506) on ARM platforms, [compatibility issues](https://community.openhab.org/t/openhab-is-offline-message-fixed/17441/8) with certain bindings and certificates | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please link the landing pages instead of the download pages in the first column.
Besides that, everything LGTM.
@kaikreuzer any other concerns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made one more commit so the first column now points to the landing pages.
-Links in Java platform table now point to landing pages instead of downloads Signed-off-by: Stephen Bonar <contactme@stephenbonar.com> (github: stephenbonar)
Let's do this! Thanks @stephenbonar 😉 hope to see further additions by you 😃 |
-Updated language in JRE support statement for clarity
-Added JRE comparison table
-Updated 32-bit JRE statement to indicate it applies to ARM systems
Signed-off-by: Stephen Bonar contactme@stephenbonar.com (github: stephenbonar)