Actions/bindings/persistence docs track feature naming convention #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep links to binding docs as they were and to track the feature name of bindings. The bindings/oh1 and bindings/oh2 subdirectories are now gone. This PR supercedes openhab#296. Should persistence and actions be moved up a level from their current “oh1” directory, since they don’t use the “1” appended to the feature name? If yes, what happens when new features for persistence or actions are added later in OH2? Signed-off-by: John Cocula <john@cocula.com>
Yes, I would say so.
|
…ame will always mean the doc goes to `addons/${type}s/${id}`, this commit reflects this for actions, bindings and persistence service names.
An issue should be created to have Paper UI provide links to all add-ons, because it doesn’t appear to do so for non-OH2-native add-ons.
Signed-off-by: John Cocula <john@cocula.com>
|
The last commit should address #297 (comment). |
watou
changed the title
kaikreuzer
approved these changes
Feb 6, 2017
|
docs.openhab.org looks good from here. |
|
👍 Many thanks for your quick help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep links to binding docs as they were and to track the feature name of bindings. The bindings/oh1 and bindings/oh2 subdirectories are now gone.
Fixes #295. This PR supercedes #296.
Should persistence and actions be moved up a level from their current “oh1” directory, since they don’t use the “1” appended to the feature name? If yes, what happens when new features for persistence or actions are added later in OH2?
Signed-off-by: John Cocula john@cocula.com