Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TemperatureSensor does not work because it is missing required temperature range attributes #426

Closed
robnielsen opened this issue Jan 1, 2023 · 7 comments · Fixed by #432

Comments

@robnielsen
Copy link

According to https://developers.home.google.com/cloud-to-cloud/traits/temperaturecontrol, the min and max thresholds are required for the TemperatureControl trait:

Attributes Type Description
temperatureRange Object Required.
Supported temperature range of the device.
minThresholdCelsius Number Required.
Minimum temperature for the range, in degrees Celsius.
maxThresholdCelsius Number Required.
Maximum temperature for the range, in degrees Celsius.
@robnielsen
Copy link
Author

Here's an example for my ecobee remotes sensor:
Screenshot (Jan 1, 2023 9_25_26 AM)
Screenshot (Jan 1, 2023 9_25_51 AM)

@michikrug
Copy link
Collaborator

Thanks for reporting. Will create a PR to implement this.

@michikrug
Copy link
Collaborator

michikrug commented Jan 2, 2023

@robnielsen Unfortunately, still with my changes implemented, the Google Home App does not provide any UI for the sensor and just shows its info screen. Voice queries do work though.

Maybe Google relies for sensors on the devices to update their state in the home graph automatically to show a UI, which openHAB is currently not able to do. -> Just tested it with my experimental setup and it does not make any difference.

@robnielsen
Copy link
Author

@michikrug, This confirms what you are experiencing: https://issuetracker.google.com/issues/244185535

I wonder if ecobee is using the trait TemperatureSetting with the sensor instead of TemperatureControl?

@robnielsen
Copy link
Author

robnielsen commented Jan 2, 2023

@michikrug, when I ask Google Assistant "what is the temperature upstairs", it responds "It's currently 66 degrees and Upstairs is off".

@michikrug
Copy link
Collaborator

@michikrug, This confirms what you are experiencing: issuetracker.google.com/issues/244185535

I wonder if ecobee is using the trait TemperatureSetting with the sensor instead of TemperatureControl?

Haha, indeed. Just tested it with TemperatureSetting and exactly the same view as in your screenshot appeared. :D

@michikrug
Copy link
Collaborator

@robnielsen I just created #432 to switch to the other trait. Will close the other PR #428 as it did not fix the sensor.

michikrug added a commit that referenced this issue Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants