Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openHAB.sh for more reliable restarts. #50

Open
wants to merge 1 commit into
base: master
from

Conversation

@cutlasjgh
Copy link

cutlasjgh commented Jun 13, 2018

Changes to make openHAB restart more reliably.
I found under Qnap 4.3.4 there were 2 reasons that openHAB 2.0.0 won't start.
First reason would show up in logs as: "Java not found! Please read the documentation about details."
Second reason was issues with instance.properties file was both looked for in wrong path, and also not being removed. 3 changes were made:

  1. The old -d check for JAVA_HOME doesn't always work if directory is a link, use -e instead.
  2. Actual path to instance.properties file changed it seems, karaf was dropped from pathname.
  3. Removes instance.properties file after verifying process is not running.

Attempts to fix #31 #46 #47

Changes to make openHAB restart more reliably.
-the old -d check for JAVA_HOME doesn't always work if directory is a link, use -e instead.
-actual path to instance.properties file changed it seems, karaf was dropped from pathname.
-removes instance.properties file if process really down after a stop.
@thopiekar

This comment has been minimized.

Copy link
Collaborator

thopiekar commented Jul 11, 2018

Looks good to me. Additionally, it sounds to me like you are experienced.
Hope you don't mind that I'm not merging your PR, because there is no real maintainer at the moment.
If you are interested in maintaining this project, just let me know!

@Toffi32

This comment has been minimized.

Copy link

Toffi32 commented Aug 3, 2018

After some path are changed, this has to be adapted.

rm ${QPKG_DISTRIBUTION}/userdata/tmp/instances/instance.properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.