From 7b6fc15304d4be83b5087c7d09f04ded237c12eb Mon Sep 17 00:00:00 2001 From: Stefan Triller Date: Mon, 30 Aug 2021 18:39:44 +0200 Subject: [PATCH 1/3] Bugfix: Correct mimetype for disabling/enabling things call Fixes #1150 Signed-off-by: Stefan Triller --- .../web/src/pages/settings/things/thing-details.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue b/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue index a536206afc..b8a9bfc9e8 100644 --- a/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue +++ b/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue @@ -490,7 +490,7 @@ export default { }, toggleDisabled () { const enable = (this.thing.statusInfo.statusDetail === 'DISABLED') - this.$oh.api.putPlain('/rest/things/' + this.thingId + '/enable', enable.toString(), 'application/json', 'application/json').then((data) => { + this.$oh.api.putPlain('/rest/things/' + this.thingId + '/enable', enable.toString(), 'text/plain', 'text/plain').then((data) => { this.$f7.toast.create({ text: (enable) ? 'Thing enabled' : 'Thing disabled', destroyOnClose: true, From 4aa694b71f8453394e462c8f95241869581c1d61 Mon Sep 17 00:00:00 2001 From: Stefan Triller Date: Tue, 31 Aug 2021 08:32:30 +0200 Subject: [PATCH 2/3] Remove default parameters as discussed in review Signed-off-by: Stefan Triller --- .../web/src/pages/settings/things/thing-details.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue b/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue index b8a9bfc9e8..7bf64a6b5b 100644 --- a/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue +++ b/bundles/org.openhab.ui/web/src/pages/settings/things/thing-details.vue @@ -490,7 +490,7 @@ export default { }, toggleDisabled () { const enable = (this.thing.statusInfo.statusDetail === 'DISABLED') - this.$oh.api.putPlain('/rest/things/' + this.thingId + '/enable', enable.toString(), 'text/plain', 'text/plain').then((data) => { + this.$oh.api.putPlain('/rest/things/' + this.thingId + '/enable', enable.toString()).then((data) => { this.$f7.toast.create({ text: (enable) ? 'Thing enabled' : 'Thing disabled', destroyOnClose: true, From ebde55abde0da436c3547452f30cebfe920d8027 Mon Sep 17 00:00:00 2001 From: Stefan Triller Date: Tue, 31 Aug 2021 13:03:42 +0200 Subject: [PATCH 3/3] Fix disabling for list view Signed-off-by: Stefan Triller --- .../web/src/pages/settings/things/things-list.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bundles/org.openhab.ui/web/src/pages/settings/things/things-list.vue b/bundles/org.openhab.ui/web/src/pages/settings/things/things-list.vue index cc9f16c954..01994ef101 100644 --- a/bundles/org.openhab.ui/web/src/pages/settings/things/things-list.vue +++ b/bundles/org.openhab.ui/web/src/pages/settings/things/things-list.vue @@ -276,7 +276,7 @@ export default { doDisableEnableSelected (enable) { let dialog = this.$f7.dialog.progress('Please Wait...') - const promises = this.selectedItems.map((i) => this.$oh.api.putPlain('/rest/things/' + i + '/enable', enable.toString(), 'application/json', 'application/json')) + const promises = this.selectedItems.map((i) => this.$oh.api.putPlain('/rest/things/' + i + '/enable', enable.toString())) Promise.all(promises).then((data) => { this.$f7.toast.create({ text: (enable) ? 'Things enabled' : 'Things disabled',